All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org,
	cbe-oss-dev@ozlabs.org, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [Cbe-oss-dev] [patch 01/20] cell: add RAS support
Date: Tue, 20 Jun 2006 12:00:08 -0700	[thread overview]
Message-ID: <449845B8.6090401@am.sony.com> (raw)
In-Reply-To: <20060620175007.GE4845@pb15.lixom.net>

Olof Johansson wrote:
> On Tue, Jun 20, 2006 at 06:26:53PM +0200, Arnd Bergmann wrote:
>> On Tuesday 20 June 2006 17:43, Olof Johansson wrote:
>> > 
>> > > This is a first version of support for the Cell BE "Reliability,
>> > > Availability and Serviceability" features.
>> > 
>> > Does it really make sense to do this under a config option? I don't
> see
>> > why anyone would not want to know that their machine is about to
> melt.
>> > 
>> You can only have that when running on bare metal. Machines that run
>> on a hypervisor can't run that code.
> 
> Well, it's harmless to build it in even on hypervisor systems, right?


Harmless if you have a lot of RAM...


>> It probably makes sense to auto-select that option for
> CONFIG_CELL_BLADE
>> though.
> 
> Sounds like a reasonable trade-off.


If its always built in, then I guess we don't need the conditionals
in cell/setup.c:

+#ifdef CONFIG_CBE_RAS
+	cbe_ras_init();
+#endif


-Geoff

WARNING: multiple messages have this Message-ID (diff)
From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Olof Johansson <olof@lixom.net>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linuxppc-dev@ozlabs.org, paulus@samba.org,
	cbe-oss-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [Cbe-oss-dev] [patch 01/20] cell: add RAS support
Date: Tue, 20 Jun 2006 12:00:08 -0700	[thread overview]
Message-ID: <449845B8.6090401@am.sony.com> (raw)
In-Reply-To: <20060620175007.GE4845@pb15.lixom.net>

Olof Johansson wrote:
> On Tue, Jun 20, 2006 at 06:26:53PM +0200, Arnd Bergmann wrote:
>> On Tuesday 20 June 2006 17:43, Olof Johansson wrote:
>> > 
>> > > This is a first version of support for the Cell BE "Reliability,
>> > > Availability and Serviceability" features.
>> > 
>> > Does it really make sense to do this under a config option? I don't
> see
>> > why anyone would not want to know that their machine is about to
> melt.
>> > 
>> You can only have that when running on bare metal. Machines that run
>> on a hypervisor can't run that code.
> 
> Well, it's harmless to build it in even on hypervisor systems, right?


Harmless if you have a lot of RAM...


>> It probably makes sense to auto-select that option for
> CONFIG_CELL_BLADE
>> though.
> 
> Sounds like a reasonable trade-off.


If its always built in, then I guess we don't need the conditionals
in cell/setup.c:

+#ifdef CONFIG_CBE_RAS
+	cbe_ras_init();
+#endif


-Geoff


  reply	other threads:[~2006-06-20 19:30 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-19 18:33 [patch 00/20] cell: patches for 2.6.18 arnd
2006-06-19 18:33 ` [patch 01/20] cell: add RAS support arnd
2006-06-19 18:33   ` arnd
2006-06-20 15:43   ` [Cbe-oss-dev] " Olof Johansson
2006-06-20 15:43     ` Olof Johansson
2006-06-20 16:26     ` Arnd Bergmann
2006-06-20 16:26       ` Arnd Bergmann
2006-06-20 17:50       ` Olof Johansson
2006-06-20 17:50         ` Olof Johansson
2006-06-20 19:00         ` Geoff Levand [this message]
2006-06-20 19:00           ` Geoff Levand
2006-06-21  1:46     ` Benjamin Herrenschmidt
2006-06-21  1:46       ` Benjamin Herrenschmidt
2006-06-19 18:33 ` [patch 02/20] cell: fix interrupt priority handling arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 03/20] cell: update defconfig arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 04/20] cell: register SPUs as sysdevs arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 05/20] cell: always build spu base into the kernel arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 06/20] spufs: restore mapping of mssync register arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 07/20] spufs: fix deadlock in spu_create error path arnd
2006-06-19 18:33   ` arnd
2006-06-20  1:16   ` Michael Ellerman
2006-06-20  1:16     ` Michael Ellerman
2006-06-19 18:33 ` [patch 08/20] spufs: set up correct SLB entries for 64k pages arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 09/20] spufs: add a phys-id attribute to each SPU context arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 10/20] spufs: fix initial state of wbox file arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 11/20] spufs: use kzalloc in create_spu arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 12/20] spufs: dont try to access SPE channel 1 count arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 13/20] spufs: split the Cell BE support into generic and platform dependant parts arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 14/20] spufs: further abstract priv1 register access arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 15/20] spufs: fix spu irq affinity setting arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 16/20] spufs: remove stop_code from struct spu arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 17/20] spufs: fix Makefile for "make clean" arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 18/20] spufs: clear class2 interrupt status before wakeup arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 19/20] spufs: fail spu_create with invalid flags arnd
2006-06-19 18:33   ` arnd
2006-06-19 18:33 ` [patch 20/20] spufs: one more fix for 64k pages arnd
2006-06-19 18:33   ` arnd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=449845B8.6090401@am.sony.com \
    --to=geoffrey.levand@am.sony.com \
    --cc=arnd@arndb.de \
    --cc=cbe-oss-dev@ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olof@lixom.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.