From: "Heiko Stübner" <heiko@sntech.de>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Shreeya Patel <shreeya.patel@collabora.com>,
Simon Xue <xxm@rock-chips.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Quentin Schulz <foss+kernel@0leil.net>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Quentin Schulz <foss+kernel@0leil.net>
Subject: Re: [PATCH 1/3] iio: adc: rockchip_saradc: fix bitmask for channels on SARADCv2
Date: Fri, 23 Feb 2024 14:40:37 +0100 [thread overview]
Message-ID: <4499105.Wku2Vz74k6@diego> (raw)
In-Reply-To: <20240223-saradcv2-chan-mask-v1-1-84b06a0f623a@theobroma-systems.com>
Am Freitag, 23. Februar 2024, 13:45:21 CET schrieb Quentin Schulz:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> The SARADCv2 on RK3588 (the only SoC currently supported that has an
> SARADCv2) selects the channel through the channel_sel bitfield which is
> the 4 lowest bits, therefore the mask should be GENMASK(3, 0) and not
> GENMASK(15, 0).
>
> Fixes: 757953f8ec69 ("iio: adc: rockchip_saradc: Add support for RK3588")
> Cc: Quentin Schulz <foss+kernel@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
after checking against the TRM
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Shreeya Patel <shreeya.patel@collabora.com>,
Simon Xue <xxm@rock-chips.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Quentin Schulz <foss+kernel@0leil.net>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Quentin Schulz <foss+kernel@0leil.net>
Subject: Re: [PATCH 1/3] iio: adc: rockchip_saradc: fix bitmask for channels on SARADCv2
Date: Fri, 23 Feb 2024 14:40:37 +0100 [thread overview]
Message-ID: <4499105.Wku2Vz74k6@diego> (raw)
In-Reply-To: <20240223-saradcv2-chan-mask-v1-1-84b06a0f623a@theobroma-systems.com>
Am Freitag, 23. Februar 2024, 13:45:21 CET schrieb Quentin Schulz:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> The SARADCv2 on RK3588 (the only SoC currently supported that has an
> SARADCv2) selects the channel through the channel_sel bitfield which is
> the 4 lowest bits, therefore the mask should be GENMASK(3, 0) and not
> GENMASK(15, 0).
>
> Fixes: 757953f8ec69 ("iio: adc: rockchip_saradc: Add support for RK3588")
> Cc: Quentin Schulz <foss+kernel@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
after checking against the TRM
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Shreeya Patel <shreeya.patel@collabora.com>,
Simon Xue <xxm@rock-chips.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Quentin Schulz <foss+kernel@0leil.net>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Quentin Schulz <foss+kernel@0leil.net>
Subject: Re: [PATCH 1/3] iio: adc: rockchip_saradc: fix bitmask for channels on SARADCv2
Date: Fri, 23 Feb 2024 14:40:37 +0100 [thread overview]
Message-ID: <4499105.Wku2Vz74k6@diego> (raw)
In-Reply-To: <20240223-saradcv2-chan-mask-v1-1-84b06a0f623a@theobroma-systems.com>
Am Freitag, 23. Februar 2024, 13:45:21 CET schrieb Quentin Schulz:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> The SARADCv2 on RK3588 (the only SoC currently supported that has an
> SARADCv2) selects the channel through the channel_sel bitfield which is
> the 4 lowest bits, therefore the mask should be GENMASK(3, 0) and not
> GENMASK(15, 0).
>
> Fixes: 757953f8ec69 ("iio: adc: rockchip_saradc: Add support for RK3588")
> Cc: Quentin Schulz <foss+kernel@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
after checking against the TRM
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-23 13:41 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 12:45 [PATCH 0/3] iio: adc: rockchip_saradc: fix bitmasking and remove custom logic for getting reset Quentin Schulz
2024-02-23 12:45 ` Quentin Schulz
2024-02-23 12:45 ` Quentin Schulz
2024-02-23 12:45 ` [PATCH 1/3] iio: adc: rockchip_saradc: fix bitmask for channels on SARADCv2 Quentin Schulz
2024-02-23 12:45 ` Quentin Schulz
2024-02-23 12:45 ` Quentin Schulz
2024-02-23 13:40 ` Heiko Stübner [this message]
2024-02-23 13:40 ` Heiko Stübner
2024-02-23 13:40 ` Heiko Stübner
2024-02-23 12:45 ` [PATCH 2/3] iio: adc: rockchip_saradc: use mask for write_enable bitfield Quentin Schulz
2024-02-23 12:45 ` Quentin Schulz
2024-02-23 12:45 ` Quentin Schulz
2024-02-23 13:43 ` Heiko Stübner
2024-02-23 13:43 ` Heiko Stübner
2024-02-23 13:43 ` Heiko Stübner
2024-02-23 12:45 ` [PATCH 3/3] iio: adc: rockchip_saradc: replace custom logic with devm_reset_control_get_optional_exclusive Quentin Schulz
2024-02-23 12:45 ` Quentin Schulz
2024-02-23 12:45 ` Quentin Schulz
2024-02-23 13:00 ` Andy Shevchenko
2024-02-23 13:00 ` Andy Shevchenko
2024-02-23 13:00 ` Andy Shevchenko
2024-02-23 13:10 ` Quentin Schulz
2024-02-23 13:10 ` Quentin Schulz
2024-02-23 13:10 ` Quentin Schulz
2024-02-23 14:39 ` Andy Shevchenko
2024-02-23 14:39 ` Andy Shevchenko
2024-02-23 14:39 ` Andy Shevchenko
2024-02-26 20:31 ` Dragan Simic
2024-02-26 20:31 ` Dragan Simic
2024-02-26 20:31 ` Dragan Simic
2024-02-27 12:48 ` Andy Shevchenko
2024-02-27 12:48 ` Andy Shevchenko
2024-02-27 12:48 ` Andy Shevchenko
2024-02-27 14:55 ` Dragan Simic
2024-02-27 14:55 ` Dragan Simic
2024-02-27 14:55 ` Dragan Simic
2024-02-23 13:44 ` Heiko Stübner
2024-02-23 13:44 ` Heiko Stübner
2024-02-23 13:44 ` Heiko Stübner
2024-02-23 13:01 ` [PATCH 0/3] iio: adc: rockchip_saradc: fix bitmasking and remove custom logic for getting reset Andy Shevchenko
2024-02-23 13:01 ` Andy Shevchenko
2024-02-23 13:01 ` Andy Shevchenko
2024-02-24 19:25 ` Jonathan Cameron
2024-02-24 19:25 ` Jonathan Cameron
2024-02-24 19:25 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4499105.Wku2Vz74k6@diego \
--to=heiko@sntech.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=foss+kernel@0leil.net \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=quentin.schulz@theobroma-systems.com \
--cc=shreeya.patel@collabora.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.