[Adeos-main] __ipipe_grab_irq

[Adeos-main] __ipipe_grab_irq

[A C]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

Hello,
in the function __ipipe_grab_irq for the NIOS2, there is the following block :

if (likely(irq == __ipipe_hrtimer_irq)) {
        __raw_get_cpu_var(__ipipe_tick_regs).estatus = regs->estatus;
        __raw_get_cpu_var(__ipipe_tick_regs).ea = regs->ea;
        if (!__ipipe_root_domain_p) {
            __raw_get_cpu_var(__ipipe_tick_regs).estatus &= ~NIOS2_STATUS_PIE_MSK); 
              }
    }

We do not understand why there is an unusual case for an interruption from the timer. We understand each lines but not the global nature. Any help ?

Cheers
Adrien Chiron & Vincent Vanbesien


      

[-- Attachment #2: Type: text/html, Size: 1150 bytes --]

Re: [Adeos-main] __ipipe_grab_irq

[Philippe Gerum]

On Thu, 2010-01-07 at 13:48 +0000, A C wrote:
> Hello,
> in the function __ipipe_grab_irq for the NIOS2, there is the following
> block :
> 
> if (likely(irq == __ipipe_hrtimer_irq)) {
>         __raw_get_cpu_var(__ipipe_tick_regs).estatus = regs->estatus;
>         __raw_get_cpu_var(__ipipe_tick_regs).ea = regs->ea;
>         if (!__ipipe_root_domain_p) {
>             __raw_get_cpu_var(__ipipe_tick_regs).estatus &=
> ~NIOS2_STATUS_PIE_MSK); 
>               }
>     }

This should read:

diff --git a/arch/nios2/kernel/ipipe.c b/arch/nios2/kernel/ipipe.c
index e88d788..2ec178c 100644
--- a/arch/nios2/kernel/ipipe.c
+++ b/arch/nios2/kernel/ipipe.c
@@ -290,7 +290,7 @@ int __ipipe_grab_irq(int irq, struct pt_regs *regs)
 {
 	if (likely(irq == __ipipe_hrtimer_irq)) {
 		__raw_get_cpu_var(__ipipe_tick_regs).estatus = regs->estatus;
-		__raw_get_cpu_var(__ipipe_tick_regs).ea = regs->ea;
+		__raw_get_cpu_var(__ipipe_tick_regs).ra = regs->ra;
 		if (!__ipipe_root_domain_p) {
 			__raw_get_cpu_var(__ipipe_tick_regs).estatus
 				&= ~NIOS2_STATUS_PIE_MSK;

> 
> We do not understand why there is an unusual case for an interruption
> from the timer. We understand each lines but not the global nature.
> Any help ?
> 

The linux kernel does basic sampling-based profiling and assesses the
current load average by looking at which code the timer tick did
preempt. Since we have a deferred interrupt model, and possibly many
non-linux tick interrupts passed to the upper domain(s), we have to
somehow forge a timer tick frame specifically for linux, which we then
pass to the regular tick handler (to any regular IRQ handler in fact,
since only the tick handler uses this info), for keeping those
computations accurate.

> Cheers
> Adrien Chiron & Vincent Vanbesien
> 
> 
> 
> _______________________________________________
> Adeos-main mailing list
> Adeos-main@domain.hid
> https://mail.gna.org/listinfo/adeos-main


-- 
Philippe.