All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] fix linux ioremap() of domain local memory
Date: Thu, 22 Jun 2006 21:08:06 +0300	[thread overview]
Message-ID: <449ADC86.4070902@qumranet.com> (raw)

is_local_lowmem() treats its physical address input as a machine 
address; this causes agpgart to fail while calling ioremap_nocache().

X still does not load on my Athlon 64 / Via S3 Unichrome, so perhaps 
best not to apply just yet.

Signed-off-by: Avi Kivity <avi@qumranet.com>

--- xen-ioremap-fix/linux-2.6-xen-sparse/arch/i386/mm/ioremap-xen.c~ioremap	2006-06-22 20:30:20.000000000 +0300
+++ xen-ioremap-fix/linux-2.6-xen-sparse/arch/i386/mm/ioremap-xen.c	2006-06-22 20:31:09.000000000 +0300
@@ -206,13 +206,11 @@
 /*
  * Does @address reside within a non-highmem page that is local to this virtual
  * machine (i.e., not an I/O page, nor a memory page belonging to another VM).
- * See the comment that accompanies mfn_to_local_pfn() in page.h to understand
- * why this works.
  */
 static inline int is_local_lowmem(unsigned long address)
 {
 	extern unsigned long max_low_pfn;
-	return (mfn_to_local_pfn(address >> PAGE_SHIFT) < max_low_pfn);
+	return ((address >> PAGE_SHIFT) < max_low_pfn);
 }
 
 /*




-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

             reply	other threads:[~2006-06-22 18:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-22 18:08 Avi Kivity [this message]
2006-06-25 10:17 ` [PATCH] fix linux ioremap() of domain local memory Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=449ADC86.4070902@qumranet.com \
    --to=avi@qumranet.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.