All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: xen-devel@lists.xensource.com
Subject: Re: [PATCH] fix linux ioremap() of domain local memory
Date: Sun, 25 Jun 2006 13:17:34 +0300	[thread overview]
Message-ID: <449E62BE.9080301@qumranet.com> (raw)
In-Reply-To: <449ADC86.4070902@qumranet.com>

Avi Kivity wrote:
> is_local_lowmem() treats its physical address input as a machine 
> address; this causes agpgart to fail while calling ioremap_nocache().
>
> X still does not load on my Athlon 64 / Via S3 Unichrome, so perhaps 
> best not to apply just yet.

This is bogus: ioremap_nocache() does accept machine addresses, but 
x86_64 agpgart passes it a physical address.  This is because x86_64 
lacks the address translation bits:

--- /dev/null   2006-06-25 13:08:55.714359750 +0300
+++ include/asm-x86_64/mach-xen/asm/agp.h       2006-06-25 13:15:12.000000000 +0300
@@ -0,0 +1 @@
+#include "../../../asm-i386/mach-xen/asm/agp.h"


Still locks up hard when starting up X, but now the gart table is 
remapped correctly at least.

-- 
error compiling committee.c: too many arguments to function

      reply	other threads:[~2006-06-25 10:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-22 18:08 [PATCH] fix linux ioremap() of domain local memory Avi Kivity
2006-06-25 10:17 ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=449E62BE.9080301@qumranet.com \
    --to=avi@qumranet.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.