* [PATCH] kmalloc arguments in wrong order (53c700)
@ 2006-06-22 20:48 Al Viro
2006-06-23 0:46 ` Douglas Gilbert
0 siblings, 1 reply; 4+ messages in thread
From: Al Viro @ 2006-06-22 20:48 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-scsi
Could people please run make C=2 at some point?
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
drivers/scsi/53c700.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
c14b0d0f9f7df1aeb96e1651927ea902368e3175
diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c
index 3c683dc..bff0479 100644
--- a/drivers/scsi/53c700.c
+++ b/drivers/scsi/53c700.c
@@ -2044,7 +2044,7 @@ NCR_700_slave_configure(struct scsi_devi
struct NCR_700_Host_Parameters *hostdata =
(struct NCR_700_Host_Parameters *)SDp->host->hostdata[0];
- SDp->hostdata = kmalloc(GFP_KERNEL, sizeof(struct NCR_700_sense));
+ SDp->hostdata = kmalloc(sizeof(struct NCR_700_sense), GFP_KERNEL);
if (!SDp->hostdata)
return -ENOMEM;
--
1.3.GIT
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] kmalloc arguments in wrong order (53c700)
2006-06-22 20:48 [PATCH] kmalloc arguments in wrong order (53c700) Al Viro
@ 2006-06-23 0:46 ` Douglas Gilbert
2006-06-23 1:42 ` Randy.Dunlap
2006-06-23 4:55 ` Linus Torvalds
0 siblings, 2 replies; 4+ messages in thread
From: Douglas Gilbert @ 2006-06-23 0:46 UTC (permalink / raw)
To: Al Viro; +Cc: Linus Torvalds, linux-scsi
Al Viro wrote:
> Could people please run make C=2 at some point?
Is "sparse" packaged somewhere?
Doug Gilbert
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kmalloc arguments in wrong order (53c700)
2006-06-23 0:46 ` Douglas Gilbert
@ 2006-06-23 1:42 ` Randy.Dunlap
2006-06-23 4:55 ` Linus Torvalds
1 sibling, 0 replies; 4+ messages in thread
From: Randy.Dunlap @ 2006-06-23 1:42 UTC (permalink / raw)
To: dougg; +Cc: viro, torvalds, linux-scsi
On Thu, 22 Jun 2006 20:46:31 -0400 Douglas Gilbert wrote:
> Al Viro wrote:
> > Could people please run make C=2 at some point?
>
> Is "sparse" packaged somewhere?
Source tarball snapshots of it are (if you have a git aversion)
at http://www.codemonkey.org.uk/projects/git-snapshots/sparse/
I don't know of any binary packages for it. Some distros
may do that, but it's so very easy to build from source.
---
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] kmalloc arguments in wrong order (53c700)
2006-06-23 0:46 ` Douglas Gilbert
2006-06-23 1:42 ` Randy.Dunlap
@ 2006-06-23 4:55 ` Linus Torvalds
1 sibling, 0 replies; 4+ messages in thread
From: Linus Torvalds @ 2006-06-23 4:55 UTC (permalink / raw)
To: Douglas Gilbert; +Cc: Al Viro, linux-scsi
On Thu, 22 Jun 2006, Douglas Gilbert wrote:
> Al Viro wrote:
> > Could people please run make C=2 at some point?
>
> Is "sparse" packaged somewhere?
I don't think it is, but it is easy enough to build.
git clone git://git.kernel.org/pub/scm/devel/sparse/sparse.git
cd sparse
make
make install
should do it.
Modern gcc's give a ton of
warning: value computed is not used
warnings, but quite frankly, that's a gcc bug, not a a sparse problem.
Linus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-06-23 4:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-22 20:48 [PATCH] kmalloc arguments in wrong order (53c700) Al Viro
2006-06-23 0:46 ` Douglas Gilbert
2006-06-23 1:42 ` Randy.Dunlap
2006-06-23 4:55 ` Linus Torvalds
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.