All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Reiser <reiser@namesys.com>
To: Nate Diller <nate.diller@gmail.com>
Cc: Nick Piggin <npiggin@suse.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>,
	David Howells <dhowells@redhat.com>,
	Christoph Lameter <christoph@lameter.com>,
	Martin Bligh <mbligh@google.com>,
	Linus Torvalds <torvalds@osdl.org>,
	"E. Gryaznova" <grev@namesys.com>
Subject: Re: [PATCH] mm/tracking dirty pages: update get_dirty_limits for mmap tracking
Date: Fri, 23 Jun 2006 00:31:29 -0700	[thread overview]
Message-ID: <449B98D1.3010005@namesys.com> (raw)
In-Reply-To: <5c49b0ed0606211525i57628af5yaef46ee4e1820339@mail.gmail.com>

Nate, you should note that A: increasing to 80% was my idea, and B: the
data from the benchmarks provide no indication that it is a good idea.

That said, it is very possible that C: the benchmark is flawed, because
the variance is so high that I am suspicious that something is wrong
with the benchmark, and D: that the implementation is flawed in some way
we don't yet see.

All that said, I cannot say that we have anything here that suggests the
change is a good change.   My intuition says it should be a good change,
but the data does not.  Not yet. 

Hans

WARNING: multiple messages have this Message-ID (diff)
From: Hans Reiser <reiser@namesys.com>
To: Nate Diller <nate.diller@gmail.com>
Cc: Nick Piggin <npiggin@suse.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Hugh Dickins <hugh@veritas.com>, Andrew Morton <akpm@osdl.org>,
	David Howells <dhowells@redhat.com>,
	Christoph Lameter <christoph@lameter.com>,
	Martin Bligh <mbligh@google.com>,
	Linus Torvalds <torvalds@osdl.org>,
	"E. Gryaznova" <grev@namesys.com>
Subject: Re: [PATCH] mm/tracking dirty pages: update get_dirty_limits for mmap tracking
Date: Fri, 23 Jun 2006 00:31:29 -0700	[thread overview]
Message-ID: <449B98D1.3010005@namesys.com> (raw)
In-Reply-To: <5c49b0ed0606211525i57628af5yaef46ee4e1820339@mail.gmail.com>

Nate, you should note that A: increasing to 80% was my idea, and B: the
data from the benchmarks provide no indication that it is a good idea.

That said, it is very possible that C: the benchmark is flawed, because
the variance is so high that I am suspicious that something is wrong
with the benchmark, and D: that the implementation is flawed in some way
we don't yet see.

All that said, I cannot say that we have anything here that suggests the
change is a good change.   My intuition says it should be a good change,
but the data does not.  Not yet. 

Hans

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-06-23  7:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-21 17:01 [PATCH] mm/tracking dirty pages: update get_dirty_limits for mmap tracking Nate Diller
2006-06-21 17:01 ` Nate Diller
2006-06-21 18:08 ` Nick Piggin
2006-06-21 18:08   ` Nick Piggin
2006-06-21 22:25   ` Nate Diller
2006-06-21 22:25     ` Nate Diller
2006-06-23  7:31     ` Hans Reiser [this message]
2006-06-23  7:31       ` Hans Reiser
2006-06-21 18:13 ` Martin Bligh
2006-06-21 18:13   ` Martin Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=449B98D1.3010005@namesys.com \
    --to=reiser@namesys.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@osdl.org \
    --cc=christoph@lameter.com \
    --cc=dhowells@redhat.com \
    --cc=grev@namesys.com \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mbligh@google.com \
    --cc=nate.diller@gmail.com \
    --cc=npiggin@suse.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.