All of lore.kernel.org
 help / color / mirror / Atom feed
* e820.c : why char* ?
@ 2006-06-23 16:09 PUCCETTI Armand
  0 siblings, 0 replies; only message in thread
From: PUCCETTI Armand @ 2006-06-23 16:09 UTC (permalink / raw)
  To: xen-devel

In function

sanitize_e820_map(struct e820entry * biosmap, char * pnr_map)

of file e820.c, the last argument is treated as an integer, but when 
compiling with gcc
it belongs to [-128,127].

Inside the body of that function, however, we use that argument as an 
int to fill up a table of a different
size, namely:

static struct change_member *change_point [256]
static struct change_member change_point_list [256]
static int __init sanitize_e820_map(struct e820entry * biosmap, char * 
pnr_map)
{
...
old_nr = *pnr_map;
...
for (i=0; i < 2*old_nr; i++) {
        change_point[i] = &change_point_list[i];
...
}

After the loop, change_point is not completely filled-up, as 
change_point [254] and change_point [255]
are never filled nor used.

Is it voluntary that pnr_map gets typed and used like this?

Armand

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-06-23 16:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-23 16:09 e820.c : why char* ? PUCCETTI Armand

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.