[PATCH] smc91x: disable DMA mode on the logicpd pxa270

[PATCH] smc91x: disable DMA mode on the logicpd pxa270

[Lennert Buytenhek]

Enabling PXA DMA for the smc91x on the logicpd pxa270 produces
unacceptable interference with the TFT panel, so disable it.  Also
delete the lpd270 versions of the SMC_{in,out}[bl]() macros, as they
aren't used, since the board only supports 16bit accesses.

Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>

Index: linux-2.6.17-git5/drivers/net/smc91x.h
===================================================================
--- linux-2.6.17-git5.orig/drivers/net/smc91x.h
+++ linux-2.6.17-git5/drivers/net/smc91x.h
@@ -136,14 +136,9 @@
 #define SMC_CAN_USE_32BIT	0
 #define SMC_IO_SHIFT		0
 #define SMC_NOWAIT		1
-#define SMC_USE_PXA_DMA		1
 
-#define SMC_inb(a, r)		readb((a) + (r))
 #define SMC_inw(a, r)		readw((a) + (r))
-#define SMC_inl(a, r)		readl((a) + (r))
-#define SMC_outb(v, a, r)	writeb(v, (a) + (r))
 #define SMC_outw(v, a, r)	writew(v, (a) + (r))
-#define SMC_outl(v, a, r)	writel(v, (a) + (r))
 #define SMC_insw(a, r, p, l)	readsw((a) + (r), p, l)
 #define SMC_outsw(a, r, p, l)	writesw((a) + (r), p, l)

Re: [PATCH] smc91x: disable DMA mode on the logicpd pxa270

[Jeff Garzik]

Lennert Buytenhek wrote:
> Enabling PXA DMA for the smc91x on the logicpd pxa270 produces
> unacceptable interference with the TFT panel, so disable it.  Also
> delete the lpd270 versions of the SMC_{in,out}[bl]() macros, as they
> aren't used, since the board only supports 16bit accesses.
> 
> Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>
> 
> Index: linux-2.6.17-git5/drivers/net/smc91x.h

ACK, but git-applymbox claims the patch is corrupt

Re: [PATCH] smc91x: disable DMA mode on the logicpd pxa270

[Lennert Buytenhek]

On Mon, Jun 26, 2006 at 10:02:52PM -0400, Jeff Garzik wrote:

> >Enabling PXA DMA for the smc91x on the logicpd pxa270 produces
> >unacceptable interference with the TFT panel, so disable it.  Also
> >delete the lpd270 versions of the SMC_{in,out}[bl]() macros, as they
> >aren't used, since the board only supports 16bit accesses.
> >
> >Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>
> >
> >Index: linux-2.6.17-git5/drivers/net/smc91x.h
> 
> ACK, but git-applymbox claims the patch is corrupt

Hmmm, non-quilt style patch better?

==
Enabling PXA DMA for the smc91x on the logicpd pxa270 produces
unacceptable interference with the TFT panel, so disable it.  Also
delete the lpd270 versions of the SMC_{in,out}[bl]() macros, as they
aren't used, since the board only supports 16bit accesses.

Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>

--- linux-2.6.17-git10.orig/drivers/net/smc91x.h	2006-06-27 04:05:20.000000000 +0200
+++ linux-2.6.17-git10/drivers/net/smc91x.h	2006-06-27 04:05:47.000000000 +0200
@@ -136,14 +136,9 @@
 #define SMC_CAN_USE_32BIT	0
 #define SMC_IO_SHIFT		0
 #define SMC_NOWAIT		1
-#define SMC_USE_PXA_DMA		1
 
-#define SMC_inb(a, r)		readb((a) + (r))
 #define SMC_inw(a, r)		readw((a) + (r))
-#define SMC_inl(a, r)		readl((a) + (r))
-#define SMC_outb(v, a, r)	writeb(v, (a) + (r))
 #define SMC_outw(v, a, r)	writew(v, (a) + (r))
-#define SMC_outl(v, a, r)	writel(v, (a) + (r))
 #define SMC_insw(a, r, p, l)	readsw((a) + (r), p, l)
 #define SMC_outsw(a, r, p, l)	writesw((a) + (r), p, l)

Re: [PATCH] smc91x: disable DMA mode on the logicpd pxa270

[Lennert Buytenhek]

On Tue, Jun 27, 2006 at 04:08:31AM +0200, Lennert Buytenhek wrote:

> Hmmm, non-quilt style patch better?

I might have an idea what's happening -- the last context line in the
patch should have been a blank line, but it's being eaten somewhere in
transit.

> -#define SMC_inb(a, r)		readb((a) + (r))
>  #define SMC_inw(a, r)		readw((a) + (r))
> -#define SMC_inl(a, r)		readl((a) + (r))
> -#define SMC_outb(v, a, r)	writeb(v, (a) + (r))
>  #define SMC_outw(v, a, r)	writew(v, (a) + (r))
> -#define SMC_outl(v, a, r)	writel(v, (a) + (r))
>  #define SMC_insw(a, r, p, l)	readsw((a) + (r), p, l)
>  #define SMC_outsw(a, r, p, l)	writesw((a) + (r), p, l)

<=== there should have been a blank line here

> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Not sure what is causing this.  Can you take it from here?

	http://www.wantstofly.org/~buytenh/smc91-diff-lpd.diff


thanks,
Lennert