Re: [PATCH] Longhaul - There are limits

["Rafał Bilski" <rafalbilski@interia.pl>]

> [...]
> 
> It's not unfeasible for an SMP kernel to be run on UP hardware,
> (and several distros are shipping SMP kernels as default)
> so I'm in two minds about removing the !SMP check, and making it be a
> 
> 	if (num_online_cpus() > 1)
> 		return -ENODEV;
> 
> in the init routine.
> 
> Thoughts?
> 
> 		Dave
> 

It is good idea, but I think there should be check for APIC too, 
but I don't know how to make it. !X86_UP_APIC is for non SMP 
kernels only. It is possible that in this case there will be 
SMP kernel running on single processor with APIC enabled. 
I don't know much about APIC, but as far I know we are poking 
PIC registers direcly and in such case not all interrupts will
be disabled.

Rafa³


------------------------------------------------------------------------
Znajd¼ krótsz± drogê do pracy!
http://map24.interia.pl - interaktywny planer podró¿y.