From: Jim Cromie <jim.cromie@gmail.com>
To: Linux kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: [ patch -mm1 01/03 ] gpio: drop vtable members .gpio_set_high .gpio_set_low gpio_set is enough.
Date: Wed, 12 Jul 2006 11:20:17 -0600 [thread overview]
Message-ID: <44B52F51.6040005@gmail.com> (raw)
1 - drops gpio_set_high, gpio_set_low from the nsc_gpio_ops vtable.
While we can't drop them from scx200_gpio (or can we?), we dont need them
for new users of the exported vtable; gpio_set(1), gpio_set(0) work fine.
Signed-off-by Jim Cromie <jim.cromie@gmail.com>
---
[jimc@harpo fxd3]$ diffstat diff.nosethilo
drivers/char/pc8736x_gpio.c | 2 --
drivers/char/scx200_gpio.c | 2 --
include/linux/nsc_gpio.h | 2 --
3 files changed, 6 deletions(-)
diff -ruNp -X dontdiff -X exclude-diffs aa-0/drivers/char/pc8736x_gpio.c a0-nohilo/drivers/char/pc8736x_gpio.c
--- aa-0/drivers/char/pc8736x_gpio.c 2006-07-09 10:37:54.000000000 -0600
+++ a0-nohilo/drivers/char/pc8736x_gpio.c 2006-07-12 09:21:58.000000000 -0600
@@ -218,8 +218,6 @@ static struct nsc_gpio_ops pc8736x_acces
.gpio_dump = nsc_gpio_dump,
.gpio_get = pc8736x_gpio_get,
.gpio_set = pc8736x_gpio_set,
- .gpio_set_high = pc8736x_gpio_set_high,
- .gpio_set_low = pc8736x_gpio_set_low,
.gpio_change = pc8736x_gpio_change,
.gpio_current = pc8736x_gpio_current
};
diff -ruNp -X dontdiff -X exclude-diffs aa-0/drivers/char/scx200_gpio.c a0-nohilo/drivers/char/scx200_gpio.c
--- aa-0/drivers/char/scx200_gpio.c 2006-07-11 12:14:57.000000000 -0600
+++ a0-nohilo/drivers/char/scx200_gpio.c 2006-07-12 09:20:55.000000000 -0600
@@ -41,8 +41,6 @@ struct nsc_gpio_ops scx200_access = {
.gpio_dump = nsc_gpio_dump,
.gpio_get = scx200_gpio_get,
.gpio_set = scx200_gpio_set,
- .gpio_set_high = scx200_gpio_set_high,
- .gpio_set_low = scx200_gpio_set_low,
.gpio_change = scx200_gpio_change,
.gpio_current = scx200_gpio_current
};
diff -ruNp -X dontdiff -X exclude-diffs aa-0/include/linux/nsc_gpio.h a0-nohilo/include/linux/nsc_gpio.h
--- aa-0/include/linux/nsc_gpio.h 2006-07-06 13:20:28.000000000 -0600
+++ a0-nohilo/include/linux/nsc_gpio.h 2006-07-12 09:20:14.000000000 -0600
@@ -25,8 +25,6 @@ struct nsc_gpio_ops {
void (*gpio_dump) (struct nsc_gpio_ops *amp, unsigned iminor);
int (*gpio_get) (unsigned iminor);
void (*gpio_set) (unsigned iminor, int state);
- void (*gpio_set_high)(unsigned iminor);
- void (*gpio_set_low) (unsigned iminor);
void (*gpio_change) (unsigned iminor);
int (*gpio_current) (unsigned iminor);
struct device* dev; /* for dev_dbg() support, set in init */
reply other threads:[~2006-07-12 17:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B52F51.6040005@gmail.com \
--to=jim.cromie@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.