* [ patch -mm1 01/03 ] gpio: drop vtable members .gpio_set_high .gpio_set_low gpio_set is enough.
@ 2006-07-12 17:20 Jim Cromie
0 siblings, 0 replies; only message in thread
From: Jim Cromie @ 2006-07-12 17:20 UTC (permalink / raw)
To: Linux kernel, Andrew Morton
1 - drops gpio_set_high, gpio_set_low from the nsc_gpio_ops vtable.
While we can't drop them from scx200_gpio (or can we?), we dont need them
for new users of the exported vtable; gpio_set(1), gpio_set(0) work fine.
Signed-off-by Jim Cromie <jim.cromie@gmail.com>
---
[jimc@harpo fxd3]$ diffstat diff.nosethilo
drivers/char/pc8736x_gpio.c | 2 --
drivers/char/scx200_gpio.c | 2 --
include/linux/nsc_gpio.h | 2 --
3 files changed, 6 deletions(-)
diff -ruNp -X dontdiff -X exclude-diffs aa-0/drivers/char/pc8736x_gpio.c a0-nohilo/drivers/char/pc8736x_gpio.c
--- aa-0/drivers/char/pc8736x_gpio.c 2006-07-09 10:37:54.000000000 -0600
+++ a0-nohilo/drivers/char/pc8736x_gpio.c 2006-07-12 09:21:58.000000000 -0600
@@ -218,8 +218,6 @@ static struct nsc_gpio_ops pc8736x_acces
.gpio_dump = nsc_gpio_dump,
.gpio_get = pc8736x_gpio_get,
.gpio_set = pc8736x_gpio_set,
- .gpio_set_high = pc8736x_gpio_set_high,
- .gpio_set_low = pc8736x_gpio_set_low,
.gpio_change = pc8736x_gpio_change,
.gpio_current = pc8736x_gpio_current
};
diff -ruNp -X dontdiff -X exclude-diffs aa-0/drivers/char/scx200_gpio.c a0-nohilo/drivers/char/scx200_gpio.c
--- aa-0/drivers/char/scx200_gpio.c 2006-07-11 12:14:57.000000000 -0600
+++ a0-nohilo/drivers/char/scx200_gpio.c 2006-07-12 09:20:55.000000000 -0600
@@ -41,8 +41,6 @@ struct nsc_gpio_ops scx200_access = {
.gpio_dump = nsc_gpio_dump,
.gpio_get = scx200_gpio_get,
.gpio_set = scx200_gpio_set,
- .gpio_set_high = scx200_gpio_set_high,
- .gpio_set_low = scx200_gpio_set_low,
.gpio_change = scx200_gpio_change,
.gpio_current = scx200_gpio_current
};
diff -ruNp -X dontdiff -X exclude-diffs aa-0/include/linux/nsc_gpio.h a0-nohilo/include/linux/nsc_gpio.h
--- aa-0/include/linux/nsc_gpio.h 2006-07-06 13:20:28.000000000 -0600
+++ a0-nohilo/include/linux/nsc_gpio.h 2006-07-12 09:20:14.000000000 -0600
@@ -25,8 +25,6 @@ struct nsc_gpio_ops {
void (*gpio_dump) (struct nsc_gpio_ops *amp, unsigned iminor);
int (*gpio_get) (unsigned iminor);
void (*gpio_set) (unsigned iminor, int state);
- void (*gpio_set_high)(unsigned iminor);
- void (*gpio_set_low) (unsigned iminor);
void (*gpio_change) (unsigned iminor);
int (*gpio_current) (unsigned iminor);
struct device* dev; /* for dev_dbg() support, set in init */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-07-12 17:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-12 17:20 [ patch -mm1 01/03 ] gpio: drop vtable members .gpio_set_high .gpio_set_low gpio_set is enough Jim Cromie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.