From: "H. Peter Anvin" <hpa@zytor.com>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: akpm@osdl.org, Jeff Dike <jdike@addtoit.com>,
linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH 4/5] UML - Reenable SysRq support
Date: Wed, 12 Jul 2006 14:11:58 -0700 [thread overview]
Message-ID: <44B5659E.5070000@zytor.com> (raw)
In-Reply-To: <200607122056.01202.blaisorblade@yahoo.it>
Blaisorblade wrote:
> On Wednesday 12 July 2006 18:40, Jeff Dike wrote:
>> Sysrq works fine on UML.
>>
>> Signed-off-by: Jeff Dike <jdike@addtoit.com>
>>
>> Index: linux-2.6.17/lib/Kconfig.debug
>> ===================================================================
>> --- linux-2.6.17.orig/lib/Kconfig.debug 2006-07-12 11:26:41.000000000 -0400
>> +++ linux-2.6.17/lib/Kconfig.debug 2006-07-12 11:33:02.000000000 -0400
>> @@ -18,7 +18,6 @@ config ENABLE_MUST_CHECK
>>
>> config MAGIC_SYSRQ
>> bool "Magic SysRq key"
>> - depends on !UML
>> help
>> If you say Y here, you will have some control over the system even
>> if the system crashes for example during kernel debugging (e.g., you
> Please reject this patch, the setting for UML is just elsewhere, in
> arch/um/Kconfig (and depends on MCONSOLE).
>
> If kbuild doesn't handle well having an option declared twice now (it isn't
> very happy but it worked when I added the above dependency) we can rename the
> one in arch/um/Kconfig to MAGIC_SYSRQ_UML and make the one above like this
> (untested):
>
> config MAGIC_SYSRQ
> bool
> prompt "Magic SysRq key" if !UML
> depends on MAGIC_SYSRQ_UML || !UML
> default y if UML
>
Why not:
config MAGIC_SYSRQ
bool
prompt "Magic SysRq key"
depends on !UML || MCONSOLE
default y if UML
-hpa
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Blaisorblade <blaisorblade@yahoo.it>
Cc: user-mode-linux-devel@lists.sourceforge.net,
Jeff Dike <jdike@addtoit.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [uml-devel] [PATCH 4/5] UML - Reenable SysRq support
Date: Wed, 12 Jul 2006 14:11:58 -0700 [thread overview]
Message-ID: <44B5659E.5070000@zytor.com> (raw)
In-Reply-To: <200607122056.01202.blaisorblade@yahoo.it>
Blaisorblade wrote:
> On Wednesday 12 July 2006 18:40, Jeff Dike wrote:
>> Sysrq works fine on UML.
>>
>> Signed-off-by: Jeff Dike <jdike@addtoit.com>
>>
>> Index: linux-2.6.17/lib/Kconfig.debug
>> ===================================================================
>> --- linux-2.6.17.orig/lib/Kconfig.debug 2006-07-12 11:26:41.000000000 -0400
>> +++ linux-2.6.17/lib/Kconfig.debug 2006-07-12 11:33:02.000000000 -0400
>> @@ -18,7 +18,6 @@ config ENABLE_MUST_CHECK
>>
>> config MAGIC_SYSRQ
>> bool "Magic SysRq key"
>> - depends on !UML
>> help
>> If you say Y here, you will have some control over the system even
>> if the system crashes for example during kernel debugging (e.g., you
> Please reject this patch, the setting for UML is just elsewhere, in
> arch/um/Kconfig (and depends on MCONSOLE).
>
> If kbuild doesn't handle well having an option declared twice now (it isn't
> very happy but it worked when I added the above dependency) we can rename the
> one in arch/um/Kconfig to MAGIC_SYSRQ_UML and make the one above like this
> (untested):
>
> config MAGIC_SYSRQ
> bool
> prompt "Magic SysRq key" if !UML
> depends on MAGIC_SYSRQ_UML || !UML
> default y if UML
>
Why not:
config MAGIC_SYSRQ
bool
prompt "Magic SysRq key"
depends on !UML || MCONSOLE
default y if UML
-hpa
next prev parent reply other threads:[~2006-07-12 21:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 16:40 [uml-devel] [PATCH 4/5] UML - Reenable SysRq support Jeff Dike
2006-07-12 16:40 ` Jeff Dike
2006-07-12 18:56 ` [uml-devel] " Blaisorblade
2006-07-12 18:56 ` Blaisorblade
2006-07-12 21:09 ` Jeff Dike
2006-07-12 21:09 ` Jeff Dike
2006-07-12 21:11 ` H. Peter Anvin [this message]
2006-07-12 21:11 ` H. Peter Anvin
2006-07-13 8:21 ` Paolo Giarrusso
2006-07-13 8:21 ` Paolo Giarrusso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44B5659E.5070000@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.