* [REPOST][PATCH] scsi_queue_work() documented return value is incorrect
@ 2006-08-04 17:09 Michael Reed
0 siblings, 0 replies; only message in thread
From: Michael Reed @ 2006-08-04 17:09 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
If you examine the queue_work() routine you'll see that it returns
1 on success, 0 if the work is already queued.
This patch corrects the source code documentation for the
scsi_queue_work function.
Mike
[-- Attachment #2: scsi_queue_work.patch --]
[-- Type: text/x-patch, Size: 524 bytes --]
Fix scsi_queue_work function documentation.
Signed-off-by: Michael Reed <mdr@sgi.com>
--- rc3u/drivers/scsi/hosts.c 2006-04-27 12:32:05.000000000 -0500
+++ rc3/drivers/scsi/hosts.c 2006-05-05 09:12:53.347943283 -0500
@@ -487,7 +487,9 @@
* @work: Work to queue for execution.
*
* Return value:
- * 0 on success / != 0 for error
+ * 1 - work queued for execution
+ * 0 - work is already queued
+ * -EINVAL - work queue doesn't exist
**/
int scsi_queue_work(struct Scsi_Host *shost, struct work_struct *work)
{
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-08-04 17:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-04 17:09 [REPOST][PATCH] scsi_queue_work() documented return value is incorrect Michael Reed
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.