minor copy&paste error in vmx.c ?

minor copy&paste error in vmx.c ?

[Stefan Kaltenbrunner]

While trying to find out why OpenBSD/AMD64 still does not want to boot
on -unstable I got a rather strange (immpossible) error telling me that
CR is 0 in vmx.c:1822 which made no sense since there is a case 0 in the
switch statement.
Is it possible that there is a small c&p error and the printk() there
should actually look like:

--- a/xen/arch/x86/hvm/vmx/vmx.c        Fri Aug 04 20:34:44 2006 +0100
+++ b/xen/arch/x86/hvm/vmx/vmx.c        Sun Aug 06 11:17:04 2006 +0200
@@ -1818,7 +1818,7 @@ static int mov_to_cr(int gp, int cr, str
         break;
     }
     default:
-        printk("invalid cr: %d\n", gp);
+        printk("invalid cr: %d\n", cr);
         __hvm_bug(regs);
     }

?

with that change in place i get the following when trying to boot a
OpenBSD/AMD64 kernel:

(XEN) (GUEST: 1) Booting from CD-Rom...
(XEN) invalid cr: 8
(XEN) __hvm_bug at vmx.c:1822
(XEN) ----[ Xen-3.0-unstable    Not tainted ]----
(XEN) CPU:    0
(XEN) RIP:    0008:[<ffffffff8024b222>]
(XEN) RFLAGS: 0000000000000246   CONTEXT: hvm
(XEN) rax: 0000000000000000   rbx: ffffffff8055ada0   rcx: 0000000000000007
(XEN) rdx: 0000000000000007   rsi: 0000000000000002   rdi: ffff8000006c5f80
(XEN) rbp: ffffffff809d0ef0   rsp: ffffffff809d0ef0   r8:  0000000000000000
(XEN) r9:  ffffffff8099fbe0   r10: ffffffff8099fbe0   r11: ffffffff8099fd80
(XEN) r12: 0000000000000000   r13: 0000000000000000   r14: 0000000000000000
(XEN) r15: 0000000000000000   cr0: 000000008005003b   cr3: 000000009c439000
(XEN) ds: 0010   es: 0010   fs: 0000   gs: 0000   ss: 0010   cs: 0008
(XEN) domain_crash_sync called from vmx.c:1822
(XEN) Domain 1 (vcpu#0) crashed on cpu#0:
(XEN) ----[ Xen-3.0-unstable    Not tainted ]----
(XEN) CPU:    0
(XEN) RIP:    0008:[<ffffffff8024b222>]
(XEN) RFLAGS: 0000000000000246   CONTEXT: hvm
(XEN) rax: 0000000000000000   rbx: ffffffff8055ada0   rcx: 0000000000000007
(XEN) rdx: 0000000000000007   rsi: 0000000000000002   rdi: ffff8000006c5f80
(XEN) rbp: ffffffff809d0ef0   rsp: ffffffff809d0ef0   r8:  0000000000000000
(XEN) r9:  ffffffff8099fbe0   r10: ffffffff8099fbe0   r11: ffffffff8099fd80
(XEN) r12: 0000000000000000   r13: 0000000000000000   r14: 0000000000000000
(XEN) r15: 0000000000000000   cr0: 000000008005003b   cr3: 000000009c439000
(XEN) ds: 0010   es: 0010   fs: 0000   gs: 0000   ss: 0010   cs: 0008

any ideas ?


Stefan

Re: minor copy&paste error in vmx.c ?

[Keir Fraser]

On 6/8/06 1:33 pm, "Stefan Kaltenbrunner" <stefan@kaltenbrunner.cc> wrote:

> with that change in place i get the following when trying to boot a
> OpenBSD/AMD64 kernel:
> 
> (XEN) (GUEST: 1) Booting from CD-Rom...
> (XEN) invalid cr: 8

Perhaps cr8 isn't emulated properly. Probably not very hard to fix if that's
the case.

 -- Keir

Re: minor copy&paste error in vmx.c ?

[Stefan Kaltenbrunner]

Keir Fraser wrote:
> 
> 
> On 6/8/06 1:33 pm, "Stefan Kaltenbrunner" <stefan@kaltenbrunner.cc> wrote:
> 
>> with that change in place i get the following when trying to boot a
>> OpenBSD/AMD64 kernel:
>>
>> (XEN) (GUEST: 1) Booting from CD-Rom...
>> (XEN) invalid cr: 8
> 
> Perhaps cr8 isn't emulated properly. Probably not very hard to fix if that's
> the case.

netbsd/amd64 fails in a similiar way:

(XEN) invalid cr: 8
(XEN) __hvm_bug at vmx.c:1822
(XEN) ----[ Xen-3.0-unstable    Not tainted ]----
(XEN) CPU:    1
(XEN) RIP:    0008:[<ffffffff802c6b8d>]
(XEN) RFLAGS: 0000000000000246   CONTEXT: hvm
(XEN) rax: 0000000000000000   rbx: 0000000000000000   rcx: ffffffff80a5a420
(XEN) rdx: 0000000000000286   rsi: 0000000000000001   rdi: 0000000000000000
(XEN) rbp: 0000000000000000   rsp: ffffffff80aa4ef0   r8:  ffffffff803a2400
(XEN) r9:  0000000000000720   r10: ffffffff80aa4ed0   r11: 0000000000000008
(XEN) r12: 0000000000000000   r13: 0000000000000000   r14: 0000000000000000
(XEN) r15: 0000000000000000   cr0: 000000008005003b   cr3: 00000000b21f6000
(XEN) ds: 0010   es: 0010   fs: 0000   gs: 0000   ss: 0010   cs: 0008
(XEN) domain_crash_sync called from vmx.c:1822
(XEN) Domain 24 (vcpu#0) crashed on cpu#1:
(XEN) ----[ Xen-3.0-unstable    Not tainted ]----
(XEN) CPU:    1
(XEN) RIP:    0008:[<ffffffff802c6b8d>]
(XEN) RFLAGS: 0000000000000246   CONTEXT: hvm
(XEN) rax: 0000000000000000   rbx: 0000000000000000   rcx: ffffffff80a5a420
(XEN) rdx: 0000000000000286   rsi: 0000000000000001   rdi: 0000000000000000
(XEN) rbp: 0000000000000000   rsp: ffffffff80aa4ef0   r8:  ffffffff803a2400
(XEN) r9:  0000000000000720   r10: ffffffff80aa4ed0   r11: 0000000000000008
(XEN) r12: 0000000000000000   r13: 0000000000000000   r14: 0000000000000000
(XEN) r15: 0000000000000000   cr0: 000000008005003b   cr3: 00000000b21f6000
(XEN) ds: 0010   es: 0010   fs: 0000   gs: 0000   ss: 0010   cs: 0008

netbsd/amd64 is actually able to get much further then OpenBSD/AMD64 -
but both seem to suffer from the same bug/issue.
OpenBSD/i386 and NetBSD/386 seem to work fine as a VT guest btw.

Stefan