* [KJ] [PATCH] include/asm-frv/*.h: printk("SOMETEXT"....) ->
@ 2006-08-08 10:03 Alexander Bodnarashik
2006-08-16 14:28 ` Alexander Bodnarashik
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Bodnarashik @ 2006-08-08 10:03 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
I've tried to cleanup some code inside "include/asm-frv" folder. Hope i understand the meaning of KERN_* constants correctly.
Signed-off-by: Alexander Bodnarashik <boda2004@mail.ru>
[-- Attachment #2: asm-frv.patch --]
[-- Type: text/x-patch, Size: 1630 bytes --]
diff --git a/include/asm-frv/math-emu.h b/include/asm-frv/math-emu.h
index 0c8f731..c450309 100644
--- a/include/asm-frv/math-emu.h
+++ b/include/asm-frv/math-emu.h
@@ -117,9 +117,9 @@ extern unsigned int fp_debugprint;
static int __count = 3; \
\
if (__count > 0) { \
- printk("You just hit an unimplemented " \
+ printk(KERN_WARNING "You just hit an unimplemented " \
"fpu instruction (%s)\n", str); \
- printk("Please report this to ....\n"); \
+ printk(KERN_WARNING "Please report this to ....\n"); \
__count--; \
} \
})
diff --git a/include/asm-frv/pgtable.h b/include/asm-frv/pgtable.h
index 7af7485..ff341a3 100644
--- a/include/asm-frv/pgtable.h
+++ b/include/asm-frv/pgtable.h
@@ -156,13 +156,13 @@ extern unsigned long empty_zero_page;
extern pgd_t swapper_pg_dir[PTRS_PER_PGD];
#define pte_ERROR(e) \
- printk("%s:%d: bad pte %08lx.\n", __FILE__, __LINE__, (e).pte)
+ printk(KERN_ERR "%s:%d: bad pte %08lx.\n", __FILE__, __LINE__, (e).pte)
#define pmd_ERROR(e) \
- printk("%s:%d: bad pmd %08lx.\n", __FILE__, __LINE__, pmd_val(e))
+ printk(KERN_ERR "%s:%d: bad pmd %08lx.\n", __FILE__, __LINE__, pmd_val(e))
#define pud_ERROR(e) \
- printk("%s:%d: bad pud %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(e)))
+ printk(KERN_ERR "%s:%d: bad pud %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(e)))
#define pgd_ERROR(e) \
- printk("%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(pgd_val(e))))
+ printk(KERN_ERR "%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(pgd_val(e))))
/*
* Certain architectures need to do special things when PTEs
[-- Attachment #3: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 2+ messages in thread* [KJ] [PATCH] include/asm-frv/*.h: printk("SOMETEXT"....) ->
2006-08-08 10:03 [KJ] [PATCH] include/asm-frv/*.h: printk("SOMETEXT"....) -> Alexander Bodnarashik
@ 2006-08-16 14:28 ` Alexander Bodnarashik
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Bodnarashik @ 2006-08-16 14:28 UTC (permalink / raw)
To: kernel-janitors
I've tried to cleanup some code inside "include/asm-frv" folder. Hope i understand the meaning of KERN_* constants correctly.
Patch is resent, because previous attempt was silently ignore. I think it's because i've used attachment. Hope now it mets all requirements.
Signed-off-by: Alexander Bodnarashik <boda2004@mail.ru>
---
diff --git a/include/asm-frv/math-emu.h b/include/asm-frv/math-emu.h
index 0c8f731..c450309 100644
--- a/include/asm-frv/math-emu.h
+++ b/include/asm-frv/math-emu.h
@@ -117,9 +117,9 @@ extern unsigned int fp_debugprint;
static int __count = 3; \
\
if (__count > 0) { \
- printk("You just hit an unimplemented " \
+ printk(KERN_WARNING "You just hit an unimplemented " \
"fpu instruction (%s)\n", str); \
- printk("Please report this to ....\n"); \
+ printk(KERN_WARNING "Please report this to ....\n"); \
__count--; \
} \
})
diff --git a/include/asm-frv/pgtable.h b/include/asm-frv/pgtable.h
index 7af7485..ff341a3 100644
--- a/include/asm-frv/pgtable.h
+++ b/include/asm-frv/pgtable.h
@@ -156,13 +156,13 @@ extern unsigned long empty_zero_page;
extern pgd_t swapper_pg_dir[PTRS_PER_PGD];
#define pte_ERROR(e) \
- printk("%s:%d: bad pte %08lx.\n", __FILE__, __LINE__, (e).pte)
+ printk(KERN_ERR "%s:%d: bad pte %08lx.\n", __FILE__, __LINE__, (e).pte)
#define pmd_ERROR(e) \
- printk("%s:%d: bad pmd %08lx.\n", __FILE__, __LINE__, pmd_val(e))
+ printk(KERN_ERR "%s:%d: bad pmd %08lx.\n", __FILE__, __LINE__, pmd_val(e))
#define pud_ERROR(e) \
- printk("%s:%d: bad pud %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(e)))
+ printk(KERN_ERR "%s:%d: bad pud %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(e)))
#define pgd_ERROR(e) \
- printk("%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(pgd_val(e))))
+ printk(KERN_ERR "%s:%d: bad pgd %08lx.\n", __FILE__, __LINE__, pmd_val(pud_val(pgd_val(e))))
/*
* Certain architectures need to do special things when PTEs
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-16 14:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-08 10:03 [KJ] [PATCH] include/asm-frv/*.h: printk("SOMETEXT"....) -> Alexander Bodnarashik
2006-08-16 14:28 ` Alexander Bodnarashik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.