All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mingming Cao <cmm@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/9] extents for ext4
Date: Thu, 10 Aug 2006 09:46:38 -0700	[thread overview]
Message-ID: <44DB62EE.3050801@us.ibm.com> (raw)
In-Reply-To: <20060809233940.50162afb.akpm@osdl.org>

Andrew Morton wrote:

> On Wed, 09 Aug 2006 18:20:26 -0700
> Mingming Cao <cmm@us.ibm.com> wrote:
> 
> 
>>Add extent map support to ext4. Patch from Alex Tomas.
>>
>>On disk extents format:
>>/*
>>  * this is extent on-disk structure
>>  * it's used at the bottom of the tree
>>  */
>>struct ext3_extent {
>>        __le32  ee_block;       /* first logical block extent covers */
>>        __le16  ee_len;         /* number of blocks covered by extent */
>>        __le16  ee_start_hi;    /* high 16 bits of physical block */
>>        __le32  ee_start;       /* low 32 bigs of physical block */
>>};
>>
> 
> 
>>From a quick scan:
> 

> - There are several places which appear to be putting block numbers into
>   an `int'.
> 

This is fixed in [PATCH 4/9] 48bit support in extents, where we 
converted those "int" type block numbers to ext4_fsblk_t (which is 
typedefined as sector_t to support 48bit)

Thanks,
Mingming


WARNING: multiple messages have this Message-ID (diff)
From: Mingming Cao <cmm@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] extents for ext4
Date: Thu, 10 Aug 2006 09:46:38 -0700	[thread overview]
Message-ID: <44DB62EE.3050801@us.ibm.com> (raw)
In-Reply-To: <20060809233940.50162afb.akpm@osdl.org>

Andrew Morton wrote:

> On Wed, 09 Aug 2006 18:20:26 -0700
> Mingming Cao <cmm@us.ibm.com> wrote:
> 
> 
>>Add extent map support to ext4. Patch from Alex Tomas.
>>
>>On disk extents format:
>>/*
>>  * this is extent on-disk structure
>>  * it's used at the bottom of the tree
>>  */
>>struct ext3_extent {
>>        __le32  ee_block;       /* first logical block extent covers */
>>        __le16  ee_len;         /* number of blocks covered by extent */
>>        __le16  ee_start_hi;    /* high 16 bits of physical block */
>>        __le32  ee_start;       /* low 32 bigs of physical block */
>>};
>>
> 
> 
>>From a quick scan:
> 

> - There are several places which appear to be putting block numbers into
>   an `int'.
> 

This is fixed in [PATCH 4/9] 48bit support in extents, where we 
converted those "int" type block numbers to ext4_fsblk_t (which is 
typedefined as sector_t to support 48bit)

Thanks,
Mingming


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

  parent reply	other threads:[~2006-08-10 16:46 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-10  1:20 [PATCH 1/9] extents for ext4 Mingming Cao
2006-08-10  1:20 ` Mingming Cao
2006-08-10  6:39 ` Andrew Morton
2006-08-10  6:39   ` Andrew Morton
2006-08-10  9:29   ` [Ext2-devel] " Alex Tomas
2006-08-10  9:29     ` Alex Tomas
2006-08-10  9:48     ` [Ext2-devel] " Andrew Morton
2006-08-10  9:48       ` Andrew Morton
2006-08-10 10:08       ` [Ext2-devel] " Alex Tomas
2006-08-10 10:08         ` Alex Tomas
2006-08-10 15:55       ` [Ext2-devel] " Zach Brown
2006-08-10 15:55         ` Zach Brown
2006-08-10 17:49     ` [Ext2-devel] " Randy.Dunlap
2006-08-10 19:05       ` Alex Tomas
2006-08-10 19:05         ` Alex Tomas
2006-08-11 20:57     ` [Ext2-devel] " Randy.Dunlap
2006-08-11 20:57       ` Randy.Dunlap
2006-08-11 21:05       ` [Ext2-devel] " Alex Tomas
2006-08-11 21:05         ` Alex Tomas
2006-08-11 21:49       ` [Ext2-devel] " Mingming Cao
2006-08-11 23:00       ` Andrew Morton
2006-08-11 23:00         ` Andrew Morton
2006-08-12  6:02         ` [Ext2-devel] " Randy.Dunlap
2006-08-12 17:43           ` Darrick J. Wong
2006-08-12 18:20             ` Randy.Dunlap
2006-08-12 18:20               ` Randy.Dunlap
2006-08-14 16:26               ` [Ext2-devel] " Mingming Cao
2006-08-14 17:22                 ` Randy.Dunlap
2006-08-14 17:22                   ` Randy.Dunlap
2006-08-14 17:52                   ` [Ext2-devel] " Jeff Garzik
2006-08-14 18:05                     ` Randy.Dunlap
2006-08-14 18:13                       ` Jeff Garzik
2006-08-14 18:13                         ` Jeff Garzik
2006-08-15 15:40       ` [Ext2-devel] " Pavel Machek
2006-08-18 13:08         ` Andreas Dilger
2006-08-10 16:46   ` Mingming Cao [this message]
2006-08-10 16:46     ` Mingming Cao
2006-08-10 17:17   ` [Ext2-devel] " Theodore Tso
2006-08-10 17:17     ` Theodore Tso
2006-08-10 18:00     ` [Ext2-devel] " Andrew Morton
2006-08-10 18:00       ` Andrew Morton
2006-08-11 22:13       ` [Ext2-devel] " Mingming Cao
2006-08-11 22:13         ` Mingming Cao
2006-08-11 23:16         ` [Ext2-devel] " Andrew Morton
2006-08-11 23:16           ` Andrew Morton
2006-08-12  0:05           ` [PATCH 1/2] ext3 and jbd cleanup: remove whitespace Mingming Cao
2006-08-12  0:05           ` [PATCH 2/2] ext3 and jbd cleanup: replace brelse() to put_bh Mingming Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44DB62EE.3050801@us.ibm.com \
    --to=cmm@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.