RE: [PATCH] HVM SMBIOS v3 [5/5]

RE: [PATCH] HVM SMBIOS v3 [5/5]

[Yang, Xiaowei]

>This patch breaks VMX boot from CDROM, I'm not familiar with the BIOS
code, can
>someone help to fix it?
>BTW, it's changeset 11095.
>-Xin

The previous patch has a careless mistake:

diff -r 04e5e80be909 tools/firmware/rombios/rombios.c
--- a/tools/firmware/rombios/rombios.c	Mon Aug 14 17:38:28 2006
+++ b/tools/firmware/rombios/rombios.c	Fri Aug 18 13:13:24 2006
@@ -9459,7 +9459,7 @@
   mov cx, #0x001f ; 0x1f bytes to copy
   mov ax, #0xf000
   mov es, ax      ; destination segment is 0xf0000
-  mov di, smbios_entry_point ; destination offset
+  mov di, #smbios_entry_point ; destination offset
   mov ax, #0x9f00
   mov ds, ax      ; source segment is 0x9f000
   mov si, #0x0000 ; source offset is

Thanks,
Xiaowei

Re: RE: [PATCH] HVM SMBIOS v3 [5/5]

[Keir Fraser]

On 18/8/06 7:16 am, "Yang, Xiaowei" <xiaowei.yang@intel.com> wrote:

>> This patch breaks VMX boot from CDROM, I'm not familiar with the BIOS
> code, can
>> someone help to fix it?
>> BTW, it's changeset 11095.
>> -Xin
> 
> The previous patch has a careless mistake:

Good to know the patches were tested! ;-)

Thanks,

 -- Keir

Re: RE: [PATCH] HVM SMBIOS v3 [5/5]

[Andrew D. Ball]

Yes, thank you so much for finding this.

Peace.
Andrew


Keir Fraser wrote:
> 
> 
> On 18/8/06 7:16 am, "Yang, Xiaowei" <xiaowei.yang@intel.com> wrote:
> 
> 
>>>This patch breaks VMX boot from CDROM, I'm not familiar with the BIOS
>>
>>code, can
>>
>>>someone help to fix it?
>>>BTW, it's changeset 11095.
>>>-Xin
>>
>>The previous patch has a careless mistake:
> 
> 
> Good to know the patches were tested! ;-)
> 
> Thanks,
> 
>  -- Keir
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>