From: jim.cromie@gmail.com (jim.cromie at gmail.com)
To: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, Frodo Looijaard <frodol@dds.nl>,
Philip Edelbrock <phil@netroedge.com>,
Mark Studebaker <mdsxyz123@yahoo.com>,
lm-sensors@lm-sensors.org, LKML <linux-kernel@vger.kernel.org>
Subject: [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error
Date: Sun, 20 Aug 2006 21:49:43 +0000 [thread overview]
Message-ID: <44E8D8F7.5090000@yahoo.com> (raw)
In-Reply-To: <44E8C9AE.3060307@gmail.com>
Michal Piotrowski wrote:
> Hi,
>
> This patch fixes 56 sparse "ignoring return value of 'device_create_file'" warnings. It also adds error handling.
>
> w83627hf.c | 96 ++++++++++++++++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 80 insertions(+), 16 deletions(-)
>
> Regards,
> Michal
>
>
Ouch.
Ideally, you should have checked here (LM-Sensors ML) 1st.
The driver you chose has already been reworked along those lines,
and accepted by Jean Delvare, and thus slated for .19
an early copy (8/02)
http://lists.lm-sensors.org/pipermail/lm-sensors/2006-August/017043.html
If youre so inclined, there are ~38 others in need
of similar attention ;)
<cp-pasted from ML thread>
Here is asb100.c... I'll add lm75, lm78, smsc47b397, and w83627hf
to this patch as I have time. (Jean: don't apply yet.)
pc87360 (one of the larger offenders) is also now fixed.
Im sure if you ask nicely, Jean will provide you with
a current/authoritative list ;-)
http://khali.linux-fr.org/devel/i2c/linux-2.6/?M=A
has a fairly current collection and series-file (8/14/06)
Unfortunately, the series doesnt enumerate the patches
as a set, and several accepted patches arent there yet.
Jean, is this still the best/good place to keep current ?
WARNING: multiple messages have this Message-ID (diff)
From: jim.cromie@gmail.com
To: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, Frodo Looijaard <frodol@dds.nl>,
Philip Edelbrock <phil@netroedge.com>,
Mark Studebaker <mdsxyz123@yahoo.com>,
lm-sensors@lm-sensors.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error handling
Date: Sun, 20 Aug 2006 15:49:43 -0600 [thread overview]
Message-ID: <44E8D8F7.5090000@yahoo.com> (raw)
In-Reply-To: <44E8C9AE.3060307@gmail.com>
Michal Piotrowski wrote:
> Hi,
>
> This patch fixes 56 sparse "ignoring return value of 'device_create_file'" warnings. It also adds error handling.
>
> w83627hf.c | 96 ++++++++++++++++++++++++++++++++++++++++++++++++++-----------
> 1 file changed, 80 insertions(+), 16 deletions(-)
>
> Regards,
> Michal
>
>
Ouch.
Ideally, you should have checked here (LM-Sensors ML) 1st.
The driver you chose has already been reworked along those lines,
and accepted by Jean Delvare, and thus slated for .19
an early copy (8/02)
http://lists.lm-sensors.org/pipermail/lm-sensors/2006-August/017043.html
If youre so inclined, there are ~38 others in need
of similar attention ;)
<cp-pasted from ML thread>
Here is asb100.c... I'll add lm75, lm78, smsc47b397, and w83627hf
to this patch as I have time. (Jean: don't apply yet.)
pc87360 (one of the larger offenders) is also now fixed.
Im sure if you ask nicely, Jean will provide you with
a current/authoritative list ;-)
http://khali.linux-fr.org/devel/i2c/linux-2.6/?M=A
has a fairly current collection and series-file (8/14/06)
Unfortunately, the series doesnt enumerate the patches
as a set, and several accepted patches arent there yet.
Jean, is this still the best/good place to keep current ?
next prev parent reply other threads:[~2006-08-20 21:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-20 20:44 [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error handling Michal Piotrowski
2006-08-20 20:44 ` Michal Piotrowski
2006-08-20 21:49 ` jim.cromie at gmail.com [this message]
2006-08-20 21:49 ` [lm-sensors] " jim.cromie
2006-08-20 22:12 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error Michal Piotrowski
2006-08-20 22:12 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error handling Michal Piotrowski
2006-08-20 22:28 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error Alan Cox
2006-08-20 22:28 ` [RFC][PATCH] hwmon:fix sparse warnings + error handling Alan Cox
2006-08-21 2:30 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error Mark M. Hoffman
2006-08-21 2:30 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error handling Mark M. Hoffman
2006-08-21 9:11 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error Jean Delvare
2006-08-21 9:11 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error handling Jean Delvare
2006-08-21 16:46 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error Grant Coady
2006-08-21 16:46 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error handling Grant Coady
2006-08-21 8:04 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error Jean Delvare
2006-08-21 8:04 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error handling Jean Delvare
2006-08-22 0:43 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error Dmitry Torokhov
2006-08-22 0:43 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error handling Dmitry Torokhov
2006-08-22 11:34 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error Mark M. Hoffman
2006-08-22 11:34 ` [lm-sensors] [RFC][PATCH] hwmon:fix sparse warnings + error handling Mark M. Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44E8D8F7.5090000@yahoo.com \
--to=jim.cromie@gmail.com \
--cc=akpm@osdl.org \
--cc=frodol@dds.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mdsxyz123@yahoo.com \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=phil@netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.