From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Edward Falk <efalk@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix x86_64 _spin_lock_irqsave()
Date: Thu, 24 Aug 2006 13:10:09 +1000 [thread overview]
Message-ID: <44ED1891.6090708@yahoo.com.au> (raw)
In-Reply-To: <44ED157D.6050607@google.com>
Edward Falk wrote:
> Add spin_lock_string_flags and _raw_spin_lock_flags() to
> asm-x86_64/spinlock.h so that _spin_lock_irqsave() has the same
> semantics on x86_64 as it does on i386 and does *not* have interrupts
> disabled while it is waiting for the lock.
>
> This fix is courtesy of Michael Davidson
So, what's the bug? You shouldn't rely on these semantics anyway
because you should never expect to wait for a spinlock for so long
(and it may be the case that irqs can't be enabled anyway).
BTW. you should be cc'ing Andi Kleen (x86+/-64 maintainer) on
this type of stuff.
No comments on the merits of adding this feature. I suppose parity
with i386 is a good thing, though.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-08-24 3:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 2:57 [PATCH] Fix x86_64 _spin_lock_irqsave() Edward Falk
2006-08-24 3:10 ` Nick Piggin [this message]
2006-08-24 4:48 ` Andrew Morton
2006-08-24 15:53 ` Martin Bligh
2006-08-26 7:52 ` Keith Owens
2006-08-24 6:45 ` Andi Kleen
2006-08-24 11:04 ` Suleiman Souhlal
2006-08-24 11:13 ` Arjan van de Ven
2006-08-24 11:32 ` Andi Kleen
2006-08-24 12:33 ` Suleiman Souhlal
2006-08-24 13:21 ` Arjan van de Ven
2006-08-24 13:44 ` Suleiman Souhlal
2006-08-25 4:38 ` Andrew Morton
2006-08-25 5:33 ` Nick Piggin
2006-08-25 6:21 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44ED1891.6090708@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=efalk@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.