[PATCH] xentrace event mask for memory management class

[PATCH] xentrace event mask for memory management class

[INAKOSHI Hiroya]

[-- Attachment #1: Type: text/plain, Size: 712 bytes --]

Since TRC_MEM is defined as 0x000af000 in xen/include/public/trace.h,
TRC_MEM = TRC_SCHED | TRC_VMX.  I feel strange about this.  I do not
think scheduling is a part of memory management.  Am I right?

If not, please tell me the background TRC_MEM is defined as TRC_SCHED
| TRC_VMX.  If so, please apply this patch.

This patch defines TRC_MEM as an independent event mask.  In addition,
xentrace accepts '-e mem' option so that it puts memory management
events in trace buffers.  The manual page (xentrace.8) is also
modified accordingly.

Tested by compiling on x86 and ia64, booting Dom0 and DomU, taking a
xentrace log with '-e mem' option.

Signed-off-by: Hiroya INAKOSHI <inakoshi.hiroya@jp.fujitsu.com>



[-- Attachment #2: memory-evtmask.patch --]
[-- Type: text/plain, Size: 2742 bytes --]

# HG changeset patch
# User inakoshi@localhost.localdomain
# Node ID 408bc956d5cb00816bc1c903e53f74d590d96cec
# Parent  ec03b24a2d83273ec62db8596506b80577a0e41e
This patch defines TRC_MEM as an independent event mask.  In addition,
xentrace accepts '-e mem' option so that it puts memory management
events in trace buffers.  The manual page (xentrace.8) is also
modified accordingly.

Tested by compiling on x86 and ia64, booting Dom0 and DomU, taking a
xentrace log with '-e mem' option.


Signed-off-by: Hiroya INAKOSHI <inakoshi.hiroya@jp.fujitsu.com>

diff -r ec03b24a2d83 -r 408bc956d5cb tools/xentrace/xentrace.8
--- a/tools/xentrace/xentrace.8	Tue Aug 15 19:53:55 2006 +0100
+++ b/tools/xentrace/xentrace.8	Fri Aug 18 13:32:40 2006 +0900
@@ -61,7 +61,7 @@ gathered by xentrace:
         0x0002f000          TRC_SCHED
         0x0004f000          TRC_DOM0OP          
         0x0008f000          TRC_VMX
-        0x000af000          TRC_MEM
+        0x0010f000          TRC_MEM
         0xfffff000          TRC_ALL 
 
 
@@ -99,9 +99,9 @@ collects the following events from the t
         0x0002f014         TRC_SCHED_SWITCH_INFPREV
         0x0002f015         TRC_SCHED_SWITCH_INFNEXT
 
-        0x000af001         TRC_MEM_PAGE_GRANT_MAP
-        0x000af002         TRC_MEM_PAGE_GRANT_UNMAP
-        0x000af003         TRC_MEM_PAGE_GRANT_TRANSFER
+        0x0010f001         TRC_MEM_PAGE_GRANT_MAP
+        0x0010f002         TRC_MEM_PAGE_GRANT_UNMAP
+        0x0010f003         TRC_MEM_PAGE_GRANT_TRANSFER
 
         0x00081001         TRC_VMX_VMEXIT
         0x00081002         TRC_VMX_VMENTRY
diff -r ec03b24a2d83 -r 408bc956d5cb tools/xentrace/xentrace.c
--- a/tools/xentrace/xentrace.c	Tue Aug 15 19:53:55 2006 +0100
+++ b/tools/xentrace/xentrace.c	Fri Aug 18 13:32:40 2006 +0900
@@ -348,6 +348,8 @@ int parse_evtmask(char *arg, struct argp
         setup->evt_mask |= TRC_DOM0OP;
     } else if(strcmp(arg, "vmx") == 0){ 
         setup->evt_mask |= TRC_VMX;
+    } else if(strcmp(arg, "mem") == 0){ 
+        setup->evt_mask |= TRC_MEM;
     } else if(strcmp(arg, "all") == 0){ 
         setup->evt_mask |= TRC_ALL;
     } else {
diff -r ec03b24a2d83 -r 408bc956d5cb xen/include/public/trace.h
--- a/xen/include/public/trace.h	Tue Aug 15 19:53:55 2006 +0100
+++ b/xen/include/public/trace.h	Fri Aug 18 13:32:40 2006 +0900
@@ -14,7 +14,7 @@
 #define TRC_SCHED   0x0002f000    /* Xen Scheduler trace      */
 #define TRC_DOM0OP  0x0004f000    /* Xen DOM0 operation trace */
 #define TRC_VMX     0x0008f000    /* Xen VMX trace            */
-#define TRC_MEM     0x000af000    /* Xen memory trace         */
+#define TRC_MEM     0x0010f000    /* Xen memory trace         */
 #define TRC_ALL     0xfffff000
 
 /* Trace subclasses */

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] xentrace event mask for memory management class

[Mark Williamson]

> Since TRC_MEM is defined as 0x000af000 in xen/include/public/trace.h,
> TRC_MEM = TRC_SCHED | TRC_VMX.  I feel strange about this.  I do not
> think scheduling is a part of memory management.  Am I right?

Looks to me like it's probably a typo that hasn't been spotted before - well 
done.

> This patch defines TRC_MEM as an independent event mask.  In addition,
> xentrace accepts '-e mem' option so that it puts memory management
> events in trace buffers.  The manual page (xentrace.8) is also
> modified accordingly.
>
> Tested by compiling on x86 and ia64, booting Dom0 and DomU, taking a
> xentrace log with '-e mem' option.

Thanks for the thorough testing and for updating the man page!

The patch looks fine to me.

+1

Cheers,
Mark

-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

Re: [PATCH] xentrace event mask for memory management class

[INAKOSHI Hiroya]

Hi,

The patch for xentrace I posted has not been applied yet.  This patch is
just for correcting a typo, as Mark said, and is harmless.  Please
apply.  Thanks.

Hiroya.


INAKOSHI Hiroya wrote:
> Since TRC_MEM is defined as 0x000af000 in xen/include/public/trace.h,
> TRC_MEM = TRC_SCHED | TRC_VMX.  I feel strange about this.  I do not
> think scheduling is a part of memory management.  Am I right?
> 
> If not, please tell me the background TRC_MEM is defined as TRC_SCHED
> | TRC_VMX.  If so, please apply this patch.
> 
> This patch defines TRC_MEM as an independent event mask.  In addition,
> xentrace accepts '-e mem' option so that it puts memory management
> events in trace buffers.  The manual page (xentrace.8) is also
> modified accordingly.
> 
> Tested by compiling on x86 and ia64, booting Dom0 and DomU, taking a
> xentrace log with '-e mem' option.
> 
> Signed-off-by: Hiroya INAKOSHI <inakoshi.hiroya@jp.fujitsu.com>
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

-- 
富士通株式会社　プラットフォーム技術開発本部　仮想システム開発統括部
稲越宏弥 <inakoshi.hiroya@jp.fujitsu.com>