All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] disable debug output for pp_tpc
@ 2006-09-01  7:01 Hannes Reinecke
  0 siblings, 0 replies; only message in thread
From: Hannes Reinecke @ 2006-09-01  7:01 UTC (permalink / raw)
  To: christophe varoqui; +Cc: device-mapper development

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

Hi Christophe,

this patch removes the debug output for pp_tpc and also decreases the 
priority ratings so that the passive path will have a priority of 0.

Please apply,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

[-- Attachment #2: multipath-tools-pp_tpc-disable-debug-output.patch --]
[-- Type: text/x-patch, Size: 1119 bytes --]

diff --git a/path_priority/pp_tpc/pp_tpc.c b/path_priority/pp_tpc/pp_tpc.c
index 76e7c47..a7ed7ad 100644
--- a/path_priority/pp_tpc/pp_tpc.c
+++ b/path_priority/pp_tpc/pp_tpc.c
@@ -62,18 +62,13 @@ int sgi_tpc_prio(const char *dev)
 		goto out;
 	}
 	
-	if ( /* Auto-volume Transfer Enabled */
-	    	(sense_buffer[8] & 0x80) != 0x80 ) {
-		fprintf(stderr, "Auto-volume Transfer not enabled");
-	}
-
 	if ( /* Current Volume Path Bit */
 		( sense_buffer[8] & 0x01) == 0x01 ) {
 		/* 
 		 * This volume was owned by the controller receiving
 		 * the inquiry command.
 		 */
-		ret |= 0x02;
+		ret |= 0x01;
 	}
 
 	/* Volume Preferred Path Priority */
@@ -83,7 +78,7 @@ int sgi_tpc_prio(const char *dev)
 		 * Access to this volume is most preferred through
 		 * this path and other paths with this value.
 		 */
-		ret |= 0x04;
+		ret |= 0x02;
 		break;
 	case 0x02:
 		/*
@@ -91,8 +86,7 @@ int sgi_tpc_prio(const char *dev)
 		 * as a secondary path. Typically this path would be used
 		 * for fail-over situations.
 		 */
-		ret |= 0x01;
-		break;
+		/* Fallthrough */
 	default:
 		/* Reserved values */
 		break;

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2006-09-01  7:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-01  7:01 [PATCH] disable debug output for pp_tpc Hannes Reinecke

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.