All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <michael@walle.cc>, <linux-mtd@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Cc: richard@nod.at, boris.brezillon@collabora.com, vigneshr@ti.com,
	stable@vger.kernel.org, miquel.raynal@bootlin.com
Subject: Re: [PATCH v7 1/7] mtd: spi-nor: sst: fix BPn bits for the SST25VF064C
Date: Thu, 3 Dec 2020 14:34:17 +0000	[thread overview]
Message-ID: <44be8e3c-86ca-501e-e575-55f17747bda6@microchip.com> (raw)
In-Reply-To: <20201202230040.14009-2-michael@walle.cc>

On 12/3/20 1:00 AM, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> This flash part actually has 4 block protection bits.
> 
> Reported-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: stable@vger.kernel.org # v5.7+

While the patch is correct according to the datasheet, it was
not tested, so it's not a candidate for stable. I would update
the commit message to indicate that the the patch was made
solely on datasheet info and not tested, I would add the fixes
tag, and strip cc-ing to stable.

> Signed-off-by: Michael Walle <michael@walle.cc>

With the above addressed:

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

> ---
> I didn't add the Fixes: tag because we depend on the 4bit BP support which
> was introduced in 5.7.
> 
> changes since v6:
>  - new patch
> 
>  drivers/mtd/spi-nor/sst.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
> index e0af6d25d573..0ab07624fb73 100644
> --- a/drivers/mtd/spi-nor/sst.c
> +++ b/drivers/mtd/spi-nor/sst.c
> @@ -18,7 +18,8 @@ static const struct flash_info sst_parts[] = {
>                               SECT_4K | SST_WRITE) },
>         { "sst25vf032b", INFO(0xbf254a, 0, 64 * 1024, 64,
>                               SECT_4K | SST_WRITE) },
> -       { "sst25vf064c", INFO(0xbf254b, 0, 64 * 1024, 128, SECT_4K) },
> +       { "sst25vf064c", INFO(0xbf254b, 0, 64 * 1024, 128,
> +                             SECT_4K | SPI_NOR_4BIT_BP) },
>         { "sst25wf512",  INFO(0xbf2501, 0, 64 * 1024,  1,
>                               SECT_4K | SST_WRITE) },
>         { "sst25wf010",  INFO(0xbf2502, 0, 64 * 1024,  2,
> --
> 2.20.1
> 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: <Tudor.Ambarus@microchip.com>
To: <michael@walle.cc>, <linux-mtd@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Cc: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
	<boris.brezillon@collabora.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH v7 1/7] mtd: spi-nor: sst: fix BPn bits for the SST25VF064C
Date: Thu, 3 Dec 2020 14:34:17 +0000	[thread overview]
Message-ID: <44be8e3c-86ca-501e-e575-55f17747bda6@microchip.com> (raw)
In-Reply-To: <20201202230040.14009-2-michael@walle.cc>

On 12/3/20 1:00 AM, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> This flash part actually has 4 block protection bits.
> 
> Reported-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: stable@vger.kernel.org # v5.7+

While the patch is correct according to the datasheet, it was
not tested, so it's not a candidate for stable. I would update
the commit message to indicate that the the patch was made
solely on datasheet info and not tested, I would add the fixes
tag, and strip cc-ing to stable.

> Signed-off-by: Michael Walle <michael@walle.cc>

With the above addressed:

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>

> ---
> I didn't add the Fixes: tag because we depend on the 4bit BP support which
> was introduced in 5.7.
> 
> changes since v6:
>  - new patch
> 
>  drivers/mtd/spi-nor/sst.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/sst.c b/drivers/mtd/spi-nor/sst.c
> index e0af6d25d573..0ab07624fb73 100644
> --- a/drivers/mtd/spi-nor/sst.c
> +++ b/drivers/mtd/spi-nor/sst.c
> @@ -18,7 +18,8 @@ static const struct flash_info sst_parts[] = {
>                               SECT_4K | SST_WRITE) },
>         { "sst25vf032b", INFO(0xbf254a, 0, 64 * 1024, 64,
>                               SECT_4K | SST_WRITE) },
> -       { "sst25vf064c", INFO(0xbf254b, 0, 64 * 1024, 128, SECT_4K) },
> +       { "sst25vf064c", INFO(0xbf254b, 0, 64 * 1024, 128,
> +                             SECT_4K | SPI_NOR_4BIT_BP) },
>         { "sst25wf512",  INFO(0xbf2501, 0, 64 * 1024,  1,
>                               SECT_4K | SST_WRITE) },
>         { "sst25wf010",  INFO(0xbf2502, 0, 64 * 1024,  2,
> --
> 2.20.1
> 


  reply	other threads:[~2020-12-03 14:51 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 23:00 [PATCH v7 0/7] mtd: spi-nor: keep lock bits if they are non-volatile Michael Walle
2020-12-02 23:00 ` Michael Walle
2020-12-02 23:00 ` [PATCH v7 1/7] mtd: spi-nor: sst: fix BPn bits for the SST25VF064C Michael Walle
2020-12-02 23:00   ` Michael Walle
2020-12-03 14:34   ` Tudor.Ambarus [this message]
2020-12-03 14:34     ` Tudor.Ambarus
2020-12-03 14:39     ` Michael Walle
2020-12-03 14:39       ` Michael Walle
2020-12-03 15:08       ` Tudor.Ambarus
2020-12-03 15:08         ` Tudor.Ambarus
2020-12-03 18:24         ` Greg KH
2020-12-03 18:24           ` Greg KH
2020-12-03 14:40   ` Tudor.Ambarus
2020-12-03 14:40     ` Tudor.Ambarus
2020-12-03 14:41     ` Michael Walle
2020-12-03 14:41       ` Michael Walle
2020-12-02 23:00 ` [PATCH v7 2/7] mtd: spi-nor: ignore errors in spi_nor_unlock_all() Michael Walle
2020-12-02 23:00   ` Michael Walle
2020-12-03 14:36   ` Tudor.Ambarus
2020-12-03 14:36     ` Tudor.Ambarus
2020-12-02 23:00 ` [PATCH v7 3/7] mtd: spi-nor: atmel: remove global protection flag Michael Walle
2020-12-02 23:00   ` Michael Walle
2020-12-02 23:00 ` [PATCH v7 4/7] mtd: spi-nor: sst: " Michael Walle
2020-12-02 23:00   ` Michael Walle
2020-12-02 23:00 ` [PATCH v7 5/7] mtd: spi-nor: intel: " Michael Walle
2020-12-02 23:00   ` Michael Walle
2020-12-02 23:00 ` [PATCH v7 6/7] mtd: spi-nor: atmel: fix unlock_all() for AT25FS010/040 Michael Walle
2020-12-02 23:00   ` Michael Walle
2020-12-03 14:44   ` Tudor.Ambarus
2020-12-03 14:44     ` Tudor.Ambarus
2020-12-02 23:00 ` [PATCH v7 7/7] mtd: spi-nor: keep lock bits if they are non-volatile Michael Walle
2020-12-02 23:00   ` Michael Walle
2020-12-03 14:51   ` Tudor.Ambarus
2020-12-03 14:51     ` Tudor.Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44be8e3c-86ca-501e-e575-55f17747bda6@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=boris.brezillon@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=stable@vger.kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.