* [PATCH][CONNTRACK-TOOL] getopts_long returns integer
@ 2006-09-07 13:18 Pablo Neira Ayuso
0 siblings, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2006-09-07 13:18 UTC (permalink / raw)
To: Netfilter Development Mailinglist; +Cc: Patrick McHardy
[-- Attachment #1: Type: text/plain, Size: 79 bytes --]
This patch was sent some time ago but it seems that it got lost. Please
apply.
[-- Attachment #2: type.patch --]
[-- Type: text/plain, Size: 481 bytes --]
[PATCH][CONNTRACK-TOOL] getopts_long returns integer
getopt_long returns an integer, not a char
Index: src/conntrack.c
===================================================================
--- src/conntrack.c (revisión: 6458)
+++ src/conntrack.c (copia de trabajo)
@@ -602,7 +602,7 @@
int main(int argc, char *argv[])
{
- char c;
+ int c;
unsigned int command = 0, options = 0;
unsigned int type = 0, event_mask = 0;
unsigned int l3flags = 0, l4flags = 0, metaflags = 0;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH][CONNTRACK-TOOL] getopts_long returns integer
@ 2006-09-07 13:33 Pablo Neira Ayuso
2006-09-07 15:06 ` Patrick McHardy
0 siblings, 1 reply; 3+ messages in thread
From: Pablo Neira Ayuso @ 2006-09-07 13:33 UTC (permalink / raw)
To: Netfilter Development Mailinglist; +Cc: Patrick McHardy
[-- Attachment #1: Type: text/plain, Size: 76 bytes --]
This patch was posted by a ARM guy, it seems that it got lost. Please apply
[-- Attachment #2: type.patch --]
[-- Type: text/plain, Size: 481 bytes --]
[PATCH][CONNTRACK-TOOL] getopts_long returns integer
getopt_long returns an integer, not a char
Index: src/conntrack.c
===================================================================
--- src/conntrack.c (revisión: 6458)
+++ src/conntrack.c (copia de trabajo)
@@ -602,7 +602,7 @@
int main(int argc, char *argv[])
{
- char c;
+ int c;
unsigned int command = 0, options = 0;
unsigned int type = 0, event_mask = 0;
unsigned int l3flags = 0, l4flags = 0, metaflags = 0;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][CONNTRACK-TOOL] getopts_long returns integer
2006-09-07 13:33 [PATCH][CONNTRACK-TOOL] getopts_long returns integer Pablo Neira Ayuso
@ 2006-09-07 15:06 ` Patrick McHardy
0 siblings, 0 replies; 3+ messages in thread
From: Patrick McHardy @ 2006-09-07 15:06 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Netfilter Development Mailinglist
Pablo Neira Ayuso wrote:
> This patch was posted by a ARM guy, it seems that it got lost. Please apply
No, its already in SVN:
[PATCH] conntrack: Fix option parsing for ARM (Philip Craig
<philipc@snapgear.com>)
The result of getopt_long() was assigned to a char, which defaults to
unsigned
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-07 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-07 13:33 [PATCH][CONNTRACK-TOOL] getopts_long returns integer Pablo Neira Ayuso
2006-09-07 15:06 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2006-09-07 13:18 Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.