* [PATCH] request_firmware_examples
@ 2006-09-07 23:25 Victor Hugo
2006-09-07 23:31 ` Andrew Morton
2006-09-09 15:19 ` Alan Cox
0 siblings, 2 replies; 9+ messages in thread
From: Victor Hugo @ 2006-09-07 23:25 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, jonathan, greg, marcel
My e-mail client should die a horrible death--
Sorry Andrew, lets try this again
Signed-off-by : Victor Hugo <victor@vhugo.net>
---
diff -Nur
linux-2.6.17.11/Documentation/firmware_class/firmware_example.c
linux/Documentation/firmware_class/firmware_example.c
--- linux-2.6.17.11/Documentation/firmware_class/firmware_example.c
1969-12-31 16:00:00.000000000 -0800
+++ linux/Documentation/firmware_class/firmware_example.c
2006-09-06 00:57:45.000000000 -0700
@@ -0,0 +1,68 @@
+/*
+ * firmware_example.c -
+ *
+ * Copyright (c) 2006 Victor Hugo <victor@vhugo.net>
+ * Based on firmware_sample_driver.c by Manuel Estrada Sainz
+ * Sample code on how to use request_firmware() from drivers.
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/device.h>
+#include <linux/string.h>
+#include <linux/firmware.h>
+
+static void sample_firmware_load(char *firmware, int size)
+{
+ u8 *buf = kmalloc(size + 1, GFP_KERNEL);
+ memcpy(buf, firmware, size);
+ buf[size] = '\0';
+ printk(KERN_INFO "firmware_example: Firmware: %s\n", buf);
+ kfree(buf);
+}
+
+static void sample_probe(struct device *dev)
+{
+ /* uses the default method to get the firmware */
+ const struct firmware *fw_entry;
+ printk(KERN_INFO "firmware_example: ghost device inserted\n");
+
+ if (request_firmware(&fw_entry, "sample_firware.bin", dev) != 0) {
+ printk(KERN_ERR "firmware_example: Firmware not
available\n");
+ return;
+ }
+
+ sample_firmware_load(fw_entry->data, fw_entry->size);
+
+ release_firmware(fw_entry);
+
+ /* finish setting up the device */
+}
+
+static void ghost_release(struct device *dev)
+{
+ printk(KERN_DEBUG "firmware_example : ghost device released\n");
+}
+
+static struct device ghost_device = {
+ .bus_id = "ghost0",
+ .release = ghost_release
+};
+
+static int __init sample_init(void)
+{
+ device_register(&ghost_device);
+ sample_probe(&ghost_device);
+ return 0;
+}
+static void __exit sample_exit(void)
+{
+ device_unregister(&ghost_device);
+}
+
+module_init(sample_init);
+module_exit(sample_exit);
+
+MODULE_LICENSE("GPL");
diff -Nur
linux-2.6.17.11/Documentation/firmware_class/firmware_nowait_example.c
linux/Documentation/firmware_class/firmware_nowait_example.c
---
linux-2.6.17.11/Documentation/firmware_class/firmware_nowait_example.c
1969-12-31 16:00:00.000000000 -0800
+++ linux/Documentation/firmware_class/firmware_nowait_example.c
2006-09-06 00:58:06.000000000 -0700
@@ -0,0 +1,83 @@
+/*
+ * firmware_nowait_example.c -
+ *
+ * Copyright (c) 2006 Victor Hugo <victor@vhugo.net>
+ * Based on firmware_sample_driver.c by Manuel Estrada Sainz
+ * Sample code on how to use request_firmware() from drivers.
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/device.h>
+#include <linux/string.h>
+#include <linux/firmware.h>
+
+static void sample_firmware_load(char *firmware, int size)
+{
+ u8 *buf = kmalloc(size + 1, GFP_KERNEL);
+ memcpy(buf, firmware, size);
+ buf[size] = '\0';
+ printk(KERN_INFO "firmware_example: Firmware: %s\n", buf);
+ kfree(buf);
+}
+
+static void sample_probe_async_cont(const struct firmware *fw, void
*context)
+{
+ if (!fw) {
+ printk(KERN_ERR
+ "firmware_nowait_example: Firmware not available\n");
+ return;
+ }
+
+ printk(KERN_INFO "firmware_nowait_example: Device Pointer \"%s\"\n",
+ (char *)context);
+ sample_firmware_load(fw->data, fw->size);
+
+}
+
+static void sample_probe_async(struct device *dev)
+{
+ /* Let's say I can't sleep */
+ int error;
+
+ printk(KERN_INFO "firmware_example: ghost device inserted\n");
+
+ error = request_firmware_nowait(THIS_MODULE, FW_ACTION_NOHOTPLUG,
+ "sample_firmware.bin", dev,
+ "my device pointer",
+ sample_probe_async_cont);
+
+ if (error) {
+ printk(KERN_ERR
+ "firmware_nowait_example: request_firmware_nowait
Failed\n");
+ }
+
+}
+
+static void ghost_release(struct device *dev)
+{
+ printk(KERN_DEBUG "firmware_nowait_example: ghost device
released\n");
+}
+
+static struct device ghost_device = {
+ .bus_id = "ghost0",
+ .release = ghost_release
+};
+
+static int __init sample_init(void)
+{
+ device_register(&ghost_device);
+ sample_probe_async(&ghost_device);
+ return 0;
+}
+static void __exit sample_exit(void)
+{
+ device_unregister(&ghost_device);
+}
+
+module_init(sample_init);
+module_exit(sample_exit);
+
+MODULE_LICENSE("GPL");
diff -Nur
linux-2.6.17.11/Documentation/firmware_class/firmware_sample_driver.c
linux/Documentation/firmware_class/firmware_sample_driver.c
---
linux-2.6.17.11/Documentation/firmware_class/firmware_sample_driver.c
2006-08-23 14:16:33.000000000 -0700
+++ linux/Documentation/firmware_class/firmware_sample_driver.c
1969-12-31 16:00:00.000000000 -0800
@@ -1,115 +0,0 @@
-/*
- * firmware_sample_driver.c -
- *
- * Copyright (c) 2003 Manuel Estrada Sainz <ranty@debian.org>
- *
- * Sample code on how to use request_firmware() from drivers.
- *
- */
-
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/init.h>
-#include <linux/device.h>
-#include <linux/string.h>
-
-#include "linux/firmware.h"
-
-static struct device ghost_device = {
- .bus_id = "ghost0",
-};
-
-
-static void sample_firmware_load(char *firmware, int size)
-{
- u8 buf[size+1];
- memcpy(buf, firmware, size);
- buf[size] = '\0';
- printk(KERN_INFO "firmware_sample_driver: firmware: %s\n", buf);
-}
-
-static void sample_probe_default(void)
-{
- /* uses the default method to get the firmware */
- const struct firmware *fw_entry;
- printk(KERN_INFO "firmware_sample_driver: a ghost device got
inserted :)\n");
-
- if(request_firmware(&fw_entry, "sample_driver_fw",
&ghost_device)!=0)
- {
- printk(KERN_ERR
- "firmware_sample_driver: Firmware not available\n");
- return;
- }
-
- sample_firmware_load(fw_entry->data, fw_entry->size);
-
- release_firmware(fw_entry);
-
- /* finish setting up the device */
-}
-static void sample_probe_specific(void)
-{
- /* Uses some specific hotplug support to get the firmware from
- * userspace directly into the hardware, or via some sysfs file */
-
- /* NOTE: This currently doesn't work */
-
- printk(KERN_INFO "firmware_sample_driver: a ghost device got
inserted :)\n");
-
- if(request_firmware(NULL, "sample_driver_fw", &ghost_device)!=0)
- {
- printk(KERN_ERR
- "firmware_sample_driver: Firmware load failed\n");
- return;
- }
-
- /* request_firmware blocks until userspace finished, so at
- * this point the firmware should be already in the device */
-
- /* finish setting up the device */
-}
-static void sample_probe_async_cont(const struct firmware *fw, void
*context)
-{
- if(!fw){
- printk(KERN_ERR
- "firmware_sample_driver: firmware load failed\n");
- return;
- }
-
- printk(KERN_INFO "firmware_sample_driver: device pointer \"%s\"\n",
- (char *)context);
- sample_firmware_load(fw->data, fw->size);
-}
-static void sample_probe_async(void)
-{
- /* Let's say that I can't sleep */
- int error;
- error = request_firmware_nowait (THIS_MODULE, FW_ACTION_NOHOTPLUG,
- "sample_driver_fw", &ghost_device,
- "my device pointer",
- sample_probe_async_cont);
- if(error){
- printk(KERN_ERR
- "firmware_sample_driver:"
- " request_firmware_nowait failed\n");
- }
-}
-
-static int sample_init(void)
-{
- device_initialize(&ghost_device);
- /* since there is no real hardware insertion I just call the
- * sample probe functions here */
- sample_probe_specific();
- sample_probe_default();
- sample_probe_async();
- return 0;
-}
-static void __exit sample_exit(void)
-{
-}
-
-module_init (sample_init);
-module_exit (sample_exit);
-
-MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] request_firmware_examples
2006-09-07 23:25 [PATCH] request_firmware_examples Victor Hugo
@ 2006-09-07 23:31 ` Andrew Morton
2006-09-08 3:53 ` Oleg Verych
2006-09-15 17:14 ` Randy.Dunlap
2006-09-09 15:19 ` Alan Cox
1 sibling, 2 replies; 9+ messages in thread
From: Andrew Morton @ 2006-09-07 23:31 UTC (permalink / raw)
To: Victor Hugo; +Cc: linux-kernel, jonathan, greg, marcel
On Thu, 07 Sep 2006 16:25:45 -0700
Victor Hugo <victor@vhugo.net> wrote:
> My e-mail client should die a horrible death--
It would have plenty of company in the graveyard.
> Sorry Andrew, lets try this again
It's wordwrapped and included no changelog.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] request_firmware_examples
2006-09-07 23:31 ` Andrew Morton
@ 2006-09-08 3:53 ` Oleg Verych
2006-09-15 17:14 ` Randy.Dunlap
1 sibling, 0 replies; 9+ messages in thread
From: Oleg Verych @ 2006-09-08 3:53 UTC (permalink / raw)
To: linux-kernel; +Cc: Victor Hugo, jonathan, greg, marcel, Andrew Morton
Hallo, Victor Hugo
Andrew Morton wrote:
> On Thu, 07 Sep 2006 16:25:45 -0700
> Victor Hugo <victor@vhugo.net> wrote:
...
>>Sorry Andrew, lets try this again
>
> It's wordwrapped and included no changelog.
He-ha-he.
Can not send you writings to yourself to check, poor man ?!
Once again my (yet ENOPATCH) proposition: make things easy !
Help with this, if you _can_ code
<http://permalink.gmane.org/gmane.linux.debian.devel.kernel/21781> !!!
P.S. I think guy without ENOPATCH must be better in that, what he does....
-o--=O`C /. .\ (+)
#oo'L O o |
<___=E M ^-- | (you're barking up the wrong tree)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] request_firmware_examples
2006-09-07 23:31 ` Andrew Morton
2006-09-08 3:53 ` Oleg Verych
@ 2006-09-15 17:14 ` Randy.Dunlap
1 sibling, 0 replies; 9+ messages in thread
From: Randy.Dunlap @ 2006-09-15 17:14 UTC (permalink / raw)
To: Andrew Morton; +Cc: Victor Hugo, linux-kernel, jonathan, greg, marcel
On Thu, 7 Sep 2006 16:31:04 -0700 Andrew Morton wrote:
> On Thu, 07 Sep 2006 16:25:45 -0700
> Victor Hugo <victor@vhugo.net> wrote:
>
> > My e-mail client should die a horrible death--
>
> It would have plenty of company in the graveyard.
>
> > Sorry Andrew, lets try this again
>
> It's wordwrapped and included no changelog.
Victor,
thunderbird can be used successfully (without using
attachments) if you want/are willing to jump thru some hoops.
See http://mbligh.org/linuxdocs/Email/Clients/Thunderbird .
or use pine, mutt, sylpheed, etc.
---
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] request_firmware_examples
2006-09-07 23:25 [PATCH] request_firmware_examples Victor Hugo
2006-09-07 23:31 ` Andrew Morton
@ 2006-09-09 15:19 ` Alan Cox
1 sibling, 0 replies; 9+ messages in thread
From: Alan Cox @ 2006-09-09 15:19 UTC (permalink / raw)
To: Victor Hugo; +Cc: linux-kernel, akpm, jonathan, greg, marcel
Ar Iau, 2006-09-07 am 16:25 -0700, ysgrifennodd Victor Hugo:
> + u8 *buf = kmalloc(size + 1, GFP_KERNEL);
> + memcpy(buf, firmware, size);
NAK. Out of memory check please.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH]request_firmware examples
@ 2006-09-06 10:15 Victor Hugo
0 siblings, 0 replies; 9+ messages in thread
From: Victor Hugo @ 2006-09-06 10:15 UTC (permalink / raw)
To: linux-kernel; +Cc: Victor Castro
Hey all,
Here's the new patch for the firmware loader example drivers, fixed
possible stack overflow in original example file.
P.S.- sorry if I sent out some funky e-mails before, my email client
sucks--
Signed-off-by: Victor Hugo <victor@vhugo.net>
---
diff -Nur linux-2.6.17.11/Documentation/firmware_class/
firmware_example.c linux/Documentation/firmware_class/firmware_example.c
--- linux-2.6.17.11/Documentation/firmware_class/
firmware_example.c 1969-12-31 16:00:00.000000000 -0800
+++ linux/Documentation/firmware_class/firmware_example.c
2006-09-06 00:57:45.000000000 -0700
@@ -0,0 +1,68 @@
+/*
+ * firmware_example.c -
+ *
+ * Copyright (c) 2006 Victor Hugo <victor@vhugo.net>
+ * Based on firmware_sample_driver.c by Manuel Estrada Sainz
+ * Sample code on how to use request_firmware() from drivers.
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/device.h>
+#include <linux/string.h>
+#include <linux/firmware.h>
+
+static void sample_firmware_load(char *firmware, int size)
+{
+ u8 *buf = kmalloc(size + 1, GFP_KERNEL);
+ memcpy(buf, firmware, size);
+ buf[size] = '\0';
+ printk(KERN_INFO "firmware_example: Firmware: %s\n", buf);
+ kfree(buf);
+}
+
+static void sample_probe(struct device *dev)
+{
+ /* uses the default method to get the firmware */
+ const struct firmware *fw_entry;
+ printk(KERN_INFO "firmware_example: ghost device inserted\n");
+
+ if (request_firmware(&fw_entry, "sample_firware.bin", dev) !=
0) {
+ printk(KERN_ERR "firmware_example: Firmware not
available\n");
+ return;
+ }
+
+ sample_firmware_load(fw_entry->data, fw_entry->size);
+
+ release_firmware(fw_entry);
+
+ /* finish setting up the device */
+}
+
+static void ghost_release(struct device *dev)
+{
+ printk(KERN_DEBUG "firmware_example : ghost device released\n");
+}
+
+static struct device ghost_device = {
+ .bus_id = "ghost0",
+ .release = ghost_release
+};
+
+static int __init sample_init(void)
+{
+ device_register(&ghost_device);
+ sample_probe(&ghost_device);
+ return 0;
+}
+static void __exit sample_exit(void)
+{
+ device_unregister(&ghost_device);
+}
+
+module_init(sample_init);
+module_exit(sample_exit);
+
+MODULE_LICENSE("GPL");
diff -Nur linux-2.6.17.11/Documentation/firmware_class/
firmware_nowait_example.c linux/Documentation/firmware_class/
firmware_nowait_example.c
--- linux-2.6.17.11/Documentation/firmware_class/
firmware_nowait_example.c 1969-12-31 16:00:00.000000000 -0800
+++ linux/Documentation/firmware_class/
firmware_nowait_example.c 2006-09-06 00:58:06.000000000 -0700
@@ -0,0 +1,83 @@
+/*
+ * firmware_nowait_example.c -
+ *
+ * Copyright (c) 2006 Victor Hugo <victor@vhugo.net>
+ * Based on firmware_sample_driver.c by Manuel Estrada Sainz
+ * Sample code on how to use request_firmware() from drivers.
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/device.h>
+#include <linux/string.h>
+#include <linux/firmware.h>
+
+static void sample_firmware_load(char *firmware, int size)
+{
+ u8 *buf = kmalloc(size + 1, GFP_KERNEL);
+ memcpy(buf, firmware, size);
+ buf[size] = '\0';
+ printk(KERN_INFO "firmware_example: Firmware: %s\n", buf);
+ kfree(buf);
+}
+
+static void sample_probe_async_cont(const struct firmware *fw, void
*context)
+{
+ if (!fw) {
+ printk(KERN_ERR
+ "firmware_nowait_example: Firmware not
available\n");
+ return;
+ }
+
+ printk(KERN_INFO "firmware_nowait_example: Device Pointer \"%s
\"\n",
+ (char *)context);
+ sample_firmware_load(fw->data, fw->size);
+
+}
+
+static void sample_probe_async(struct device *dev)
+{
+ /* Let's say I can't sleep */
+ int error;
+
+ printk(KERN_INFO "firmware_example: ghost device inserted\n");
+
+ error = request_firmware_nowait(THIS_MODULE,
FW_ACTION_NOHOTPLUG,
+ "sample_firmware.bin", dev,
+ "my device pointer",
+ sample_probe_async_cont);
+
+ if (error) {
+ printk(KERN_ERR
+ "firmware_nowait_example:
request_firmware_nowait Failed\n");
+ }
+
+}
+
+static void ghost_release(struct device *dev)
+{
+ printk(KERN_DEBUG "firmware_nowait_example: ghost device
released\n");
+}
+
+static struct device ghost_device = {
+ .bus_id = "ghost0",
+ .release = ghost_release
+};
+
+static int __init sample_init(void)
+{
+ device_register(&ghost_device);
+ sample_probe_async(&ghost_device);
+ return 0;
+}
+static void __exit sample_exit(void)
+{
+ device_unregister(&ghost_device);
+}
+
+module_init(sample_init);
+module_exit(sample_exit);
+
+MODULE_LICENSE("GPL");
diff -Nur linux-2.6.17.11/Documentation/firmware_class/
firmware_sample_driver.c linux/Documentation/firmware_class/
firmware_sample_driver.c
--- linux-2.6.17.11/Documentation/firmware_class/
firmware_sample_driver.c 2006-08-23 14:16:33.000000000 -0700
+++ linux/Documentation/firmware_class/firmware_sample_driver.c
1969-12-31 16:00:00.000000000 -0800
@@ -1,115 +0,0 @@
-/*
- * firmware_sample_driver.c -
- *
- * Copyright (c) 2003 Manuel Estrada Sainz <ranty@debian.org>
- *
- * Sample code on how to use request_firmware() from drivers.
- *
- */
-
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/init.h>
-#include <linux/device.h>
-#include <linux/string.h>
-
-#include "linux/firmware.h"
-
-static struct device ghost_device = {
- .bus_id = "ghost0",
-};
-
-
-static void sample_firmware_load(char *firmware, int size)
-{
- u8 buf[size+1];
- memcpy(buf, firmware, size);
- buf[size] = '\0';
- printk(KERN_INFO "firmware_sample_driver: firmware: %s\n", buf);
-}
-
-static void sample_probe_default(void)
-{
- /* uses the default method to get the firmware */
- const struct firmware *fw_entry;
- printk(KERN_INFO "firmware_sample_driver: a ghost device got
inserted :)\n");
-
- if(request_firmware(&fw_entry, "sample_driver_fw",
&ghost_device)!=0)
- {
- printk(KERN_ERR
- "firmware_sample_driver: Firmware not available
\n");
- return;
- }
-
- sample_firmware_load(fw_entry->data, fw_entry->size);
-
- release_firmware(fw_entry);
-
- /* finish setting up the device */
-}
-static void sample_probe_specific(void)
-{
- /* Uses some specific hotplug support to get the firmware from
- * userspace directly into the hardware, or via some sysfs
file */
-
- /* NOTE: This currently doesn't work */
-
- printk(KERN_INFO "firmware_sample_driver: a ghost device got
inserted :)\n");
-
- if(request_firmware(NULL, "sample_driver_fw", &ghost_device)!
=0)
- {
- printk(KERN_ERR
- "firmware_sample_driver: Firmware load failed
\n");
- return;
- }
-
- /* request_firmware blocks until userspace finished, so at
- * this point the firmware should be already in the device */
-
- /* finish setting up the device */
-}
-static void sample_probe_async_cont(const struct firmware *fw, void
*context)
-{
- if(!fw){
- printk(KERN_ERR
- "firmware_sample_driver: firmware load failed
\n");
- return;
- }
-
- printk(KERN_INFO "firmware_sample_driver: device pointer \"%s
\"\n",
- (char *)context);
- sample_firmware_load(fw->data, fw->size);
-}
-static void sample_probe_async(void)
-{
- /* Let's say that I can't sleep */
- int error;
- error = request_firmware_nowait (THIS_MODULE,
FW_ACTION_NOHOTPLUG,
- "sample_driver_fw",
&ghost_device,
- "my device pointer",
- sample_probe_async_cont);
- if(error){
- printk(KERN_ERR
- "firmware_sample_driver:"
- " request_firmware_nowait failed\n");
- }
-}
-
-static int sample_init(void)
-{
- device_initialize(&ghost_device);
- /* since there is no real hardware insertion I just call the
- * sample probe functions here */
- sample_probe_specific();
- sample_probe_default();
- sample_probe_async();
- return 0;
-}
-static void __exit sample_exit(void)
-{
-}
-
-module_init (sample_init);
-module_exit (sample_exit);
-
-MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH]request_firmware examples
@ 2006-09-06 10:00 Victor Hugo
0 siblings, 0 replies; 9+ messages in thread
From: Victor Hugo @ 2006-09-06 10:00 UTC (permalink / raw)
To: linux-kernel
Hey all,
Here's the new patch for the firmware loader example drivers, fixed
possible stack overflow in original example file.
P.S.- sorry if I sent out some funky e-mails before, my email client
sucks--
Signed-off-by: Victor Hugo <victor@vhugo.net>
---
diff -Nur linux-2.6.17.11/Documentation/firmware_class/
firmware_example.c linux/Documentation/firmware_class/firmware_example.c
--- linux-2.6.17.11/Documentation/firmware_class/
firmware_example.c 1969-12-31 16:00:00.000000000 -0800
+++ linux/Documentation/firmware_class/firmware_example.c
2006-09-06 00:57:45.000000000 -0700
@@ -0,0 +1,68 @@
+/*
+ * firmware_example.c -
+ *
+ * Copyright (c) 2006 Victor Hugo <victor@vhugo.net>
+ * Based on firmware_sample_driver.c by Manuel Estrada Sainz
+ * Sample code on how to use request_firmware() from drivers.
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/device.h>
+#include <linux/string.h>
+#include <linux/firmware.h>
+
+static void sample_firmware_load(char *firmware, int size)
+{
+ u8 *buf = kmalloc(size + 1, GFP_KERNEL);
+ memcpy(buf, firmware, size);
+ buf[size] = '\0';
+ printk(KERN_INFO "firmware_example: Firmware: %s\n", buf);
+ kfree(buf);
+}
+
+static void sample_probe(struct device *dev)
+{
+ /* uses the default method to get the firmware */
+ const struct firmware *fw_entry;
+ printk(KERN_INFO "firmware_example: ghost device inserted\n");
+
+ if (request_firmware(&fw_entry, "sample_firware.bin", dev) !=
0) {
+ printk(KERN_ERR "firmware_example: Firmware not
available\n");
+ return;
+ }
+
+ sample_firmware_load(fw_entry->data, fw_entry->size);
+
+ release_firmware(fw_entry);
+
+ /* finish setting up the device */
+}
+
+static void ghost_release(struct device *dev)
+{
+ printk(KERN_DEBUG "firmware_example : ghost device released\n");
+}
+
+static struct device ghost_device = {
+ .bus_id = "ghost0",
+ .release = ghost_release
+};
+
+static int __init sample_init(void)
+{
+ device_register(&ghost_device);
+ sample_probe(&ghost_device);
+ return 0;
+}
+static void __exit sample_exit(void)
+{
+ device_unregister(&ghost_device);
+}
+
+module_init(sample_init);
+module_exit(sample_exit);
+
+MODULE_LICENSE("GPL");
diff -Nur linux-2.6.17.11/Documentation/firmware_class/
firmware_nowait_example.c linux/Documentation/firmware_class/
firmware_nowait_example.c
--- linux-2.6.17.11/Documentation/firmware_class/
firmware_nowait_example.c 1969-12-31 16:00:00.000000000 -0800
+++ linux/Documentation/firmware_class/
firmware_nowait_example.c 2006-09-06 00:58:06.000000000 -0700
@@ -0,0 +1,83 @@
+/*
+ * firmware_nowait_example.c -
+ *
+ * Copyright (c) 2006 Victor Hugo <victor@vhugo.net>
+ * Based on firmware_sample_driver.c by Manuel Estrada Sainz
+ * Sample code on how to use request_firmware() from drivers.
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/device.h>
+#include <linux/string.h>
+#include <linux/firmware.h>
+
+static void sample_firmware_load(char *firmware, int size)
+{
+ u8 *buf = kmalloc(size + 1, GFP_KERNEL);
+ memcpy(buf, firmware, size);
+ buf[size] = '\0';
+ printk(KERN_INFO "firmware_example: Firmware: %s\n", buf);
+ kfree(buf);
+}
+
+static void sample_probe_async_cont(const struct firmware *fw, void
*context)
+{
+ if (!fw) {
+ printk(KERN_ERR
+ "firmware_nowait_example: Firmware not
available\n");
+ return;
+ }
+
+ printk(KERN_INFO "firmware_nowait_example: Device Pointer \"%s
\"\n",
+ (char *)context);
+ sample_firmware_load(fw->data, fw->size);
+
+}
+
+static void sample_probe_async(struct device *dev)
+{
+ /* Let's say I can't sleep */
+ int error;
+
+ printk(KERN_INFO "firmware_example: ghost device inserted\n");
+
+ error = request_firmware_nowait(THIS_MODULE,
FW_ACTION_NOHOTPLUG,
+ "sample_firmware.bin", dev,
+ "my device pointer",
+ sample_probe_async_cont);
+
+ if (error) {
+ printk(KERN_ERR
+ "firmware_nowait_example:
request_firmware_nowait Failed\n");
+ }
+
+}
+
+static void ghost_release(struct device *dev)
+{
+ printk(KERN_DEBUG "firmware_nowait_example: ghost device
released\n");
+}
+
+static struct device ghost_device = {
+ .bus_id = "ghost0",
+ .release = ghost_release
+};
+
+static int __init sample_init(void)
+{
+ device_register(&ghost_device);
+ sample_probe_async(&ghost_device);
+ return 0;
+}
+static void __exit sample_exit(void)
+{
+ device_unregister(&ghost_device);
+}
+
+module_init(sample_init);
+module_exit(sample_exit);
+
+MODULE_LICENSE("GPL");
diff -Nur linux-2.6.17.11/Documentation/firmware_class/
firmware_sample_driver.c linux/Documentation/firmware_class/
firmware_sample_driver.c
--- linux-2.6.17.11/Documentation/firmware_class/
firmware_sample_driver.c 2006-08-23 14:16:33.000000000 -0700
+++ linux/Documentation/firmware_class/firmware_sample_driver.c
1969-12-31 16:00:00.000000000 -0800
@@ -1,115 +0,0 @@
-/*
- * firmware_sample_driver.c -
- *
- * Copyright (c) 2003 Manuel Estrada Sainz <ranty@debian.org>
- *
- * Sample code on how to use request_firmware() from drivers.
- *
- */
-
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/init.h>
-#include <linux/device.h>
-#include <linux/string.h>
-
-#include "linux/firmware.h"
-
-static struct device ghost_device = {
- .bus_id = "ghost0",
-};
-
-
-static void sample_firmware_load(char *firmware, int size)
-{
- u8 buf[size+1];
- memcpy(buf, firmware, size);
- buf[size] = '\0';
- printk(KERN_INFO "firmware_sample_driver: firmware: %s\n", buf);
-}
-
-static void sample_probe_default(void)
-{
- /* uses the default method to get the firmware */
- const struct firmware *fw_entry;
- printk(KERN_INFO "firmware_sample_driver: a ghost device got
inserted :)\n");
-
- if(request_firmware(&fw_entry, "sample_driver_fw",
&ghost_device)!=0)
- {
- printk(KERN_ERR
- "firmware_sample_driver: Firmware not available
\n");
- return;
- }
-
- sample_firmware_load(fw_entry->data, fw_entry->size);
-
- release_firmware(fw_entry);
-
- /* finish setting up the device */
-}
-static void sample_probe_specific(void)
-{
- /* Uses some specific hotplug support to get the firmware from
- * userspace directly into the hardware, or via some sysfs
file */
-
- /* NOTE: This currently doesn't work */
-
- printk(KERN_INFO "firmware_sample_driver: a ghost device got
inserted :)\n");
-
- if(request_firmware(NULL, "sample_driver_fw", &ghost_device)!
=0)
- {
- printk(KERN_ERR
- "firmware_sample_driver: Firmware load failed
\n");
- return;
- }
-
- /* request_firmware blocks until userspace finished, so at
- * this point the firmware should be already in the device */
-
- /* finish setting up the device */
-}
-static void sample_probe_async_cont(const struct firmware *fw, void
*context)
-{
- if(!fw){
- printk(KERN_ERR
- "firmware_sample_driver: firmware load failed
\n");
- return;
- }
-
- printk(KERN_INFO "firmware_sample_driver: device pointer \"%s
\"\n",
- (char *)context);
- sample_firmware_load(fw->data, fw->size);
-}
-static void sample_probe_async(void)
-{
- /* Let's say that I can't sleep */
- int error;
- error = request_firmware_nowait (THIS_MODULE,
FW_ACTION_NOHOTPLUG,
- "sample_driver_fw",
&ghost_device,
- "my device pointer",
- sample_probe_async_cont);
- if(error){
- printk(KERN_ERR
- "firmware_sample_driver:"
- " request_firmware_nowait failed\n");
- }
-}
-
-static int sample_init(void)
-{
- device_initialize(&ghost_device);
- /* since there is no real hardware insertion I just call the
- * sample probe functions here */
- sample_probe_specific();
- sample_probe_default();
- sample_probe_async();
- return 0;
-}
-static void __exit sample_exit(void)
-{
-}
-
-module_init (sample_init);
-module_exit (sample_exit);
-
-MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH]request_firmware examples
@ 2006-09-06 9:40 Victor Hugo
2006-09-07 16:56 ` Andrew Morton
0 siblings, 1 reply; 9+ messages in thread
From: Victor Hugo @ 2006-09-06 9:40 UTC (permalink / raw)
To: linux-kernel; +Cc: Jon Masters, akpm, mm-commits
Hey all,
Here's the new patch for the firmware loader example drivers, fixed
possible stack overflow in original example file.
Signed-off-by: Victor Hugo <victor@vhugo.net>
---
diff -Nur linux-2.6.17.11/Documentation/firmware_class/
firmware_example.c linux/Documentation/firmware_class/firmware_example.c
--- linux-2.6.17.11/Documentation/firmware_class/
firmware_example.c 1969-12-31 16:00:00.000000000 -0800
+++ linux/Documentation/firmware_class/firmware_example.c
2006-09-06 00:57:45.000000000 -0700
@@ -0,0 +1,68 @@
+/*
+ * firmware_example.c -
+ *
+ * Copyright (c) 2006 Victor Hugo <victor@vhugo.net>
+ * Based on firmware_sample_driver.c by Manuel Estrada Sainz
+ * Sample code on how to use request_firmware() from drivers.
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/device.h>
+#include <linux/string.h>
+#include <linux/firmware.h>
+
+static void sample_firmware_load(char *firmware, int size)
+{
+ u8 *buf = kmalloc(size + 1, GFP_KERNEL);
+ memcpy(buf, firmware, size);
+ buf[size] = '\0';
+ printk(KERN_INFO "firmware_example: Firmware: %s\n", buf);
+ kfree(buf);
+}
+
+static void sample_probe(struct device *dev)
+{
+ /* uses the default method to get the firmware */
+ const struct firmware *fw_entry;
+ printk(KERN_INFO "firmware_example: ghost device inserted\n");
+
+ if (request_firmware(&fw_entry, "sample_firware.bin", dev) !=
0) {
+ printk(KERN_ERR "firmware_example: Firmware not
available\n");
+ return;
+ }
+
+ sample_firmware_load(fw_entry->data, fw_entry->size);
+
+ release_firmware(fw_entry);
+
+ /* finish setting up the device */
+}
+
+static void ghost_release(struct device *dev)
+{
+ printk(KERN_DEBUG "firmware_example : ghost device released\n");
+}
+
+static struct device ghost_device = {
+ .bus_id = "ghost0",
+ .release = ghost_release
+};
+
+static int __init sample_init(void)
+{
+ device_register(&ghost_device);
+ sample_probe(&ghost_device);
+ return 0;
+}
+static void __exit sample_exit(void)
+{
+ device_unregister(&ghost_device);
+}
+
+module_init(sample_init);
+module_exit(sample_exit);
+
+MODULE_LICENSE("GPL");
diff -Nur linux-2.6.17.11/Documentation/firmware_class/
firmware_nowait_example.c linux/Documentation/firmware_class/
firmware_nowait_example.c
--- linux-2.6.17.11/Documentation/firmware_class/
firmware_nowait_example.c 1969-12-31 16:00:00.000000000 -0800
+++ linux/Documentation/firmware_class/
firmware_nowait_example.c 2006-09-06 00:58:06.000000000 -0700
@@ -0,0 +1,83 @@
+/*
+ * firmware_nowait_example.c -
+ *
+ * Copyright (c) 2006 Victor Hugo <victor@vhugo.net>
+ * Based on firmware_sample_driver.c by Manuel Estrada Sainz
+ * Sample code on how to use request_firmware() from drivers.
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/device.h>
+#include <linux/string.h>
+#include <linux/firmware.h>
+
+static void sample_firmware_load(char *firmware, int size)
+{
+ u8 *buf = kmalloc(size + 1, GFP_KERNEL);
+ memcpy(buf, firmware, size);
+ buf[size] = '\0';
+ printk(KERN_INFO "firmware_example: Firmware: %s\n", buf);
+ kfree(buf);
+}
+
+static void sample_probe_async_cont(const struct firmware *fw, void
*context)
+{
+ if (!fw) {
+ printk(KERN_ERR
+ "firmware_nowait_example: Firmware not
available\n");
+ return;
+ }
+
+ printk(KERN_INFO "firmware_nowait_example: Device Pointer \"%s
\"\n",
+ (char *)context);
+ sample_firmware_load(fw->data, fw->size);
+
+}
+
+static void sample_probe_async(struct device *dev)
+{
+ /* Let's say I can't sleep */
+ int error;
+
+ printk(KERN_INFO "firmware_example: ghost device inserted\n");
+
+ error = request_firmware_nowait(THIS_MODULE,
FW_ACTION_NOHOTPLUG,
+ "sample_firmware.bin", dev,
+ "my device pointer",
+ sample_probe_async_cont);
+
+ if (error) {
+ printk(KERN_ERR
+ "firmware_nowait_example:
request_firmware_nowait Failed\n");
+ }
+
+}
+
+static void ghost_release(struct device *dev)
+{
+ printk(KERN_DEBUG "firmware_nowait_example: ghost device
released\n");
+}
+
+static struct device ghost_device = {
+ .bus_id = "ghost0",
+ .release = ghost_release
+};
+
+static int __init sample_init(void)
+{
+ device_register(&ghost_device);
+ sample_probe_async(&ghost_device);
+ return 0;
+}
+static void __exit sample_exit(void)
+{
+ device_unregister(&ghost_device);
+}
+
+module_init(sample_init);
+module_exit(sample_exit);
+
+MODULE_LICENSE("GPL");
diff -Nur linux-2.6.17.11/Documentation/firmware_class/
firmware_sample_driver.c linux/Documentation/firmware_class/
firmware_sample_driver.c
--- linux-2.6.17.11/Documentation/firmware_class/
firmware_sample_driver.c 2006-08-23 14:16:33.000000000 -0700
+++ linux/Documentation/firmware_class/firmware_sample_driver.c
1969-12-31 16:00:00.000000000 -0800
@@ -1,115 +0,0 @@
-/*
- * firmware_sample_driver.c -
- *
- * Copyright (c) 2003 Manuel Estrada Sainz <ranty@debian.org>
- *
- * Sample code on how to use request_firmware() from drivers.
- *
- */
-
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/init.h>
-#include <linux/device.h>
-#include <linux/string.h>
-
-#include "linux/firmware.h"
-
-static struct device ghost_device = {
- .bus_id = "ghost0",
-};
-
-
-static void sample_firmware_load(char *firmware, int size)
-{
- u8 buf[size+1];
- memcpy(buf, firmware, size);
- buf[size] = '\0';
- printk(KERN_INFO "firmware_sample_driver: firmware: %s\n", buf);
-}
-
-static void sample_probe_default(void)
-{
- /* uses the default method to get the firmware */
- const struct firmware *fw_entry;
- printk(KERN_INFO "firmware_sample_driver: a ghost device got
inserted :)\n");
-
- if(request_firmware(&fw_entry, "sample_driver_fw",
&ghost_device)!=0)
- {
- printk(KERN_ERR
- "firmware_sample_driver: Firmware not available
\n");
- return;
- }
-
- sample_firmware_load(fw_entry->data, fw_entry->size);
-
- release_firmware(fw_entry);
-
- /* finish setting up the device */
-}
-static void sample_probe_specific(void)
-{
- /* Uses some specific hotplug support to get the firmware from
- * userspace directly into the hardware, or via some sysfs
file */
-
- /* NOTE: This currently doesn't work */
-
- printk(KERN_INFO "firmware_sample_driver: a ghost device got
inserted :)\n");
-
- if(request_firmware(NULL, "sample_driver_fw", &ghost_device)!
=0)
- {
- printk(KERN_ERR
- "firmware_sample_driver: Firmware load failed
\n");
- return;
- }
-
- /* request_firmware blocks until userspace finished, so at
- * this point the firmware should be already in the device */
-
- /* finish setting up the device */
-}
-static void sample_probe_async_cont(const struct firmware *fw, void
*context)
-{
- if(!fw){
- printk(KERN_ERR
- "firmware_sample_driver: firmware load failed
\n");
- return;
- }
-
- printk(KERN_INFO "firmware_sample_driver: device pointer \"%s
\"\n",
- (char *)context);
- sample_firmware_load(fw->data, fw->size);
-}
-static void sample_probe_async(void)
-{
- /* Let's say that I can't sleep */
- int error;
- error = request_firmware_nowait (THIS_MODULE,
FW_ACTION_NOHOTPLUG,
- "sample_driver_fw",
&ghost_device,
- "my device pointer",
- sample_probe_async_cont);
- if(error){
- printk(KERN_ERR
- "firmware_sample_driver:"
- " request_firmware_nowait failed\n");
- }
-}
-
-static int sample_init(void)
-{
- device_initialize(&ghost_device);
- /* since there is no real hardware insertion I just call the
- * sample probe functions here */
- sample_probe_specific();
- sample_probe_default();
- sample_probe_async();
- return 0;
-}
-static void __exit sample_exit(void)
-{
-}
-
-module_init (sample_init);
-module_exit (sample_exit);
-
-MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2006-09-15 17:13 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-07 23:25 [PATCH] request_firmware_examples Victor Hugo
2006-09-07 23:31 ` Andrew Morton
2006-09-08 3:53 ` Oleg Verych
2006-09-15 17:14 ` Randy.Dunlap
2006-09-09 15:19 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2006-09-06 10:15 [PATCH]request_firmware examples Victor Hugo
2006-09-06 10:00 Victor Hugo
2006-09-06 9:40 Victor Hugo
2006-09-07 16:56 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.