All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas GRAZIANO <nicolas.graziano@wanadoo.fr>
To: alsa-devel@alsa-project.org
Subject: [PATCH] hda_intel prefer 24bit instead of 20bit
Date: Sat, 16 Sep 2006 23:03:04 +0200	[thread overview]
Message-ID: <450C6688.10507@wanadoo.fr> (raw)

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

If I understand the hda_intel code, for format > 20bit it only advertise
the SNDRV_PCM_FMTBIT_S32_LE format and play it at 32 bit, 20 bit or 24 bit.

But if the 20bit and 24bit are available, actually it prefer the 20bit
format. This path is to prefer the 24bit format instead of 20bit.

Signed-off-by: Nicolas Graziano <nicolas.graziano@wanadoo.fr>

Nicolas

[-- Attachment #2: prefer24bitto20bit.patch --]
[-- Type: text/x-patch, Size: 557 bytes --]

diff -r b641fc7ea072 pci/hda/hda_codec.c
--- a/pci/hda/hda_codec.c	Tue Sep 12 15:35:35 2006 +0200
+++ b/pci/hda/hda_codec.c	Sat Sep 16 18:11:58 2006 +0200
@@ -1503,10 +1503,10 @@ int snd_hda_query_supported_pcm(struct h
 				formats |= SNDRV_PCM_FMTBIT_S32_LE;
 				if (val & AC_SUPPCM_BITS_32)
 					bps = 32;
+				else if (val & AC_SUPPCM_BITS_24)
+					bps = 24;
 				else if (val & AC_SUPPCM_BITS_20)
 					bps = 20;
-				else if (val & AC_SUPPCM_BITS_24)
-					bps = 24;
 			}
 		}
 		else if (streams == AC_SUPFMT_FLOAT32) { /* should be exclusive */

[-- Attachment #3: Type: text/plain, Size: 373 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

             reply	other threads:[~2006-09-16 21:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-16 21:03 Nicolas GRAZIANO [this message]
2006-09-19 14:37 ` [PATCH] hda_intel prefer 24bit instead of 20bit Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=450C6688.10507@wanadoo.fr \
    --to=nicolas.graziano@wanadoo.fr \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.