[PATCH] hda_intel prefer 24bit instead of 20bit

[PATCH] hda_intel prefer 24bit instead of 20bit

[Nicolas GRAZIANO]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

If I understand the hda_intel code, for format > 20bit it only advertise
the SNDRV_PCM_FMTBIT_S32_LE format and play it at 32 bit, 20 bit or 24 bit.

But if the 20bit and 24bit are available, actually it prefer the 20bit
format. This path is to prefer the 24bit format instead of 20bit.

Signed-off-by: Nicolas Graziano <nicolas.graziano@wanadoo.fr>

Nicolas

[-- Attachment #2: prefer24bitto20bit.patch --]
[-- Type: text/x-patch, Size: 557 bytes --]

diff -r b641fc7ea072 pci/hda/hda_codec.c
--- a/pci/hda/hda_codec.c	Tue Sep 12 15:35:35 2006 +0200
+++ b/pci/hda/hda_codec.c	Sat Sep 16 18:11:58 2006 +0200
@@ -1503,10 +1503,10 @@ int snd_hda_query_supported_pcm(struct h
 				formats |= SNDRV_PCM_FMTBIT_S32_LE;
 				if (val & AC_SUPPCM_BITS_32)
 					bps = 32;
+				else if (val & AC_SUPPCM_BITS_24)
+					bps = 24;
 				else if (val & AC_SUPPCM_BITS_20)
 					bps = 20;
-				else if (val & AC_SUPPCM_BITS_24)
-					bps = 24;
 			}
 		}
 		else if (streams == AC_SUPFMT_FLOAT32) { /* should be exclusive */

[-- Attachment #3: Type: text/plain, Size: 373 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: [PATCH] hda_intel prefer 24bit instead of 20bit

[Takashi Iwai]

At Sat, 16 Sep 2006 23:03:04 +0200,
Nicolas GRAZIANO wrote:
> 
> If I understand the hda_intel code, for format > 20bit it only advertise
> the SNDRV_PCM_FMTBIT_S32_LE format and play it at 32 bit, 20 bit or 24 bit.
> 
> But if the 20bit and 24bit are available, actually it prefer the 20bit
> format. This path is to prefer the 24bit format instead of 20bit.
> 
> Signed-off-by: Nicolas Graziano <nicolas.graziano@wanadoo.fr>

Applied to HG tree.  Thanks.


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV