All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: "Robin H. Johnson" <robbat2@gentoo.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY)
Date: Tue, 19 Sep 2006 15:24:46 +0900	[thread overview]
Message-ID: <450F8D2E.6060700@gmail.com> (raw)
In-Reply-To: <450F88F0.307@garzik.org>

Jeff Garzik wrote:
> I don't really like this port_tbl approach.  I think it complicates 
> things too much.
> 
> Direct indexing should be fine.  For the non-linear case, just make sure 
> the non-existent ports are always dummy ports.  If the driver directly 
> references a port we know isn't there, that's just an AHCI bug to be 
> fixed...

I thought about that too, but it will end up with ata1-6 with dummy 3 
and 4 while the BIOS shows continuous 4 ports.  I wanted avoid this 
discrepancy as it could cause confusion to users.

The other option is adding pp->port_idx to record hw port index.  It 
does make the code a bit simpler.  What do you think about this?

Thanks.

-- 
tejun

  reply	other threads:[~2006-09-19  6:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-14 20:05 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY) Robin H. Johnson
2006-09-14 19:19 ` Jeff Garzik
2006-09-14 20:50   ` Robin H. Johnson
2006-09-16 20:38     ` Robin H. Johnson
2006-09-16 21:08       ` Robin H. Johnson
2006-09-17  7:49         ` Tejun Heo
2006-09-18  3:48           ` Robin H. Johnson
2006-09-18  3:34             ` Tejun Heo
2006-09-19  3:53               ` Jeff Garzik
2006-09-19  4:49                 ` Robin H. Johnson
2006-09-19  6:06           ` Jeff Garzik
2006-09-19  6:24             ` Tejun Heo [this message]
2006-09-25 21:39               ` Robin H. Johnson
2006-09-19  7:03             ` Robin H. Johnson
2006-12-05  6:21           ` Kurtis D. Rader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=450F8D2E.6060700@gmail.com \
    --to=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robbat2@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.