Re: [PATCH] usb: onboard_dev: add the Rockchip rk1808

From: "Heiko Stübner" <heiko@sntech.de>
To: Rudi Heitbaum <rudi@heitbaum.com>
Cc: Matthias Kaehlcke <mka@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: onboard_dev: add the Rockchip rk1808
Date: Fri, 28 Aug 2026 14:14:22 +0200	[thread overview]
Message-ID: <4512468.iIbC2pHGDl@diego> (raw)
In-Reply-To: <apFpPP1O45BWXDv5@5be1eda4e59e>

Hi Rudi,

Am Freitag, 28. August 2026, 12:55:56 Mitteleuropäische Sommerzeit schrieb Rudi Heitbaum:
> On Thu, Aug 27, 2026 at 03:25:23PM +0200, Heiko Stuebner wrote:
> > Am Montag, 24. August 2026, 04:52:02 Mitteleuropäische Sommerzeit schrieb Rudi Heitbaum:
> > > The rk1808 is the npu die in an rk3399pro package. It is wired to one
> > > of the usb3 controllers rather than to an external port, and it needs
> > > its reference clock running before it will boot, which is exactly what
> > > this driver exists to do for onboard devices.
> > > 
> > > It takes no supply from the driver: the rails are sequenced elsewhere.
> > > Only the clock matters here, and that is already optional and handled
> > > generically.
> > 
> > the "elsewhere" might need a bit more explanation to verify it's the right
> > implementation. Even if the regulators are always-on or something, we
> > still want the supplies defined - for future uses.
> 
> As follow up on the bringup of the Rock-Pi-N10, the proposed change to the dtsi
> for the rk3399pro-vmarc-som is here, but needs the provision of the usb first.
> https://github.com/heitbaum/linux/commit/6b114b6fff4022c330003d7f70ce09915ffd774f

I might have formulated that strangly, what I meant was, who is enabling
the power supplies.

The "NPU Power" part of any rk3399pro schematics (should) list 5 power
supplies for the NPU block itself:

NPU_LOGIC_VDD
    --> regulator likely named NPU_VDD_LOG_S0
        --> enabled by NPU_PWREN_2 gpio fixed regulator

NPU_EFUSE_VQPS
    --> regulator likely named NPU_VCC1V8_EFUSE
        --> enabled by NPU_EFUSE_EN_H gpio fixed regulator

NPU_CORE_VDD
    --> regulator likely named NPU_VDD_S0
        --> TCS4525 regulator with voltage being set via the i2c controller
             inside the NPU - but enabled by the NPU_PWREN_6 gpio from
             core RK3399.

NPU_CPU_VDD
    --> regulator likely named NPU_VDD_CPU_S0
        --> enabled by NPU_PWREN_4 gpio fixed regulator

NPU_ADC_AVDD_1V8
    --> regulator likely named NPU_VCC_1V8_S3
        --> enabled by NPU_PWREN_3 gpio fixed regulator

Naming might vary, I found just some EVB schematics.

Someone needs to enable these, so the question was, who is doing that?

Thanks
Heiko

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip