From: Paulo Marques <pmarques@grupopie.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Om Narasimhan <om.turyx@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org
Subject: Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]
Date: Fri, 22 Sep 2006 11:32:15 +0000 [thread overview]
Message-ID: <4513C9BF.7040706@grupopie.com> (raw)
In-Reply-To: <4513A21C.40704@gmail.com>
Jiri Slaby wrote:
> Om Narasimhan wrote:
>> [...]
>> --- a/drivers/block/cpqarray.c
>> +++ b/drivers/block/cpqarray.c
>> @@ -424,7 +424,7 @@ static int __init cpqarray_register_ctlr
>> hba[i]->cmd_pool = (cmdlist_t *)pci_alloc_consistent(
>> hba[i]->pci_dev, NR_CMDS * sizeof(cmdlist_t),
>> &(hba[i]->cmd_pool_dhandle));
>> - hba[i]->cmd_pool_bits = kmalloc(
>> + hba[i]->cmd_pool_bits = kzalloc(
>> ((NR_CMDS+BITS_PER_LONG-1)/BITS_PER_LONG)*sizeof(unsigned long),
>> GFP_KERNEL);
>
> kcalloc?
Agreed on every comment except this one. That complex expression is
really just a constant in the end, so there is no point in using kcalloc.
--
Paulo Marques - www.grupopie.com
"The face of a child can say it all, especially the
mouth part of the face."
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: Paulo Marques <pmarques@grupopie.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Om Narasimhan <om.turyx@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org
Subject: Re: [KJ] kmalloc to kzalloc patches for drivers/block [sane version]
Date: Fri, 22 Sep 2006 12:32:15 +0100 [thread overview]
Message-ID: <4513C9BF.7040706@grupopie.com> (raw)
In-Reply-To: <4513A21C.40704@gmail.com>
Jiri Slaby wrote:
> Om Narasimhan wrote:
>> [...]
>> --- a/drivers/block/cpqarray.c
>> +++ b/drivers/block/cpqarray.c
>> @@ -424,7 +424,7 @@ static int __init cpqarray_register_ctlr
>> hba[i]->cmd_pool = (cmdlist_t *)pci_alloc_consistent(
>> hba[i]->pci_dev, NR_CMDS * sizeof(cmdlist_t),
>> &(hba[i]->cmd_pool_dhandle));
>> - hba[i]->cmd_pool_bits = kmalloc(
>> + hba[i]->cmd_pool_bits = kzalloc(
>> ((NR_CMDS+BITS_PER_LONG-1)/BITS_PER_LONG)*sizeof(unsigned long),
>> GFP_KERNEL);
>
> kcalloc?
Agreed on every comment except this one. That complex expression is
really just a constant in the end, so there is no point in using kcalloc.
--
Paulo Marques - www.grupopie.com
"The face of a child can say it all, especially the
mouth part of the face."
next prev parent reply other threads:[~2006-09-22 11:32 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-18 0:53 [KJ] kmalloc to kzalloc patches for drivers/mfd Om Narasimhan
2006-09-18 0:53 ` Om Narasimhan
2006-09-18 0:53 ` [KJ] kmalloc to kzalloc patches for drivers/atm Om Narasimhan
2006-09-18 0:53 ` Om Narasimhan
2006-09-18 1:19 ` [KJ] " Dmitry Torokhov
2006-09-18 1:19 ` Dmitry Torokhov
2006-09-18 9:42 ` [KJ] " Alan Cox
2006-09-18 9:42 ` Alan Cox
2006-09-18 12:07 ` [KJ] " Pekka Enberg
2006-09-18 12:07 ` Pekka Enberg
2006-09-18 0:53 ` [KJ] kmalloc to kzalloc patches for drivers/base Om Narasimhan
2006-09-18 0:53 ` Om Narasimhan
2006-09-18 1:08 ` [KJ] " Dmitry Torokhov
2006-09-18 1:08 ` Dmitry Torokhov
2006-09-18 2:27 ` [KJ] " Om Narasimhan
2006-09-18 2:27 ` Om Narasimhan
2006-09-18 9:40 ` [KJ] " Alan Cox
2006-09-18 9:40 ` Alan Cox
2006-09-18 12:31 ` [KJ] " Greg KH
2006-09-18 12:31 ` Greg KH
2006-09-18 0:54 ` [KJ] kmalloc to kzalloc patches for drivers/block Om Narasimhan
2006-09-18 0:54 ` Om Narasimhan
2006-09-18 9:43 ` [KJ] kmalloc to kzalloc patches for drivers/mfd Alan Cox
2006-09-18 9:43 ` Alan Cox
2006-09-21 6:11 ` [KJ] kmalloc to kzalloc patches for drivers/block [sane version] Om Narasimhan
2006-09-21 6:11 ` Om Narasimhan
2006-09-21 7:20 ` [KJ] " Nishanth Aravamudan
2006-09-21 7:20 ` Nishanth Aravamudan
2006-09-22 5:40 ` Om Narasimhan
2006-09-22 5:40 ` Om Narasimhan
2006-09-22 6:04 ` Om Narasimhan
2006-09-22 6:04 ` Om Narasimhan
2006-09-22 8:43 ` Jiri Slaby
2006-09-22 8:43 ` Jiri Slaby
2006-09-22 11:32 ` Paulo Marques [this message]
2006-09-22 11:32 ` Paulo Marques
2006-09-22 12:03 ` Pekka Enberg
2006-09-22 12:03 ` Pekka Enberg
2006-09-22 13:03 ` Paulo Marques
2006-09-22 13:03 ` Paulo Marques
2006-09-22 13:45 ` Dmitry Torokhov
2006-09-22 13:45 ` Dmitry Torokhov
2006-09-22 22:55 ` Om Narasimhan
2006-09-22 22:55 ` Om Narasimhan
2006-09-22 8:36 ` Jiri Slaby
2006-09-22 8:36 ` Jiri Slaby
2006-09-22 11:28 ` Paulo Marques
2006-09-22 11:28 ` Paulo Marques
2006-09-21 7:12 ` [KJ] kmalloc to kzalloc patches for drivers/atm " Om Narasimhan
2006-09-21 7:12 ` Om Narasimhan
2006-09-21 13:36 ` [KJ] " Dmitry Torokhov
2006-09-21 13:36 ` Dmitry Torokhov
2006-09-22 5:29 ` [KJ] " Om Narasimhan
2006-09-22 5:29 ` Om Narasimhan
2006-09-21 7:35 ` [KJ] kmalloc to kzalloc patches for drivers/block " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4513C9BF.7040706@grupopie.com \
--to=pmarques@grupopie.com \
--cc=jirislaby@gmail.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=om.turyx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.