All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karim Yaghmour <karim@opersys.com>
To: Mathieu Desnoyers <compudj@krystal.dyndns.org>
Cc: Ingo Molnar <mingo@elte.hu>, Martin Bligh <mbligh@google.com>,
	"Frank Ch. Eigler" <fche@redhat.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	prasanna@in.ibm.com, Andrew Morton <akpm@osdl.org>,
	Paul Mundt <lethal@linux-sh.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Jes Sorensen <jes@sgi.com>, Tom Zanussi <zanussi@us.ibm.com>,
	Richard J Moore <richardj_moore@uk.ibm.com>,
	Michel Dagenais <michel.dagenais@polymtl.ca>,
	Christoph Hellwig <hch@infradead.org>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	William Cohen <wcohen@redhat.com>,
	ltt-dev@shafik.org, systemtap@sources.redhat.com,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] Linux Kernel Markers 0.5 for Linux 2.6.17 (with probe management)
Date: Fri, 22 Sep 2006 13:03:21 -0400	[thread overview]
Message-ID: <45141759.8060600@opersys.com> (raw)
In-Reply-To: <20060922161353.GA1569@Krystal>


Mathieu Desnoyers wrote:
> First of all, I think that specific architecture-specific optimisations can and
> should be integrated in a more generic portable framework.

No disagreement there. If Ingo would care to comment, I think it might
be an acceptable compromise to have x86 fully use kprobes/djprobes
immediately, and the other archs could walk there at their rate.
Practically, some stuff in include/asm-i386/markers.h and
include/asm-x86_64/markers.h would contain the binary modifiable stuff
and include/asm-generic/markers.h could contain a platform-independent
fallback.

> Hrm, your comment makes me think of an interesting idea :
> 
> .align
> jump_address:
>   near jump to end
> setup_stack_address:
>   setup stack
>   call empty function
> end:
> 
> So, instead of putting nops in the target area, we fill it with a useful
> function call. Near jump being 2 bytes, it might be much easier to modify.
> If necessary, making sure the instruction is aligned would help to change it
> atomically. If we mark the jump address, the setup stack address and the end
> tag address with symbols, we can easily calculate (portably) the offset of the
> near jump to activate either the setup_stack_address or end tags.

That's another possibility. It seems more C friendly than the simple
short-jump+3bytes.

Ingo?

Karim
-- 
President  / Opersys Inc.
Embedded Linux Training and Expertise
www.opersys.com  /  1.866.677.4546

  reply	other threads:[~2006-09-22 16:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-21 16:00 [PATCH] Linux Kernel Markers 0.5 for Linux 2.6.17 (with probe management) Mathieu Desnoyers
2006-09-21 16:06 ` Ingo Molnar
2006-09-21 21:42   ` Mathieu Desnoyers
2006-09-21 21:49     ` Mathieu Desnoyers
2006-09-22  6:29     ` Karim Yaghmour
2006-09-22  6:49     ` Ingo Molnar
2006-09-22 14:03       ` Mathieu Desnoyers
2006-09-22 16:53         ` Ingo Molnar
2006-09-22 17:11           ` Mathieu Desnoyers
2006-09-22 17:12             ` Ingo Molnar
2006-09-22 17:28               ` Mathieu Desnoyers
2006-09-22  7:07     ` Ingo Molnar
2006-09-22  8:14       ` Karim Yaghmour
2006-09-22 15:08       ` Mathieu Desnoyers
2006-09-22 16:24         ` Karim Yaghmour
2006-09-22 16:13           ` Mathieu Desnoyers
2006-09-22 17:03             ` Karim Yaghmour [this message]
2006-09-22 18:06               ` Mathieu Desnoyers
2006-09-22 19:24                 ` Karim Yaghmour
2006-09-22 16:45         ` Ingo Molnar
2006-09-22 14:31     ` Christoph Hellwig
2006-09-23 16:51   ` Mathieu Desnoyers
2006-09-21 17:56 ` Frank Ch. Eigler
2006-09-21 18:50   ` Ingo Molnar
2006-09-21 19:54     ` Jeremy Fitzhardinge
2006-09-25 17:45     ` Frank Ch. Eigler
2006-09-21 20:59   ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45141759.8060600@opersys.com \
    --to=karim@opersys.com \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=compudj@krystal.dyndns.org \
    --cc=fche@redhat.com \
    --cc=gregkh@suse.de \
    --cc=hch@infradead.org \
    --cc=jes@sgi.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltt-dev@shafik.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mbligh@google.com \
    --cc=michel.dagenais@polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=prasanna@in.ibm.com \
    --cc=richardj_moore@uk.ibm.com \
    --cc=systemtap@sources.redhat.com \
    --cc=tglx@linutronix.de \
    --cc=wcohen@redhat.com \
    --cc=zanussi@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.