From: Arnd Bergmann <arnd@arndb.de>
To: zhichang <zhichang.yuan02@gmail.com>
Cc: devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com,
gabriele.paoloni@huawei.com, minyard@acm.org,
linux-pci@vger.kernel.org, gregkh@linuxfoundation.org,
john.garry@huawei.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org,
"zhichang.yuan" <yuanzhichang@hisilicon.com>,
linuxarm@huawei.com, xuwei5@hisilicon.com,
linux-serial@vger.kernel.org, benh@kernel.crashing.org,
zourongrong@gmail.com, liviu.dudau@arm.com, kantyzc@163.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V3 3/4] ARM64 LPC: support serial based on low-pin-count
Date: Wed, 21 Sep 2016 21:29:22 +0200 [thread overview]
Message-ID: <4518414.hTLWuvFlBl@wuerfel> (raw)
In-Reply-To: <815bebc1-96c9-2131-930d-bccdd4bf1c55@gmail.com>
T24gV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMjEsIDIwMTYgNjoxMjoyOCBQTSBDRVNUIHpoaWNoYW5n
IHdyb3RlOgo+IE9uIDIwMTblubQwOeaciDE15pelIDA1OjMzLCBBcm5kIEJlcmdtYW5uIHdyb3Rl
Ogo+ID4gT24gV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMTQsIDIwMTYgMTE6MDQ6MzMgUE0gQ0VTVCB6
aGljaGFuZy55dWFuIHdyb3RlOgo+ID4+IFRoZSA4MjUwX2hpc2lfbHBjLmMgc3VwcG9ydCBib3Ro
IEFDUEkgYW5kIGR0cyBzaW1pbGFyIHRvIDgyNTBfZHcgOgo+ID4+Cj4gPj4gK3N0YXRpYyBzdHJ1
Y3QgcGxhdGZvcm1fZHJpdmVyIGhzX2xwYzgyNTBfZHJpdmVyID0gewo+ID4+ICsgICAgICAgLmRy
aXZlciA9IHsKPiA+PiArICAgICAgICAgICAgICAgLm5hbWUgICAgICAgICAgID0gImhpc2ktbHBj
LXVhcnQiLAo+ID4+ICsgICAgICAgICAgICAgICAub2ZfbWF0Y2hfdGFibGUgPSBoczgyNTBfb2Zf
bWF0Y2gsCj4gPj4gKyAgICAgICAgICAgICAgIC5hY3BpX21hdGNoX3RhYmxlID0gQUNQSV9QVFIo
aHM4MjUwX2FjcGlfbWF0Y2gpLAo+ID4+Cj4gPj4gU28sIEkgYW0gYSBsaXR0bGUgY29uZnVzZWQg
d2h5IHdlIG5lZWQgdG8gc3VwcG9ydCBkdHMgaW4gODI1MF9vZi5jIGFuZCBzdXBwb3J0IEFDUEkg
aW4gYW5vdGhlcgo+ID4+IGRyaXZlciBmaWxlLgo+ID4+Cj4gPiAKPiA+IEFmdGVyIGxvb2tpbmcg
YWdhaW4sIEknbSBwcmV0dHkgc3VyZSB0aGF0IGRyaXZlcnMvdHR5L3NlcmlhbC84MjUwLzgyNTBf
cG5wLmMKPiA+IHdpbGwgaGFuZGxlIHRoZSBBQ1BJIGNhc2Ugd2l0aG91dCBtb2RpZmljYXRpb25z
LCB5b3UganVzdCBuZWVkIHRvIGFkYXB0Cj4gPiB0aGUgODI1MF9vZiBkcml2ZXIgdG8gaGFuZGxl
IElPUkVTT1VSQ0VfSU8gcG9ydHMuIFRoaXMgd2lsbCBiZSByZXF1aXJlZAo+ID4gYW55d2F5IHdp
dGggdGhlIG5leHQgdmVyc2lvbiBvbmNlIHRoZSBMUEMgYnJpZGdlIGlzIG9uIHRoZSBQQ0kgYnVz
Lgo+ID4gCj4gCj4gWWVzLiBZb3UgYXJlIHJpZ2h0Lgo+IAo+IFdoZW4gdGhlIGluZGlyZWN0SU8g
cGF0Y2ggaXMgYWNjZXB0ZWQsIG5vIG11Y2ggY2hhbmdlcyBuZWVkZWQgaW4gdGhlc2UgdHdvIGZp
bGUgdG8gc3VwcG9ydCBMUEMgVUFSVC4KPiAKPiBCVFcsIHdoYXQgaXMgeW91ciB0YXJnZXQgdG8g
Y2hhbmdlIHRoZXNlIHR3byBmaWxlcyB0byBzdXBwb3J0IExQQyB1YXJ0Pwo+IERvIHlvdSB0aGlu
ayB3ZSBkb24ndCBuZWVkIHRvIGFkZCBtYW55IG5ldyBjIGZpbGVzPz8KCkkgdGhpbmsgYnkgbW9k
aWZ5aW5nIDgyNTBfb2YuYywgeW91IHNob3VsZCBiZSBhYmxlIHRvIG1ha2UgYW55IFVBUlQgb24K
c29tZSBMUEMgYnVzIHdvcmssIHJlZ2FyZGxlc3Mgb2Ygd2hhdCBjb250cm9sbGVyIGlzIHVzZWQu
CgpUaGUgQUNQSSB2ZXJzaW9uICg4MjUwX3BucC5jKSBzaG91bGRuJ3QgbmVlZCBhbnkgY2hhbmdl
cyBhdCBhbGwgaWYgSQpyZWFkIHRoYXQgY29ycmVjdGx5LgoKCUFybmQKCl9fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu
ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu
aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: zhichang <zhichang.yuan02@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
"zhichang.yuan" <yuanzhichang@hisilicon.com>,
devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com,
gabriele.paoloni@huawei.com, minyard@acm.org,
gregkh@linuxfoundation.org, benh@kernel.crashing.org,
john.garry@huawei.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, xuwei5@hisilicon.com,
linuxarm@huawei.com, linux-serial@vger.kernel.org,
linux-pci@vger.kernel.org, zourongrong@gmail.com,
liviu.dudau@arm.com, kantyzc@163.com
Subject: Re: [PATCH V3 3/4] ARM64 LPC: support serial based on low-pin-count
Date: Wed, 21 Sep 2016 21:29:22 +0200 [thread overview]
Message-ID: <4518414.hTLWuvFlBl@wuerfel> (raw)
In-Reply-To: <815bebc1-96c9-2131-930d-bccdd4bf1c55@gmail.com>
On Wednesday, September 21, 2016 6:12:28 PM CEST zhichang wrote:
> On 2016年09月15日 05:33, Arnd Bergmann wrote:
> > On Wednesday, September 14, 2016 11:04:33 PM CEST zhichang.yuan wrote:
> >> The 8250_hisi_lpc.c support both ACPI and dts similar to 8250_dw :
> >>
> >> +static struct platform_driver hs_lpc8250_driver = {
> >> + .driver = {
> >> + .name = "hisi-lpc-uart",
> >> + .of_match_table = hs8250_of_match,
> >> + .acpi_match_table = ACPI_PTR(hs8250_acpi_match),
> >>
> >> So, I am a little confused why we need to support dts in 8250_of.c and support ACPI in another
> >> driver file.
> >>
> >
> > After looking again, I'm pretty sure that drivers/tty/serial/8250/8250_pnp.c
> > will handle the ACPI case without modifications, you just need to adapt
> > the 8250_of driver to handle IORESOURCE_IO ports. This will be required
> > anyway with the next version once the LPC bridge is on the PCI bus.
> >
>
> Yes. You are right.
>
> When the indirectIO patch is accepted, no much changes needed in these two file to support LPC UART.
>
> BTW, what is your target to change these two files to support LPC uart?
> Do you think we don't need to add many new c files??
I think by modifying 8250_of.c, you should be able to make any UART on
some LPC bus work, regardless of what controller is used.
The ACPI version (8250_pnp.c) shouldn't need any changes at all if I
read that correctly.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 3/4] ARM64 LPC: support serial based on low-pin-count
Date: Wed, 21 Sep 2016 21:29:22 +0200 [thread overview]
Message-ID: <4518414.hTLWuvFlBl@wuerfel> (raw)
In-Reply-To: <815bebc1-96c9-2131-930d-bccdd4bf1c55@gmail.com>
On Wednesday, September 21, 2016 6:12:28 PM CEST zhichang wrote:
> On 2016?09?15? 05:33, Arnd Bergmann wrote:
> > On Wednesday, September 14, 2016 11:04:33 PM CEST zhichang.yuan wrote:
> >> The 8250_hisi_lpc.c support both ACPI and dts similar to 8250_dw :
> >>
> >> +static struct platform_driver hs_lpc8250_driver = {
> >> + .driver = {
> >> + .name = "hisi-lpc-uart",
> >> + .of_match_table = hs8250_of_match,
> >> + .acpi_match_table = ACPI_PTR(hs8250_acpi_match),
> >>
> >> So, I am a little confused why we need to support dts in 8250_of.c and support ACPI in another
> >> driver file.
> >>
> >
> > After looking again, I'm pretty sure that drivers/tty/serial/8250/8250_pnp.c
> > will handle the ACPI case without modifications, you just need to adapt
> > the 8250_of driver to handle IORESOURCE_IO ports. This will be required
> > anyway with the next version once the LPC bridge is on the PCI bus.
> >
>
> Yes. You are right.
>
> When the indirectIO patch is accepted, no much changes needed in these two file to support LPC UART.
>
> BTW, what is your target to change these two files to support LPC uart?
> Do you think we don't need to add many new c files??
I think by modifying 8250_of.c, you should be able to make any UART on
some LPC bus work, regardless of what controller is used.
The ACPI version (8250_pnp.c) shouldn't need any changes at all if I
read that correctly.
Arnd
next prev parent reply other threads:[~2016-09-21 19:29 UTC|newest]
Thread overview: 149+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 12:15 [PATCH V3 0/4] ARM64 LPC: legacy ISA I/O support Zhichang Yuan
2016-09-14 12:15 ` Zhichang Yuan
2016-09-14 12:15 ` Zhichang Yuan
2016-09-14 12:15 ` [PATCH V3 1/4] ARM64 LPC: Indirect ISA port IO introduced Zhichang Yuan
2016-09-14 12:15 ` Zhichang Yuan
2016-09-14 12:15 ` Zhichang Yuan
2016-09-14 12:24 ` Arnd Bergmann
2016-09-14 12:24 ` Arnd Bergmann
2016-09-14 14:16 ` zhichang.yuan
2016-09-14 14:16 ` zhichang.yuan
2016-09-14 14:16 ` zhichang.yuan
2016-09-14 14:23 ` Arnd Bergmann
2016-09-14 14:23 ` Arnd Bergmann
2016-09-14 14:23 ` Arnd Bergmann
2016-09-18 3:38 ` zhichang
2016-09-18 3:38 ` zhichang
2016-09-18 3:38 ` zhichang
2016-09-21 9:26 ` zhichang
2016-09-21 9:26 ` zhichang
2016-09-21 9:26 ` zhichang
2016-09-14 12:15 ` [PATCH V3 2/4] ARM64 LPC: LPC driver implementation on Hip06 Zhichang Yuan
2016-09-14 12:15 ` Zhichang Yuan
2016-09-14 12:15 ` Zhichang Yuan
2016-09-14 12:33 ` Arnd Bergmann
2016-09-14 12:33 ` Arnd Bergmann
2016-09-14 14:50 ` zhichang.yuan
2016-09-14 14:50 ` zhichang.yuan
2016-09-14 14:50 ` zhichang.yuan
2016-09-14 21:32 ` Arnd Bergmann
2016-09-14 21:32 ` Arnd Bergmann
2016-09-15 8:02 ` Gabriele Paoloni
2016-09-15 8:02 ` Gabriele Paoloni
2016-09-15 8:02 ` Gabriele Paoloni
2016-09-15 8:02 ` Gabriele Paoloni
2016-09-15 8:22 ` Arnd Bergmann
2016-09-15 8:22 ` Arnd Bergmann
2016-09-15 8:22 ` Arnd Bergmann
2016-09-15 12:05 ` Gabriele Paoloni
2016-09-15 12:05 ` Gabriele Paoloni
2016-09-15 12:05 ` Gabriele Paoloni
2016-09-15 12:24 ` Arnd Bergmann
2016-09-15 12:24 ` Arnd Bergmann
2016-09-15 12:24 ` Arnd Bergmann
2016-09-15 14:28 ` Gabriele Paoloni
2016-09-15 14:28 ` Gabriele Paoloni
2016-09-15 14:28 ` Gabriele Paoloni
2016-09-21 10:09 ` zhichang
2016-09-21 10:09 ` zhichang
2016-09-21 10:09 ` zhichang
2016-09-21 16:20 ` Gabriele Paoloni
2016-09-21 16:20 ` Gabriele Paoloni
2016-09-21 16:20 ` Gabriele Paoloni
2016-09-21 16:20 ` Gabriele Paoloni
2016-09-21 20:18 ` Arnd Bergmann
2016-09-21 20:18 ` Arnd Bergmann
2016-09-21 20:18 ` Arnd Bergmann
2016-09-21 20:18 ` Arnd Bergmann
2016-09-22 11:55 ` Gabriele Paoloni
2016-09-22 11:55 ` Gabriele Paoloni
2016-09-22 11:55 ` Gabriele Paoloni
2016-09-22 11:55 ` Gabriele Paoloni
2016-09-22 12:14 ` Arnd Bergmann
2016-09-22 12:14 ` Arnd Bergmann
2016-09-22 12:14 ` Arnd Bergmann
2016-09-22 12:14 ` Arnd Bergmann
2016-09-22 14:47 ` Gabriele Paoloni
2016-09-22 14:47 ` Gabriele Paoloni
2016-09-22 14:47 ` Gabriele Paoloni
2016-09-22 14:59 ` Arnd Bergmann
2016-09-22 14:59 ` Arnd Bergmann
2016-09-22 14:59 ` Arnd Bergmann
2016-09-22 15:20 ` Gabriele Paoloni
2016-09-22 15:20 ` Gabriele Paoloni
2016-09-22 15:20 ` Gabriele Paoloni
2016-09-22 15:46 ` zhichang.yuan
2016-09-22 15:46 ` zhichang.yuan
2016-09-22 15:46 ` zhichang.yuan
2016-09-22 16:27 ` zhichang.yuan
2016-09-22 16:27 ` zhichang.yuan
2016-09-22 16:27 ` zhichang.yuan
2016-09-22 16:27 ` zhichang.yuan
2016-09-23 9:51 ` Arnd Bergmann
2016-09-23 9:51 ` Arnd Bergmann
2016-09-23 9:51 ` Arnd Bergmann
2016-09-23 9:51 ` Arnd Bergmann
2016-09-23 10:23 ` Gabriele Paoloni
2016-09-23 10:23 ` Gabriele Paoloni
2016-09-23 10:23 ` Gabriele Paoloni
2016-09-23 13:42 ` Arnd Bergmann
2016-09-23 13:42 ` Arnd Bergmann
2016-09-23 13:42 ` Arnd Bergmann
2016-09-23 14:59 ` Gabriele Paoloni
2016-09-23 14:59 ` Gabriele Paoloni
2016-09-23 14:59 ` Gabriele Paoloni
2016-09-23 15:55 ` Arnd Bergmann
2016-09-23 15:55 ` Arnd Bergmann
2016-09-23 15:55 ` Arnd Bergmann
2016-09-23 15:55 ` Arnd Bergmann
2016-09-24 8:14 ` zhichang
2016-09-24 8:14 ` zhichang
2016-09-24 8:14 ` zhichang
2016-09-24 21:00 ` Arnd Bergmann
2016-09-24 21:00 ` Arnd Bergmann
2016-09-24 21:00 ` Arnd Bergmann
2016-09-24 21:00 ` Arnd Bergmann
2016-09-26 13:21 ` Gabriele Paoloni
2016-09-26 13:21 ` Gabriele Paoloni
2016-09-26 13:21 ` Gabriele Paoloni
2016-09-26 13:21 ` Gabriele Paoloni
2016-09-24 8:00 ` zhichang
2016-09-24 8:00 ` zhichang
2016-09-24 8:00 ` zhichang
2016-09-24 8:00 ` zhichang
2016-10-02 22:03 ` Jon Masters
2016-10-02 22:03 ` Jon Masters
2016-10-02 22:03 ` Jon Masters
2016-10-02 22:03 ` Jon Masters
2016-10-04 12:02 ` John Garry
2016-10-04 12:02 ` John Garry
2016-10-04 12:02 ` John Garry
2016-10-06 0:18 ` Benjamin Herrenschmidt
2016-10-06 0:18 ` Benjamin Herrenschmidt
2016-10-06 0:18 ` Benjamin Herrenschmidt
2016-10-06 13:31 ` John Garry
2016-10-06 13:31 ` John Garry
2016-10-06 13:31 ` John Garry
2016-09-14 14:09 ` kbuild test robot
2016-09-14 14:09 ` kbuild test robot
2016-09-14 14:09 ` kbuild test robot
2016-09-14 12:15 ` [PATCH V3 3/4] ARM64 LPC: support serial based on low-pin-count Zhichang Yuan
2016-09-14 12:15 ` Zhichang Yuan
2016-09-14 12:15 ` Zhichang Yuan
2016-09-14 12:25 ` Arnd Bergmann
2016-09-14 12:25 ` Arnd Bergmann
2016-09-14 12:25 ` Arnd Bergmann
2016-09-14 15:04 ` zhichang.yuan
2016-09-14 15:04 ` zhichang.yuan
2016-09-14 15:04 ` zhichang.yuan
2016-09-14 21:33 ` Arnd Bergmann
2016-09-14 21:33 ` Arnd Bergmann
2016-09-21 10:12 ` zhichang
2016-09-21 10:12 ` zhichang
2016-09-21 10:12 ` zhichang
2016-09-21 19:29 ` Arnd Bergmann [this message]
2016-09-21 19:29 ` Arnd Bergmann
2016-09-21 19:29 ` Arnd Bergmann
2016-09-14 12:15 ` [PATCH V3 4/4] ARM64 LPC: support earlycon for UART connected to LPC Zhichang Yuan
2016-09-14 12:15 ` Zhichang Yuan
2016-09-14 12:15 ` Zhichang Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4518414.hTLWuvFlBl@wuerfel \
--to=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=gabriele.paoloni@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.garry@huawei.com \
--cc=kantyzc@163.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=minyard@acm.org \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
--cc=yuanzhichang@hisilicon.com \
--cc=zhichang.yuan02@gmail.com \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.