From: Anthony Liguori <aliguori@us.ibm.com>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: xen-devel@lists.xensource.com,
Molle Bestefich <molle.bestefich@gmail.com>
Subject: Re: [PATCH] [XEND] Remove hard tabs
Date: Tue, 26 Sep 2006 10:34:12 -0500 [thread overview]
Message-ID: <45194874.5090903@us.ibm.com> (raw)
In-Reply-To: <1159202321.9507.17.camel@basalt.austin.ibm.com>
Hollis Blanchard wrote:
> On Sun, 2006-09-24 at 12:50 +0200, Molle Bestefich wrote:
>
>> Hollis Blanchard wrote:
>>
>>> Molle Bestefich wrote:
>>>
>>>> Hollis Blanchard:
>>>>
>>>>> [XEND] Remove hard tabs.
>>>>>
>>>> That's stupid, tabs are a relief to use when coding compared to spaces.
>>>>
>>> That's a separate conversation.
>>>
>> Seemed relevant since what you're doing is switching things originally
>> coded one way to use what *you* prefer, without changing the code at
>> all (right?).
>>
>
> No, actually, I prefer tabs. :) However, there were ~10 lines in that
> file using tabs, with all the rest using spaces. In Python that's a more
> serious offense than in other languages.
>
As it has been mentioned, whitespace is the right thing to do in
python. It's not a point of debate.
Tab-width is interpreted as 8 in Python. This can lead to subtle bugs
in code where people use text-editors with different width tabs. These
are real bugs that have actually occurred in Xen before.
There have been big patches in Xend to globally remove tabs. Any time
the creep back in, they ought to be removed.
For more info, see:
http://docs.python.org/ref/indentation.html
Regards,
Anthony Liguori
next prev parent reply other threads:[~2006-09-26 15:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 19:21 [PATCH] [XEND] Remove hard tabs Hollis Blanchard
2006-09-21 5:58 ` Molle Bestefich
2006-09-21 20:28 ` Hollis Blanchard
2006-09-24 10:50 ` Molle Bestefich
2006-09-25 16:38 ` Hollis Blanchard
2006-09-26 15:34 ` Anthony Liguori [this message]
2006-09-25 17:07 ` Sean Dague
2006-09-27 14:07 ` Steven Rostedt
2006-09-27 21:43 ` RFC - PV blk driver for hvm guest Ross Maxfield
2006-09-27 22:26 ` Dom0 hang problem Subrahmanian, Raj
2006-09-27 22:44 ` Ian Pratt
2006-10-01 17:42 ` RFC - PV blk driver for hvm guest Steven Smith
[not found] ` <45223DA0.DD28.00D3.0@novell.com>
2006-10-07 9:53 ` Steven Smith
2006-09-22 2:36 ` [PATCH] [XEND] Remove hard tabs Dan Smith
2006-10-12 16:33 ` Mark Williamson
2006-09-22 16:36 ` Alastair Tse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45194874.5090903@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=hollisb@us.ibm.com \
--cc=molle.bestefich@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.