All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] let mortals use ethtool
Date: Thu, 28 Sep 2006 16:23:46 -0400	[thread overview]
Message-ID: <451C2F52.6040003@pobox.com> (raw)
In-Reply-To: <20060928122514.112a19a8@dxpl.pdx.osdl.net>

Stephen Hemminger wrote:
> There is no reason to not allow non-admin users to query network
> statistics and settings.

NAK.

Some functions in the past didn't like getting hit rapidly in succession.

I would agree to this, but only after an exhaustive audit of each driver 
and each sub-ioctl.  Right now, I only have confidence in GDRVINFO 
probably being safe -- but still that requires an audit, since in rare 
cases the driver may be poking firmware and eeprom areas.

Finally, I fixed a buffer overflow in ethtool version 5, so an audit to 
make sure overflows cannot affect the kernel is basically _required_.

	Jeff





  parent reply	other threads:[~2006-09-28 20:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-28 19:25 [RFC] let mortals use ethtool Stephen Hemminger
2006-09-28 19:53 ` James Morris
2006-09-28 20:43   ` Jeff Garzik
2006-09-28 19:56 ` Auke Kok
2006-09-28 21:53   ` David Miller
2006-09-28 22:03     ` Michael Chan
2006-09-28 22:22       ` David Miller
2006-09-28 20:17 ` Michael Chan
2006-09-28 20:28   ` Jeff Garzik
2006-09-28 20:32   ` James Morris
2006-09-28 20:35     ` Jeff Garzik
2006-09-28 20:39       ` Michael Chan
2006-09-28 22:16     ` David Miller
2006-09-28 22:30       ` Jeff Garzik
2006-09-28 22:13   ` David Miller
2006-09-28 22:25     ` Jeff Garzik
2006-09-28 22:33       ` David Miller
2006-09-28 20:23 ` Jeff Garzik [this message]
2006-09-28 22:15   ` David Miller
2006-09-28 22:41   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=451C2F52.6040003@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.