All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: David Miller <davem@davemloft.net>
Cc: mchan@broadcom.com, shemminger@osdl.org, netdev@vger.kernel.org
Subject: Re: [RFC] let mortals use ethtool
Date: Thu, 28 Sep 2006 18:25:26 -0400	[thread overview]
Message-ID: <451C4BD6.7050200@pobox.com> (raw)
In-Reply-To: <20060928.151358.01288837.davem@davemloft.net>

David Miller wrote:
> From: "Michael Chan" <mchan@broadcom.com>
> Date: Thu, 28 Sep 2006 13:17:04 -0700
> 
>> I'm against letting normal users do ETHTOOL_GREGS and ETHTOOL_PHYS_ID.
>> Dumping 64K worth of registers and blinking the LEDs should be
>> restricted.  But I have no problem doing these checks in the driver if
>> necessary.
> 
> Ok I removed PHYS_ID and GREGS from the allowed list.
> Any others?

GWOL now spits out a password for all users -> security risk.  Ditto 
GEEPROM.  GSET has been known to cause hangs if done in a tight loop, on 
some 10/100 cards, which is now permitted by any user.  At the very 
least, it should be rate-limited.

I wasn't just being obstinate, when requesting an audit.

	Jeff




  reply	other threads:[~2006-09-28 22:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-28 19:25 [RFC] let mortals use ethtool Stephen Hemminger
2006-09-28 19:53 ` James Morris
2006-09-28 20:43   ` Jeff Garzik
2006-09-28 19:56 ` Auke Kok
2006-09-28 21:53   ` David Miller
2006-09-28 22:03     ` Michael Chan
2006-09-28 22:22       ` David Miller
2006-09-28 20:17 ` Michael Chan
2006-09-28 20:28   ` Jeff Garzik
2006-09-28 20:32   ` James Morris
2006-09-28 20:35     ` Jeff Garzik
2006-09-28 20:39       ` Michael Chan
2006-09-28 22:16     ` David Miller
2006-09-28 22:30       ` Jeff Garzik
2006-09-28 22:13   ` David Miller
2006-09-28 22:25     ` Jeff Garzik [this message]
2006-09-28 22:33       ` David Miller
2006-09-28 20:23 ` Jeff Garzik
2006-09-28 22:15   ` David Miller
2006-09-28 22:41   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=451C4BD6.7050200@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=davem@davemloft.net \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.