All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Duje Mihanović" <duje.mihanovic@skole.hr>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Russell King <linux@armlinux.org.uk>,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andy@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-input@vger.kernel.org,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH RFC v4 5/6] ARM: pxa: Convert gumstix Bluetooth to GPIO descriptors
Date: Mon, 02 Oct 2023 16:52:56 +0200	[thread overview]
Message-ID: <4528128.LvFx2qVVIh@radijator> (raw)
In-Reply-To: <CAMRc=MdHv0YxSowMnqJ8xG1_w8dwTWVJV1K0b1jgectPTbOheQ@mail.gmail.com>

On Monday, October 2, 2023 9:42:52 AM CEST Bartosz Golaszewski wrote:
> This changes the way this code works. You release the descriptor here,
> it returns to the driver and can be re-requested by someone else. Its
> value is also not guaranteed to remain as "active". Is this what you
> want?

Good point. Is it enough to not call gpiod_put() at the end or is it necessary 
to use a static gpio_desc instead of a local one?

Regards,
Duje




WARNING: multiple messages have this Message-ID (diff)
From: "Duje Mihanović" <duje.mihanovic@skole.hr>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Russell King <linux@armlinux.org.uk>,
	Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andy@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-input@vger.kernel.org,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH RFC v4 5/6] ARM: pxa: Convert gumstix Bluetooth to GPIO descriptors
Date: Mon, 02 Oct 2023 16:52:56 +0200	[thread overview]
Message-ID: <4528128.LvFx2qVVIh@radijator> (raw)
In-Reply-To: <CAMRc=MdHv0YxSowMnqJ8xG1_w8dwTWVJV1K0b1jgectPTbOheQ@mail.gmail.com>

On Monday, October 2, 2023 9:42:52 AM CEST Bartosz Golaszewski wrote:
> This changes the way this code works. You release the descriptor here,
> it returns to the driver and can be re-requested by someone else. Its
> value is also not guaranteed to remain as "active". Is this what you
> want?

Good point. Is it enough to not call gpiod_put() at the end or is it necessary 
to use a static gpio_desc instead of a local one?

Regards,
Duje




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-10-02 14:53 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-01 14:12 [PATCH RFC v4 0/6] ARM: pxa: GPIO descriptor conversions Duje Mihanović
2023-10-01 14:12 ` [PATCH RFC v4 1/6] ARM: pxa: Convert Spitz OHCI to GPIO descriptors Duje Mihanović
2023-10-01 14:32   ` Andy Shevchenko
2023-10-01 14:32     ` Andy Shevchenko
2023-10-01 18:39     ` Duje Mihanović
2023-10-01 18:39       ` Duje Mihanović
2023-10-01 14:12 ` [PATCH RFC v4 2/6] ARM: pxa: Convert Spitz LEDs " Duje Mihanović
2023-10-01 14:34   ` Andy Shevchenko
2023-10-01 14:34     ` Andy Shevchenko
2023-10-02  7:36     ` Bartosz Golaszewski
2023-10-02  7:36       ` Bartosz Golaszewski
2023-10-02  8:54   ` Linus Walleij
2023-10-02  8:54     ` Linus Walleij
2023-10-01 14:12 ` [PATCH RFC v4 3/6] ARM: pxa: Convert Spitz CF power control " Duje Mihanović
2023-10-01 14:12 ` [PATCH RFC v4 4/6] ARM: pxa: Convert reset driver " Duje Mihanović
2023-10-01 14:40   ` Andy Shevchenko
2023-10-01 14:40     ` Andy Shevchenko
2023-10-01 14:50     ` Andy Shevchenko
2023-10-01 14:50       ` Andy Shevchenko
2023-10-01 14:12 ` [PATCH RFC v4 5/6] ARM: pxa: Convert gumstix Bluetooth " Duje Mihanović
2023-10-02  7:42   ` Bartosz Golaszewski
2023-10-02  7:42     ` Bartosz Golaszewski
2023-10-02 14:52     ` Duje Mihanović [this message]
2023-10-02 14:52       ` Duje Mihanović
2023-10-02 17:09       ` Bartosz Golaszewski
2023-10-02 17:09         ` Bartosz Golaszewski
2023-10-01 14:12 ` [PATCH RFC v4 6/6] input: ads7846: Move wait_for_sync() logic to driver Duje Mihanović
2023-10-01 14:56   ` Andy Shevchenko
2023-10-01 14:56     ` Andy Shevchenko
2023-10-02  8:59   ` Linus Walleij
2023-10-02  8:59     ` Linus Walleij
2023-10-02 11:39   ` Mark Brown
2023-10-02 11:39     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4528128.LvFx2qVVIh@radijator \
    --to=duje.mihanovic@skole.hr \
    --cc=andy@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=daniel@zonque.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=robert.jarzmik@free.fr \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.