All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH, RESEND] orangefs: use %zu format string for size_t
Date: Wed, 11 Nov 2015 23:32:11 +0100	[thread overview]
Message-ID: <4529098.FXCydd13Bl@wuerfel> (raw)

On 32-bit architectures, 'size_t' and 'unsigned long' are not necessarily
the same, so we get a compiler warning about it:

fs/orangefs/pvfs2-bufmap.c: In function 'pvfs_bufmap_copy_from_iovec':
fs/orangefs/pvfs2-bufmap.c:521:8: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}' [-Wformat=]

This changes the code to use %zu instead of %lu, which always
matches size_t.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 4d1c44043b26e ("Orangefs: use iov_iter interface")
---
Sent originally on October 7, but not yet applied, and we still get the
same warnings. Please apply.

diff --git a/fs/orangefs/pvfs2-bufmap.c b/fs/orangefs/pvfs2-bufmap.c
index 9d0392a3e824..06fb797dedda 100644
--- a/fs/orangefs/pvfs2-bufmap.c
+++ b/fs/orangefs/pvfs2-bufmap.c
@@ -518,7 +518,7 @@ int pvfs_bufmap_copy_from_iovec(struct pvfs2_bufmap *bufmap,
 	int i;
 
 	gossip_debug(GOSSIP_BUFMAP_DEBUG,
-		     "%s: buffer_index:%d: size:%lu:\n",
+		     "%s: buffer_index:%d: size:%zu:\n",
 		     __func__, buffer_index, size);
 
 	to = &bufmap->desc_array[buffer_index];
@@ -550,7 +550,7 @@ int pvfs_bufmap_copy_to_iovec(struct pvfs2_bufmap *bufmap,
 	size_t written;
 
 	gossip_debug(GOSSIP_BUFMAP_DEBUG,
-		     "%s: buffer_index:%d: iov_iter_count(iter):%lu:\n",
+		     "%s: buffer_index:%d: iov_iter_count(iter):%zu:\n",
 		     __func__, buffer_index, iov_iter_count(iter));
 
 	from = &bufmap->desc_array[buffer_index];

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Mike Marshall <hubcap@omnibond.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH, RESEND] orangefs: use %zu format string for size_t
Date: Wed, 11 Nov 2015 23:32:11 +0100	[thread overview]
Message-ID: <4529098.FXCydd13Bl@wuerfel> (raw)

On 32-bit architectures, 'size_t' and 'unsigned long' are not necessarily
the same, so we get a compiler warning about it:

fs/orangefs/pvfs2-bufmap.c: In function 'pvfs_bufmap_copy_from_iovec':
fs/orangefs/pvfs2-bufmap.c:521:8: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}' [-Wformat=]

This changes the code to use %zu instead of %lu, which always
matches size_t.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 4d1c44043b26e ("Orangefs: use iov_iter interface")
---
Sent originally on October 7, but not yet applied, and we still get the
same warnings. Please apply.

diff --git a/fs/orangefs/pvfs2-bufmap.c b/fs/orangefs/pvfs2-bufmap.c
index 9d0392a3e824..06fb797dedda 100644
--- a/fs/orangefs/pvfs2-bufmap.c
+++ b/fs/orangefs/pvfs2-bufmap.c
@@ -518,7 +518,7 @@ int pvfs_bufmap_copy_from_iovec(struct pvfs2_bufmap *bufmap,
 	int i;
 
 	gossip_debug(GOSSIP_BUFMAP_DEBUG,
-		     "%s: buffer_index:%d: size:%lu:\n",
+		     "%s: buffer_index:%d: size:%zu:\n",
 		     __func__, buffer_index, size);
 
 	to = &bufmap->desc_array[buffer_index];
@@ -550,7 +550,7 @@ int pvfs_bufmap_copy_to_iovec(struct pvfs2_bufmap *bufmap,
 	size_t written;
 
 	gossip_debug(GOSSIP_BUFMAP_DEBUG,
-		     "%s: buffer_index:%d: iov_iter_count(iter):%lu:\n",
+		     "%s: buffer_index:%d: iov_iter_count(iter):%zu:\n",
 		     __func__, buffer_index, iov_iter_count(iter));
 
 	from = &bufmap->desc_array[buffer_index];

             reply	other threads:[~2015-11-11 22:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 22:32 Arnd Bergmann [this message]
2015-11-11 22:32 ` [PATCH, RESEND] orangefs: use %zu format string for size_t Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4529098.FXCydd13Bl@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.