From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Cc: Harald Welte <laforge@netfilter.org>, Patrick McHardy <kaber@trash.net>
Subject: [CTNETLINK] Fix compilation with debugging enabled
Date: Tue, 10 Oct 2006 03:10:22 +0200 [thread overview]
Message-ID: <452AF2FE.1050606@netfilter.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
Two debugging messages inside dump_table refer to variable `id'
that is not declared anymore.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
--
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1964 bytes --]
[CTNETLINK] Fix compilation with debugging enabled
two debugging messages inside dump_table refer to variable `id'
that is not declared anymore.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Index: net-2.6/net/ipv4/netfilter/ip_conntrack_netlink.c
===================================================================
--- net-2.6.orig/net/ipv4/netfilter/ip_conntrack_netlink.c 2006-10-10 03:00:00.000000000 +0200
+++ net-2.6/net/ipv4/netfilter/ip_conntrack_netlink.c 2006-10-10 03:01:36.000000000 +0200
@@ -411,8 +411,7 @@ ctnetlink_dump_table(struct sk_buff *skb
struct ip_conntrack_tuple_hash *h;
struct list_head *i;
- DEBUGP("entered %s, last bucket=%lu id=%u\n", __FUNCTION__,
- cb->args[0], *id);
+ DEBUGP("entered %s, last bucket=%lu\n", __FUNCTION__, cb->args[0]);
read_lock_bh(&ip_conntrack_lock);
last = (struct ip_conntrack *)cb->args[1];
@@ -452,7 +451,7 @@ out:
if (last)
ip_conntrack_put(last);
- DEBUGP("leaving, last bucket=%lu id=%u\n", cb->args[0], *id);
+ DEBUGP("leaving, last bucket=%lu\n", cb->args[0]);
return skb->len;
}
Index: net-2.6/net/netfilter/nf_conntrack_netlink.c
===================================================================
--- net-2.6.orig/net/netfilter/nf_conntrack_netlink.c 2006-10-10 03:02:35.000000000 +0200
+++ net-2.6/net/netfilter/nf_conntrack_netlink.c 2006-10-10 03:03:29.000000000 +0200
@@ -425,8 +425,7 @@ ctnetlink_dump_table(struct sk_buff *skb
struct nfgenmsg *nfmsg = NLMSG_DATA(cb->nlh);
u_int8_t l3proto = nfmsg->nfgen_family;
- DEBUGP("entered %s, last bucket=%lu id=%u\n", __FUNCTION__,
- cb->args[0], *id);
+ DEBUGP("entered %s, last bucket=%lu\n", __FUNCTION__, cb->args[0]);
read_lock_bh(&nf_conntrack_lock);
last = (struct nf_conn *)cb->args[1];
@@ -471,7 +470,7 @@ out:
if (last)
nf_ct_put(last);
- DEBUGP("leaving, last bucket=%lu id=%u\n", cb->args[0], *id);
+ DEBUGP("leaving, last bucket=%lu\n", cb->args[0]);
return skb->len;
}
next reply other threads:[~2006-10-10 1:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 1:10 Pablo Neira Ayuso [this message]
2006-10-10 4:46 ` [CTNETLINK] Fix compilation with debugging enabled Patrick McHardy
2006-10-10 18:07 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452AF2FE.1050606@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.