From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Harald Welte <laforge@netfilter.org>,
Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>
Subject: Re: [CTNETLINK] Fix compilation with debugging enabled
Date: Tue, 10 Oct 2006 20:07:53 +0200 [thread overview]
Message-ID: <452BE179.6090702@netfilter.org> (raw)
In-Reply-To: <452B25BB.6020909@trash.net>
Patrick McHardy wrote:
> Pablo Neira Ayuso wrote:
>> Two debugging messages inside dump_table refer to variable `id'
>> that is not declared anymore.
>
> Are you actually using the debugging stuff? Most of the ctnetlink
> debugging looks like a leftover from early development, so unless
> you think its still useful, I would prefer to remove it entirely
> since it makes the code less readable IMO.
Agreed, I'll cook a patch to remove it
--
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris
prev parent reply other threads:[~2006-10-10 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 1:10 [CTNETLINK] Fix compilation with debugging enabled Pablo Neira Ayuso
2006-10-10 4:46 ` Patrick McHardy
2006-10-10 18:07 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452BE179.6090702@netfilter.org \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.