* Re: Fwd: [PATCH] drivers/{mmc,misc}: handle PCI errors on resume
[not found] <20061012020645.50871.qmail@web36715.mail.mud.yahoo.com>
@ 2006-10-12 5:54 ` Pierre Ossman
0 siblings, 0 replies; only message in thread
From: Pierre Ossman @ 2006-10-12 5:54 UTC (permalink / raw)
To: Alex Dubov, Jeff Garzik, Andrew Morton, LKML
Doesn't Jeff love me anymore? :(
Alex Dubov wrote:
> --- Jeff Garzik <jeff@garzik.org> wrote:
>
>
>> Date: Wed, 11 Oct 2006 17:48:09 -0400
>> From: Jeff Garzik <jeff@garzik.org>
>> To: oakad@yahoo.com, Andrew Morton <akpm@osdl.org>,
>> LKML <linux-kernel@vger.kernel.org>
>> Subject: [PATCH] drivers/{mmc,misc}: handle PCI errors on resume
>>
>>
>> Since pci_enable_device() is one of the first things called in the
>> resume step, take the minimalist approach and return immediately, if
>> pci_enable_device() fails during resume.
>>
>> Also, in sdhci: don't check for impossible condition (chip==NULL)
>>
>> Signed-off-by: Jeff Garzik <jeff@garzik.org>
>>
>>
I'm just being cautious. "This can't happen" is usually the last thing
you here before the end. ;)
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
OLPC, developer http://www.laptop.org
^ permalink raw reply [flat|nested] only message in thread