From: Jeff Garzik <jeff@garzik.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: netdev@vger.kernel.org
Subject: Re: use of tx_timeout in enet driver?
Date: Fri, 13 Oct 2006 12:31:07 -0400 [thread overview]
Message-ID: <452FBF4B.8020803@garzik.org> (raw)
In-Reply-To: <E654CD0D-77A4-4B12-B2D5-FCB9ACFC191B@kernel.crashing.org>
Kumar Gala wrote:
> I'm working on a enet driver and trying to figure out what I should do
> in the tx_timeout function. The device I have doesn't interrupt on tx
> completions so I already have a timer loop to check to see if there have
> been any completions by looking at the ring pointers.
>
> So should I do something like e100 does in using a work_queue to
> effectively reset the card if we get a tx_timeout?
tx_timeout is largely a "traffic stopped, there are still pending TXs on
the queue, see what happened" type event. In theory, it should never
happen as long as the driver gets carrier notification and other details
right. In practice, it is used as a backstop against hard-to-find
driver bugs and hardware faults.
Generic practice is like e100: reset the card from a workqueue, then
restart TX processing.
prev parent reply other threads:[~2006-10-13 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 16:19 use of tx_timeout in enet driver? Kumar Gala
2006-10-13 16:31 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452FBF4B.8020803@garzik.org \
--to=jeff@garzik.org \
--cc=galak@kernel.crashing.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.