use of tx_timeout in enet driver?

use of tx_timeout in enet driver?

[Kumar Gala]

I'm working on a enet driver and trying to figure out what I should  
do in the tx_timeout function.  The device I have doesn't interrupt  
on tx completions so I already have a timer loop to check to see if  
there have been any completions by looking at the ring pointers.

So should I do something like e100 does in using a work_queue to  
effectively reset the card if we get a tx_timeout?

- kumar

Re: use of tx_timeout in enet driver?

[Jeff Garzik]

Kumar Gala wrote:
> I'm working on a enet driver and trying to figure out what I should do 
> in the tx_timeout function.  The device I have doesn't interrupt on tx 
> completions so I already have a timer loop to check to see if there have 
> been any completions by looking at the ring pointers.
> 
> So should I do something like e100 does in using a work_queue to 
> effectively reset the card if we get a tx_timeout?

tx_timeout is largely a "traffic stopped, there are still pending TXs on 
the queue, see what happened" type event.  In theory, it should never 
happen as long as the driver gets carrier notification and other details 
right.  In practice, it is used as a backstop against hard-to-find 
driver bugs and hardware faults.

Generic practice is like e100:  reset the card from a workqueue, then 
restart TX processing.