From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Arjan van de Ven <arjan@infradead.org>,
Amol Lad <amol@verismonetworks.com>,
linux kernel <linux-kernel@vger.kernel.org>,
kernel Janitors <kernel-janitors@lists.osdl.org>
Subject: Re: [KJ] [PATCH] drivers/mmc/mmc.c: Replacing yield() with a
Date: Mon, 16 Oct 2006 06:49:02 +0000 [thread overview]
Message-ID: <45332B5E.8010804@drzeus.cx> (raw)
In-Reply-To: <452DD88E.4030707@yahoo.com.au>
Nick Piggin wrote:
>
> The condition looks broken too. It should be
> if (ms < 1000 / HZ) {...}
>
> Shouldn't it?
Yup. I poked Russell about it ages ago, but he must have forgotten (and
admittedly, so have I). Since MMC is now on my table, I guess I should
put it on my todo list.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
OLPC, developer http://www.laptop.org
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Arjan van de Ven <arjan@infradead.org>,
Amol Lad <amol@verismonetworks.com>,
linux kernel <linux-kernel@vger.kernel.org>,
kernel Janitors <kernel-janitors@lists.osdl.org>
Subject: Re: [PATCH] drivers/mmc/mmc.c: Replacing yield() with a better alternative
Date: Mon, 16 Oct 2006 08:49:02 +0200 [thread overview]
Message-ID: <45332B5E.8010804@drzeus.cx> (raw)
In-Reply-To: <452DD88E.4030707@yahoo.com.au>
Nick Piggin wrote:
>
> The condition looks broken too. It should be
> if (ms < 1000 / HZ) {...}
>
> Shouldn't it?
Yup. I poked Russell about it ages ago, but he must have forgotten (and
admittedly, so have I). Since MMC is now on my table, I guess I should
put it on my todo list.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
OLPC, developer http://www.laptop.org
next prev parent reply other threads:[~2006-10-16 6:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 12:45 [PATCH] drivers/mmc/mmc.c: Replacing yield() with a better alternative Amol Lad
2006-10-11 12:57 ` [KJ] [PATCH] drivers/mmc/mmc.c: Replacing yield() with a Amol Lad
2006-10-11 12:58 ` Arjan van de Ven
2006-10-11 12:58 ` [PATCH] drivers/mmc/mmc.c: Replacing yield() with a better alternative Arjan van de Ven
2006-10-11 14:16 ` [KJ] most users of msleep_interruptible are broken Matthew Wilcox
2006-10-11 14:16 ` Matthew Wilcox
2006-10-11 14:20 ` [KJ] " Pierre Ossman
2006-10-11 14:20 ` Pierre Ossman
2006-10-11 14:53 ` [KJ] " Arjan van de Ven
2006-10-11 14:53 ` Arjan van de Ven
2006-10-11 15:07 ` [KJ] " Pierre Ossman
2006-10-11 15:07 ` Pierre Ossman
2006-10-11 20:30 ` [KJ] " Pavel Machek
2006-10-11 20:30 ` Pavel Machek
2006-10-12 5:54 ` [KJ] [PATCH] drivers/mmc/mmc.c: Replacing yield() with a Nick Piggin
2006-10-12 5:54 ` [PATCH] drivers/mmc/mmc.c: Replacing yield() with a better alternative Nick Piggin
2006-10-16 6:49 ` Pierre Ossman [this message]
2006-10-16 6:49 ` Pierre Ossman
2006-10-22 20:23 ` [KJ] [PATCH] drivers/mmc/mmc.c: Replacing yield() with a Pierre Ossman
2006-10-22 20:23 ` [PATCH] drivers/mmc/mmc.c: Replacing yield() with a better alternative Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45332B5E.8010804@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=amol@verismonetworks.com \
--cc=arjan@infradead.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.