From: Gerd Hoffmann <kraxel@suse.de>
To: Jan Beulich <jbeulich@novell.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [patch rfc 1/3] xen arch header rework.
Date: Mon, 16 Oct 2006 10:06:39 +0200 [thread overview]
Message-ID: <45333D8F.8010400@suse.de> (raw)
In-Reply-To: <4530C120020000780002437E@emea5-mh.id5.novell.com>
Jan Beulich wrote:
>>>> Gerd Hoffmann <kraxel@suse.de> 10/11/06 11:16 AM >>>
>> Jan Beulich wrote:
>>>> + uint32_t unused; /* alignment */
>>> Could you use _pad[0-9]* here as is done elsewhere, so that scripts
>> Fixed using "_attribute__((aligned (8)))" instead.
>
> If I remember right, we had complaints about such an approach already -
> public headers shouldn't contain (unconditional) GNU-isms.
Current patch adds one level of indirection for that, so the solaris
guys can add something which works for sun cc.
Latest version of the patch is here:
http://www.suse.de/~kraxel/patches/kraxel-unstable-zweiblum-hg11751-quilt/learning-python.diff
cheers,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
http://www.suse.de/~kraxel/julika-dora.jpeg
next prev parent reply other threads:[~2006-10-16 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-14 9:51 [patch rfc 1/3] xen arch header rework Jan Beulich
2006-10-16 8:06 ` Gerd Hoffmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-10-05 9:05 [patch rfc 0/3] xen arch header patches kraxel
2006-10-05 9:05 ` [patch rfc 1/3] xen arch header rework kraxel
2006-10-05 12:27 ` Jan Beulich
2006-10-05 13:08 ` Gerd Hoffmann
2006-10-11 9:16 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45333D8F.8010400@suse.de \
--to=kraxel@suse.de \
--cc=jbeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.