Re: [alsa-cvslog] alsa-lib: Implements support for capture/playback enums.

[James Courtier-Dutton <James@superbug.demon.co.uk>]

Takashi Iwai wrote:
> At Sat, 14 Oct 2006 12:24:10 +0100,
> James Courtier-Dutton wrote:
>> Jaroslav Kysela wrote:
>>> On Fri, 13 Oct 2006, James Courtier-Dutton wrote:
>>>
>>>> +	{" Playback Enum", CTL_PLAYBACK_ENUM},
>>>> +	{" Capture Enum", CTL_CAPTURE_ENUM},
>>>> +	{" Enum", CTL_GLOBAL_ENUM},
>>> I don't like this. We already know, that it's the enum type, so it's not 
>>> required to put this type to control id name again.
>>>
>>> Could you just check, if control id name ends with " Capture" or 
>>> " Playback" words and set CTL_XXXX_ENUM according that?
>>>
>>> 						Jaroslav
>>>
>> I would actually prefer to pass the info via the TLV interface.
> 
> Reason?
> 
> We already have the interface and we must keep it for compatibility
> reason, at least...
> 
> 
> Takashi
> 

The interface for splitting PLAYBACK ENUMs from CAPTURE ENUMs has not
been implemented until I just did it. So what "compatibility" do we have
to keep too. This is a alsa-driver to alsa-lib interface, and using the
TLV interface will not break anything. I don't see where the problem is.

James


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642