* Re: [alsa-cvslog] alsa-lib: Implements support for capture/playback enums. [not found] <ALOGGER1160773600.5@alsa-project.org> @ 2006-10-14 7:02 ` Jaroslav Kysela 2006-10-14 11:24 ` James Courtier-Dutton 2006-10-21 16:13 ` James Courtier-Dutton 0 siblings, 2 replies; 6+ messages in thread From: Jaroslav Kysela @ 2006-10-14 7:02 UTC (permalink / raw) To: James Courtier-Dutton; +Cc: ALSA development On Fri, 13 Oct 2006, James Courtier-Dutton wrote: > + {" Playback Enum", CTL_PLAYBACK_ENUM}, > + {" Capture Enum", CTL_CAPTURE_ENUM}, > + {" Enum", CTL_GLOBAL_ENUM}, I don't like this. We already know, that it's the enum type, so it's not required to put this type to control id name again. Could you just check, if control id name ends with " Capture" or " Playback" words and set CTL_XXXX_ENUM according that? Jaroslav ----- Jaroslav Kysela <perex@suse.cz> Linux Kernel Sound Maintainer ALSA Project, SUSE Labs ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [alsa-cvslog] alsa-lib: Implements support for capture/playback enums. 2006-10-14 7:02 ` [alsa-cvslog] alsa-lib: Implements support for capture/playback enums Jaroslav Kysela @ 2006-10-14 11:24 ` James Courtier-Dutton 2006-10-16 9:47 ` Takashi Iwai 2006-10-21 16:13 ` James Courtier-Dutton 1 sibling, 1 reply; 6+ messages in thread From: James Courtier-Dutton @ 2006-10-14 11:24 UTC (permalink / raw) To: Jaroslav Kysela; +Cc: ALSA development Jaroslav Kysela wrote: > On Fri, 13 Oct 2006, James Courtier-Dutton wrote: > >> + {" Playback Enum", CTL_PLAYBACK_ENUM}, >> + {" Capture Enum", CTL_CAPTURE_ENUM}, >> + {" Enum", CTL_GLOBAL_ENUM}, > > I don't like this. We already know, that it's the enum type, so it's not > required to put this type to control id name again. > > Could you just check, if control id name ends with " Capture" or > " Playback" words and set CTL_XXXX_ENUM according that? > > Jaroslav > I would actually prefer to pass the info via the TLV interface. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [alsa-cvslog] alsa-lib: Implements support for capture/playback enums. 2006-10-14 11:24 ` James Courtier-Dutton @ 2006-10-16 9:47 ` Takashi Iwai 2006-10-16 10:19 ` James Courtier-Dutton 0 siblings, 1 reply; 6+ messages in thread From: Takashi Iwai @ 2006-10-16 9:47 UTC (permalink / raw) To: James Courtier-Dutton; +Cc: ALSA development, Jaroslav Kysela At Sat, 14 Oct 2006 12:24:10 +0100, James Courtier-Dutton wrote: > > Jaroslav Kysela wrote: > > On Fri, 13 Oct 2006, James Courtier-Dutton wrote: > > > >> + {" Playback Enum", CTL_PLAYBACK_ENUM}, > >> + {" Capture Enum", CTL_CAPTURE_ENUM}, > >> + {" Enum", CTL_GLOBAL_ENUM}, > > > > I don't like this. We already know, that it's the enum type, so it's not > > required to put this type to control id name again. > > > > Could you just check, if control id name ends with " Capture" or > > " Playback" words and set CTL_XXXX_ENUM according that? > > > > Jaroslav > > > > I would actually prefer to pass the info via the TLV interface. Reason? We already have the interface and we must keep it for compatibility reason, at least... Takashi ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [alsa-cvslog] alsa-lib: Implements support for capture/playback enums. 2006-10-16 9:47 ` Takashi Iwai @ 2006-10-16 10:19 ` James Courtier-Dutton 2006-10-16 10:26 ` Takashi Iwai 0 siblings, 1 reply; 6+ messages in thread From: James Courtier-Dutton @ 2006-10-16 10:19 UTC (permalink / raw) To: Takashi Iwai; +Cc: ALSA development, Jaroslav Kysela Takashi Iwai wrote: > At Sat, 14 Oct 2006 12:24:10 +0100, > James Courtier-Dutton wrote: >> Jaroslav Kysela wrote: >>> On Fri, 13 Oct 2006, James Courtier-Dutton wrote: >>> >>>> + {" Playback Enum", CTL_PLAYBACK_ENUM}, >>>> + {" Capture Enum", CTL_CAPTURE_ENUM}, >>>> + {" Enum", CTL_GLOBAL_ENUM}, >>> I don't like this. We already know, that it's the enum type, so it's not >>> required to put this type to control id name again. >>> >>> Could you just check, if control id name ends with " Capture" or >>> " Playback" words and set CTL_XXXX_ENUM according that? >>> >>> Jaroslav >>> >> I would actually prefer to pass the info via the TLV interface. > > Reason? > > We already have the interface and we must keep it for compatibility > reason, at least... > > > Takashi > The interface for splitting PLAYBACK ENUMs from CAPTURE ENUMs has not been implemented until I just did it. So what "compatibility" do we have to keep too. This is a alsa-driver to alsa-lib interface, and using the TLV interface will not break anything. I don't see where the problem is. James ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [alsa-cvslog] alsa-lib: Implements support for capture/playback enums. 2006-10-16 10:19 ` James Courtier-Dutton @ 2006-10-16 10:26 ` Takashi Iwai 0 siblings, 0 replies; 6+ messages in thread From: Takashi Iwai @ 2006-10-16 10:26 UTC (permalink / raw) To: James Courtier-Dutton; +Cc: ALSA development, Jaroslav Kysela At Mon, 16 Oct 2006 11:19:37 +0100, James Courtier-Dutton wrote: > > Takashi Iwai wrote: > > At Sat, 14 Oct 2006 12:24:10 +0100, > > James Courtier-Dutton wrote: > >> Jaroslav Kysela wrote: > >>> On Fri, 13 Oct 2006, James Courtier-Dutton wrote: > >>> > >>>> + {" Playback Enum", CTL_PLAYBACK_ENUM}, > >>>> + {" Capture Enum", CTL_CAPTURE_ENUM}, > >>>> + {" Enum", CTL_GLOBAL_ENUM}, > >>> I don't like this. We already know, that it's the enum type, so it's not > >>> required to put this type to control id name again. > >>> > >>> Could you just check, if control id name ends with " Capture" or > >>> " Playback" words and set CTL_XXXX_ENUM according that? > >>> > >>> Jaroslav > >>> > >> I would actually prefer to pass the info via the TLV interface. > > > > Reason? > > > > We already have the interface and we must keep it for compatibility > > reason, at least... > > > > > > Takashi > > > > The interface for splitting PLAYBACK ENUMs from CAPTURE ENUMs has not > been implemented until I just did it. So what "compatibility" do we have > to keep too. This is a alsa-driver to alsa-lib interface, and using the > TLV interface will not break anything. I don't see where the problem is. You'd need more extra code in the driver to add TLV support. Takashi ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [alsa-cvslog] alsa-lib: Implements support for capture/playback enums. 2006-10-14 7:02 ` [alsa-cvslog] alsa-lib: Implements support for capture/playback enums Jaroslav Kysela 2006-10-14 11:24 ` James Courtier-Dutton @ 2006-10-21 16:13 ` James Courtier-Dutton 1 sibling, 0 replies; 6+ messages in thread From: James Courtier-Dutton @ 2006-10-21 16:13 UTC (permalink / raw) To: Jaroslav Kysela; +Cc: ALSA development Jaroslav Kysela wrote: > On Fri, 13 Oct 2006, James Courtier-Dutton wrote: > >> + {" Playback Enum", CTL_PLAYBACK_ENUM}, >> + {" Capture Enum", CTL_CAPTURE_ENUM}, >> + {" Enum", CTL_GLOBAL_ENUM}, > > I don't like this. We already know, that it's the enum type, so it's not > required to put this type to control id name again. > > Could you just check, if control id name ends with " Capture" or > " Playback" words and set CTL_XXXX_ENUM according that? > Is did it that way, for consistency. If you look at the naming of switches, volumes, I just used the same pattern for enums. James ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-10-21 16:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <ALOGGER1160773600.5@alsa-project.org>
2006-10-14 7:02 ` [alsa-cvslog] alsa-lib: Implements support for capture/playback enums Jaroslav Kysela
2006-10-14 11:24 ` James Courtier-Dutton
2006-10-16 9:47 ` Takashi Iwai
2006-10-16 10:19 ` James Courtier-Dutton
2006-10-16 10:26 ` Takashi Iwai
2006-10-21 16:13 ` James Courtier-Dutton
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.