From: Jeff Garzik <jgarzik@pobox.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Andy Warner <andyw@pobox.com>, Mark Rustad <mrustad@mac.com>,
"Darrick J. Wong" <djwong@us.ibm.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Alexis Bruemmer <alexisb@us.ibm.com>,
Mike Anderson <andmike@us.ibm.com>
Subject: Re: [PATCH] libsas: support NCQ for SATA disks
Date: Mon, 16 Oct 2006 17:34:28 -0400 [thread overview]
Message-ID: <4533FAE4.3010601@pobox.com> (raw)
In-Reply-To: <1161023130.3433.21.camel@mulgrave.il.steeleye.com>
James Bottomley wrote:
> --- BUILD-2.6.orig/drivers/scsi/libsas/sas_discover.c 2006-10-16 11:38:47.000000000 -0500
> +++ BUILD-2.6/drivers/scsi/libsas/sas_discover.c 2006-10-16 13:06:12.000000000 -0500
> @@ -376,6 +376,7 @@ static int sas_issue_ata_cmd(struct doma
>
> task->dev = dev;
>
> + task->ata_task.fis.fis_type = 0x27;
> task->ata_task.fis.command = command;
> task->ata_task.fis.features = features;
> task->ata_task.fis.device = d2h_fis->device;
As an aside, please clean up that magic number by assigning it a named
constant (suggest SATA_FIS_H2D_REG) in include/linux/ata.h.
Jeff
next prev parent reply other threads:[~2006-10-16 21:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 23:56 [PATCH] libsas: support NCQ for SATA disks Darrick J. Wong
2006-10-15 17:42 ` James Bottomley
2006-10-15 18:43 ` Darrick J. Wong
2006-10-15 19:42 ` Luben Tuikov
2006-10-16 1:27 ` Mark Rustad
2006-10-16 1:49 ` Andy Warner
2006-10-16 2:22 ` Luben Tuikov
2006-10-16 18:25 ` James Bottomley
2006-10-16 21:34 ` Jeff Garzik [this message]
2006-10-16 23:34 ` James Bottomley
2006-10-16 22:40 ` Brian King
2006-10-17 11:15 ` Jeff Garzik
2006-10-17 16:35 ` James Bottomley
2006-10-17 22:42 ` Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4533FAE4.3010601@pobox.com \
--to=jgarzik@pobox.com \
--cc=James.Bottomley@SteelEye.com \
--cc=alexisb@us.ibm.com \
--cc=andmike@us.ibm.com \
--cc=andyw@pobox.com \
--cc=djwong@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mrustad@mac.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.