From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Martin Bligh <mbligh@google.com>
Cc: Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management <linux-mm@kvack.org>,
Nick Piggin <npiggin@suse.de>
Subject: Re: [RFC] Remove temp_priority
Date: Wed, 18 Oct 2006 03:42:38 +1000 [thread overview]
Message-ID: <4535160E.2010908@yahoo.com.au> (raw)
In-Reply-To: <45351423.70804@google.com>
Martin Bligh wrote:
> This is not tested yet. What do you think?
>
> This patch removes temp_priority, as it is racy. We're setting
> prev_priority from it, and yet temp_priority could have been
> set back to DEF_PRIORITY by another reclaimer.
I like it. I wonder if we should get kswapd to stick its priority
into the zone at the point where zone_watermark_ok becomes true,
rather than setting all zones to the lowest priority? That would
require a bit more logic though I guess.
For that matter (going off the topic a bit), I wonder if
try_to_free_pages should have a watermark check there too? This
might help reduce the latency issue you brought up where one process
has reclaimed a lot of pages, but another isn't making any progress
and has to go through the full priority range? Maybe that's
statistically pretty unlikely?
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Martin Bligh <mbligh@google.com>
Cc: Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management <linux-mm@kvack.org>,
Nick Piggin <npiggin@suse.de>
Subject: Re: [RFC] Remove temp_priority
Date: Wed, 18 Oct 2006 03:42:38 +1000 [thread overview]
Message-ID: <4535160E.2010908@yahoo.com.au> (raw)
In-Reply-To: <45351423.70804@google.com>
Martin Bligh wrote:
> This is not tested yet. What do you think?
>
> This patch removes temp_priority, as it is racy. We're setting
> prev_priority from it, and yet temp_priority could have been
> set back to DEF_PRIORITY by another reclaimer.
I like it. I wonder if we should get kswapd to stick its priority
into the zone at the point where zone_watermark_ok becomes true,
rather than setting all zones to the lowest priority? That would
require a bit more logic though I guess.
For that matter (going off the topic a bit), I wonder if
try_to_free_pages should have a watermark check there too? This
might help reduce the latency issue you brought up where one process
has reclaimed a lot of pages, but another isn't making any progress
and has to go through the full priority range? Maybe that's
statistically pretty unlikely?
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-10-17 17:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 17:34 [RFC] Remove temp_priority Martin Bligh
2006-10-17 17:42 ` Nick Piggin [this message]
2006-10-17 17:42 ` Nick Piggin
2006-10-17 17:52 ` Martin Bligh
2006-10-17 17:52 ` Martin Bligh
2006-10-18 12:42 ` Nick Piggin
2006-10-18 12:42 ` Nick Piggin
2006-10-18 14:47 ` Martin J. Bligh
2006-10-18 14:47 ` Martin J. Bligh
2006-10-18 14:56 ` Nick Piggin
2006-10-18 14:56 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4535160E.2010908@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mbligh@google.com \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.