All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org
Subject: Re: [KJ] [PATCH] OOM killer meets userspace headers
Date: Wed, 18 Oct 2006 19:34:33 +0000	[thread overview]
Message-ID: <453681C9.7020904@yahoo.com.au> (raw)
In-Reply-To: <20061018192404.GE5345@martell.zuzino.mipt.ru>

Alexey Dobriyan wrote:
> On Thu, Oct 19, 2006 at 05:12:19AM +1000, Nick Piggin wrote:
> 
>>Alexey Dobriyan wrote:
>>
>>>On Thu, Oct 19, 2006 at 01:05:53AM +1000, Nick Piggin wrote:
>>>
>>>
>>>>>+#define OOM_ADJUST_MIN (-16)
>>>>>+#define OOM_ADJUST_MAX 15
>>>>
>>>>Why do you need the () for the -ves?
>>>
>>>
>>>-16 is two tokens. Not that someone is going to do huge arithmetic with
>>>OOM adjustments and screwup himself, but still...
>>
>>How can they screw themselves up? AFAIKS, the - directly to the left
>>of the literal will bind more tightly than any other valid operator.
> 
> 
> Hmmm... c.l.c lists two reasons: a) =- being synonym of -= in pre-ANSI
> days, and b) fat fingers
> 
> 	#define EOF -1
> 	while ((c = getchar()) != 3 EOF)

I can't say I care about those problems to justify the uglification
(or churning the tree).

If the operator were legitimately able to leak out, obviously () is
a good thing. Otherwise...

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org
Subject: Re: [PATCH] OOM killer meets userspace headers
Date: Thu, 19 Oct 2006 05:34:33 +1000	[thread overview]
Message-ID: <453681C9.7020904@yahoo.com.au> (raw)
In-Reply-To: <20061018192404.GE5345@martell.zuzino.mipt.ru>

Alexey Dobriyan wrote:
> On Thu, Oct 19, 2006 at 05:12:19AM +1000, Nick Piggin wrote:
> 
>>Alexey Dobriyan wrote:
>>
>>>On Thu, Oct 19, 2006 at 01:05:53AM +1000, Nick Piggin wrote:
>>>
>>>
>>>>>+#define OOM_ADJUST_MIN (-16)
>>>>>+#define OOM_ADJUST_MAX 15
>>>>
>>>>Why do you need the () for the -ves?
>>>
>>>
>>>-16 is two tokens. Not that someone is going to do huge arithmetic with
>>>OOM adjustments and screwup himself, but still...
>>
>>How can they screw themselves up? AFAIKS, the - directly to the left
>>of the literal will bind more tightly than any other valid operator.
> 
> 
> Hmmm... c.l.c lists two reasons: a) =- being synonym of -= in pre-ANSI
> days, and b) fat fingers
> 
> 	#define EOF -1
> 	while ((c = getchar()) != 3 EOF)

I can't say I care about those problems to justify the uglification
(or churning the tree).

If the operator were legitimately able to leak out, obviously () is
a good thing. Otherwise...

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 

  reply	other threads:[~2006-10-18 19:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-18 14:53 [PATCH] OOM killer meets userspace headers Alexey Dobriyan
2006-10-18 15:05 ` Nick Piggin
2006-10-18 18:46   ` [KJ] " Alexey Dobriyan
2006-10-18 18:46     ` Alexey Dobriyan
2006-10-18 19:12     ` [KJ] " Nick Piggin
2006-10-18 19:12       ` Nick Piggin
2006-10-18 19:24       ` [KJ] " Alexey Dobriyan
2006-10-18 19:24         ` Alexey Dobriyan
2006-10-18 19:34         ` Nick Piggin [this message]
2006-10-18 19:34           ` Nick Piggin
2006-10-18 15:08 ` David Woodhouse
2006-10-18 15:09 ` Christoph Hellwig
2006-10-18 18:21   ` [PATCH v2] " Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=453681C9.7020904@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=adobriyan@gmail.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.