From: Patrick McHardy <kaber@trash.net>
To: htejun@gmail.com
Cc: jeff@garzik.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: "libata: fix non-uniform ports handling" breaks sata_sis secondary port
Date: Sat, 21 Oct 2006 17:38:52 +0200 [thread overview]
Message-ID: <453A3F0C.3000406@trash.net> (raw)
The patch "libata: fix non-uniform ports handling" breaks the
secondary SATA port with the sata_sis driver for me (no link
detected). The reason seems to be that the SIS_FLAG_CFGSCR flag
is only set on probe_ent->port_flags in sis_init_one(), but
ata_port_init() uses ent->pinfo2->flags for initialization of
the flags in struct ata_port for the secondary port.
lspci entry of the controller below, if more information is needed
please ask.
0000:00:05.0 RAID bus controller: Silicon Integrated Systems [SiS] RAID
bus controller 180 SATA/PATA [SiS] (rev 01) (prog-if 85)
Subsystem: ASUSTeK Computer Inc.: Unknown device 810e
Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B-
Status: Cap- 66MHz+ UDF- FastB2B- ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
Latency: 128
Interrupt: pin A routed to IRQ 18
Region 0: I/O ports at eff0 [size=8]
Region 1: I/O ports at efe4 [size=4]
Region 2: I/O ports at efa8 [size=8]
Region 3: I/O ports at efe0 [size=4]
Region 4: I/O ports at ef90 [size=16]
Region 5: I/O ports at <unassigned>
next reply other threads:[~2006-10-21 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-21 15:38 Patrick McHardy [this message]
2006-10-23 3:48 ` [PATCH] sata_sis: fix flags handling for the secondary port Tejun Heo
2006-10-23 10:33 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453A3F0C.3000406@trash.net \
--to=kaber@trash.net \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.